Page MenuHomePhabricator
Create Task
Maniphest T257448

Don’t define Repo content model constants in PHP entry point
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Stop defining Repo content model constants in PHP entry pointmediawiki/extensions/Wikibasemaster+0 -4
Avoid using constants defined in php entry point for content modelsmediawiki/extensions/Wikibasemaster+36 -25
Remove backward compatibility piece left from 2016mediawiki/extensions/PropertySuggestermaster+0 -8
Using class constants instead of generic ones for content modelmediawiki/extensions/WikibaseCirrusSearchmaster+2 -2
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedLadsgroupT257433 Convert Repo to use Extension Registration
ResolvedLadsgroupT257448 Don’t define Repo content model constants in PHP entry point
· · ·

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 8 2020, 1:37 PM
gerritbot added a comment.Jul 8 2020, 7:42 PM

Change 610356 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Avoid using constants defined in php entry point for content models

https://gerrit.wikimedia.org/r/610356

Restricted Application added a project: Wikidata. · View Herald TranscriptJul 8 2020, 7:42 PM
gerritbot added a project: Patch-For-Review.Jul 8 2020, 7:42 PM
Ladsgroup claimed this task.Jul 8 2020, 7:42 PM
Ladsgroup moved this task from Backlog to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 3) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 8 2020, 7:42 PM
gerritbot added a comment.Jul 8 2020, 7:46 PM

Change 610357 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseCirrusSearch@master] Using class constants instead of generic ones for content model

https://gerrit.wikimedia.org/r/610357

gerritbot added a comment.Jul 8 2020, 7:47 PM

Change 610358 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/PropertySuggester@master] Using class constants instead of generic ones for content model

https://gerrit.wikimedia.org/r/610358

gerritbot added a comment.Jul 8 2020, 7:50 PM

Change 610360 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Stop defining Repo content model constants in PHP entry point

https://gerrit.wikimedia.org/r/610360

gerritbot added a comment.Jul 9 2020, 5:22 PM

Change 610356 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Avoid using constants defined in php entry point for content models

https://gerrit.wikimedia.org/r/610356

gerritbot added a comment.Jul 9 2020, 5:22 PM

Change 610357 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Using class constants instead of generic ones for content model

https://gerrit.wikimedia.org/r/610357

gerritbot added a comment.Jul 9 2020, 5:22 PM

Change 610358 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Remove backward compatibility piece left from 2016

https://gerrit.wikimedia.org/r/610358

gerritbot added a comment.Jul 9 2020, 5:23 PM

Change 610360 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop defining Repo content model constants in PHP entry point

https://gerrit.wikimedia.org/r/610360

Ladsgroup moved this task from Peer Review to Verification on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 9 2020, 5:33 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 9 2020, 6:00 PM
Ladsgroup mentioned this in rEPS5968cec4c42b: Remove backward compatibility piece left from 2016.Jul 9 2020, 6:02 PM
Ladsgroup mentioned this in rEWCS537169dc97d0: Using class constants instead of generic ones for content model.
Maintenance_bot removed a project: Patch-For-Review.Jul 9 2020, 6:10 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 15 2020, 12:18 PM
Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikibase Extension Decoupling and Registration (Sprint 3) board.
Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Jul 15 2020, 1:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL