Parsoid should not disable GC unless a config var is set
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	cscott
	Jul 8 2020, 2:36 PM

Description

For LTS we should probably protect the code which disables GC with a configuration variable, and set it to true in production but false by default.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Make garbage collection on PHP 7.2 configurable via ParsoidSettings	mediawiki/services/parsoid	master	+14 -1
	Make GC in PHP 7.2 configurable in Parsoid, but don't change production	operations/mediawiki-config	master	+2 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
Open		None	T396539 Introduce a way to edit a span of text from within read mode
Open		None	T385558 Improve copy and paste from read mode to VE
Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
Open		None	T258836 [EPIC] Ensure Parsoid meets performance criteria for serving read views on the Parsoid cluster
Open		None	T254508 Reconcile Parsoid memory usage w/ legacy parser and mediawiki core
Resolved		ssastry	T254509 Turn on garbage collection for Parsoid cluster
Declined		None	T257462 Parsoid should not disable GC unless a config var is set

Event Timeline

cscott created this task.Jul 8 2020, 2:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2020, 2:36 PM

cscott mentioned this in T248343: Uncached VisualEditor w/ Parsoid/PHP (no JS, no RESTBase) for MW 1.35 LTS.Jul 8 2020, 2:38 PM

cscott added a parent task: T254509: Turn on garbage collection for Parsoid cluster.Jul 8 2020, 6:05 PM

Change 610339 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Make garbage collection on PHP 7.2 configurable via ParsoidSettings

https://gerrit.wikimedia.org/r/610339

gerritbot added a project: Patch-For-Review.Jul 8 2020, 6:37 PM

Change 610341 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[operations/mediawiki-config@master] Make GC in PHP 7.2 configurable in Parsoid, but don't change production

https://gerrit.wikimedia.org/r/610341

Not entirely sold on this because the code required is a little bit heavyweight, but these are the patches required if we decide to do this.

ssastry added a project: Parsing-Active-Work.Jul 9 2020, 5:34 PM

I am not convinced yet we need to do this. We can chat in today's meeting.

Change 610341 abandoned by C. Scott Ananian:
[operations/mediawiki-config@master] Make GC in PHP 7.2 configurable in Parsoid, but don't change production

Reason:
We decided we didn't need to make this configurable.

https://gerrit.wikimedia.org/r/610341

Change 610339 abandoned by C. Scott Ananian:
[mediawiki/services/parsoid@master] Make garbage collection on PHP 7.2 configurable via ParsoidSettings