Page MenuHomePhabricator
Create Task
Maniphest T257566

Migrate ShowSearchHitHandler to json
Closed, ResolvedPublic
Actions

Description

And use the new hook handler system (T240307: Hook container with strong types and DI) if possible.

Details

SubjectRepoBranchLines +/-
Migrate ShowSearchHitHandler to Hook Containersmediawiki/extensions/Wikibasemaster+106 -148
Migrate ShowSearchHitHandler to extension registrationmediawiki/extensions/Wikibasemaster+2 -2
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT257445 Migrate Repo hooks to extension JSON file
ResolvedTarrowT257566 Migrate ShowSearchHitHandler to json
· · ·

Event Timeline

Ladsgroup created this task.Jul 9 2020, 11:38 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJul 9 2020, 11:38 AM
Tarrow claimed this task.Jul 14 2020, 8:52 AM
Tarrow moved this task from Backlog to Doing on the Wikibase Extension Decoupling and Registration (Sprint 3) board.
gerritbot added a comment.Jul 15 2020, 1:59 PM

Change 612869 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Migrate ShowSearchHitHandler to extension registration

https://gerrit.wikimedia.org/r/612869

gerritbot added a project: Patch-For-Review.Jul 15 2020, 1:59 PM
gerritbot added a comment.Jul 16 2020, 3:54 PM

Change 613193 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Migrate ShowSearchHitHandler to Hook Containers

https://gerrit.wikimedia.org/r/613193

gerritbot added a comment.Jul 16 2020, 4:45 PM

Change 612869 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Migrate ShowSearchHitHandler to extension registration

https://gerrit.wikimedia.org/r/612869

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 16 2020, 5:00 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 17 2020, 9:01 AM
gerritbot added a comment.Jul 17 2020, 1:47 PM

Change 613193 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Migrate ShowSearchHitHandler to Hook Containers

https://gerrit.wikimedia.org/r/613193

Ladsgroup moved this task from Peer Review to Verification on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 17 2020, 3:27 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 17 2020, 5:05 PM
Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikibase Extension Decoupling and Registration (Sprint 3) board.

Change was deployed on Beta and hook still works.

Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Jul 17 2020, 5:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL