Page MenuHomePhabricator
Create Task
Maniphest T257804

Update docs/hooks.txt to reflect the new hook system.
Closed, ResolvedPublic
Actions

Description

It seems that docs/hooks.txt is largely obsolete now that the new hook system has been established.

It should probably be replaced by pointers to the respective pages on mediawiki.org.

The documentation of hook signatures should be removed.

Details

SubjectRepoBranchLines +/-
Update the hooks documentation included with MediaWiki.mediawiki/coremaster+5 -4 K
Remove obsolete findHooks.php script.mediawiki/coreREL1_35+1 -357
Remove obsolete findHooks.php script.mediawiki/coremaster+1 -357
Update the hooks documentation included with MediaWiki.mediawiki/coreREL1_35+5 -4 K
Customize query in gerrit

Related Objects

Event Timeline

daniel created this task.Jul 13 2020, 10:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2020, 10:59 AM
Jdforrester-WMF added a project: MW-1.35-release.Jul 13 2020, 11:00 AM
Jdforrester-WMF subscribed.
Urbanecm subscribed.Jul 13 2020, 11:13 AM
BPirkle triaged this task as High priority.Jul 14 2020, 8:20 PM
BPirkle edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
BPirkle subscribed.

hooks.txt already references Hooks.md. It seems like we can simply eliminate everything from hooks.txt except the first sentence.

BPirkle moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.Jul 14 2020, 8:20 PM
BPirkle moved this task from Later to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.
gerritbot added a comment.Jul 15 2020, 8:48 PM

Change 612950 had a related patch set uploaded (by BPirkle; owner: BPirkle):
[mediawiki/core@master] Remove most of hooks.txt, now that the file is obsolete.

https://gerrit.wikimedia.org/r/612950

gerritbot added a project: Patch-For-Review.Jul 15 2020, 8:48 PM
BPirkle claimed this task.Jul 15 2020, 8:51 PM
BPirkle moved this task from Ready (WIP:5) to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.
gerritbot added a comment.Jul 16 2020, 9:59 PM

Change 612950 merged by jenkins-bot:
[mediawiki/core@master] Update the hooks documentation included with MediaWiki.

https://gerrit.wikimedia.org/r/612950

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2020, 10:11 PM
gerritbot added a comment.Jul 17 2020, 10:32 AM

Change 613178 had a related patch set uploaded (by Daniel Kinzler; owner: BPirkle):
[mediawiki/core@REL1_35] Update the hooks documentation included with MediaWiki.

https://gerrit.wikimedia.org/r/613178

gerritbot added a project: Patch-For-Review.Jul 17 2020, 10:32 AM
gerritbot added a comment.Jul 17 2020, 10:51 AM

Change 613178 merged by jenkins-bot:
[mediawiki/core@REL1_35] Update the hooks documentation included with MediaWiki.

https://gerrit.wikimedia.org/r/613178

gerritbot added a comment.Jul 17 2020, 11:08 AM

Change 613616 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Remove obsolete findHooks.php script.

https://gerrit.wikimedia.org/r/613616

Jdforrester-WMF mentioned this in T115959: Change maintenance/findHooks.php to use YAML [Outreachy microtask].Jul 17 2020, 11:38 AM
Jdforrester-WMF mentioned this in T22345: Add unit test for finding hooks not documented in hooks.txt (findHooks.php).
gerritbot added a comment.Jul 17 2020, 12:03 PM

Change 613616 merged by jenkins-bot:
[mediawiki/core@master] Remove obsolete findHooks.php script.

https://gerrit.wikimedia.org/r/613616

Maintenance_bot removed a project: Patch-For-Review.Jul 17 2020, 12:10 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 17 2020, 1:00 PM
gerritbot added a comment.Jul 17 2020, 1:04 PM

Change 613179 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@REL1_35] Remove obsolete findHooks.php script.

https://gerrit.wikimedia.org/r/613179

gerritbot added a project: Patch-For-Review.Jul 17 2020, 1:04 PM
Jdforrester-WMF added a comment.Jul 17 2020, 4:38 PM

Resolved?

gerritbot added a comment.Jul 17 2020, 4:46 PM

Change 613179 merged by jenkins-bot:
[mediawiki/core@REL1_35] Remove obsolete findHooks.php script.

https://gerrit.wikimedia.org/r/613179

Akuckartz awarded a token.Jul 17 2020, 4:55 PM
ReleaseTaggerBot added a project: MW-1.35-notes.Jul 17 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 17 2020, 5:10 PM
Krinkle moved this task from Untriaged to Hook documentation on the MediaWiki-Core-Hooks board.Jul 24 2020, 8:01 PM
BPirkle closed this task as Resolved.Jul 27 2020, 3:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL