Page MenuHomePhabricator
Create Task
Maniphest T257850

QA: Orange Mobile large banners
Closed, ResolvedPublic
Actions

Description

Hi John,

Could you QA these orange banners for mobile large/enNL?

Context: Color tests--no other changes to the control code.
Deadline: We'll put them up when you're done.
As you can see from the links, just English: Thanks!

Orange banner with orange border: https://en.m.wikipedia.org/wiki/Apple?banner=scervantes_B2021_0708_enNL_m_p1_lg_txt_twin1_orangeborder&country=NL

Orange banner with black text: https://en.m.wikipedia.org/wiki/Apple?banner=scervantes_B2021_0708_enNL_m_p1_lg_txt_twin1_lightorangebg_darktext&country=NL

Orange banner with orange text: https://en.m.wikipedia.org/wiki/Apple?banner=scervantes_B2021_0708_enNL_m_p1_lg_txt_twin1_lightorangebg_orangetext&country=NL

(Control, just for reference: https://en.m.wikipedia.org/wiki/Apple?banner=B2021_0708_enNL_m_p1_lg_txt_twin1&country=NL)

Related Objects
Search...

Event Timeline

• TSkaff created this task.Jul 13 2020, 3:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2020, 3:42 PM
• TSkaff added a comment.Jul 16 2020, 3:30 PM

Hi John,

Could I bump this in priority? I'd love to replace the NL dark banners with one of these if we can (since they've live). Thanks!

• jbolorinos-ctr added a comment.EditedJul 16 2020, 9:20 PM

Hey @TSkaff, sure feel free to bump the priority when needed (I think I will get a notification for that too when you do).

Screenshot Test Results Mobile:

• jbolorinos-ctr added a parent task: T255833: [Candidate] NL Banners (Duplicate of Asana task).Jul 16 2020, 10:18 PM
• TSkaff added a comment.Jul 20 2020, 4:59 PM

Hi @jbolorinos-ctr! Can I put these up? We can talk separately about the contrast issues but it's in control and isn't a blocker for now.

Thanks!

• jbolorinos-ctr closed subtask T258230: [M Lg] Low contrast on "We ask you, humbly, to help." text in Orange background w/ orange border as Invalid.Jul 20 2020, 6:00 PM
• jbolorinos-ctr added a comment.Jul 20 2020, 8:54 PM

Hey @TSkaff

Yes all screenshot tests have now been reviewed, and all reported issues resolved, so these banners are now READY TO TEST!

• jbolorinos-ctr closed this task as Resolved.Jul 20 2020, 8:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits