Page MenuHomePhabricator
Create Task
Maniphest T258337

Advanced search doesn't handle removing template name
Closed, DuplicatePublic1 Estimated Story Points
Actions

Description

Chrome Version 83.0.4103.116 (Official Build) (64-bit)
MacOS 10.13.6 (17G13035)

Repeat by:

  1. Navigate to the advanced search form (https://en.wikipedia.org/w/index.php?search=&title=Special%3ASearch&go=Go)
  1. Enter a template name into "Pages with these templates". You should now have something that looks like the first attached screenshot.
    Screen Shot 2020-07-18 at 5.04.01 PM.png (1×1 px, 178 KB)
  1. Position the cursor after this template and type Delete.

Expected result: The template name will be deleted.

Observed result: It turns into "[object Object]". See second screenshot.

Screen Shot 2020-07-18 at 5.04.40 PM.png (1×1 px, 178 KB)

Details

SubjectRepoBranchLines +/-
[WIP] Fix several broken code paths related to LabelElement#getLabeloojs/uimaster+23 -2
Update OOUI to v0.40.3mediawiki/coremaster+254 -121
Update OOUI to v0.40.2mediawiki/coremaster+179 -98
Fix lookup code failing on titles with invalid charactersmediawiki/extensions/AdvancedSearchmaster+47 -12
Follow-up I669cfeeb: Fix the removing of windows being broken by `this` scoping issueoojs/uimaster+17 -2
Rewrite insufficient label mixin documentationoojs/uimaster+15 -5
Fix "[object Object]" bug in page name lookupsmediawiki/extensions/AdvancedSearchmaster+10 -8
Customize query in gerrit

Related Objects

Event Timeline

RoySmith created this task.Jul 18 2020, 9:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2020, 9:11 PM
Ammarpad subscribed.Jul 20 2020, 7:45 AM

This only happens if you use the Delete key. You can easily remove it with the x button that's on the template name.

That's said, when you used the delete key, an error is logged in the console: "Uncaught TypeError: Cannot read property 'getUrl' of null", maybe that's the root cause

gerritbot added a comment.Aug 4 2020, 3:57 PM

Change 618338 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Fix "[object Object]" bug in page name lookups

https://gerrit.wikimedia.org/r/618338

gerritbot added a project: Patch-For-Review.Aug 4 2020, 3:57 PM
thiemowmde claimed this task.Aug 4 2020, 3:58 PM
thiemowmde added projects: WMDE-QWERTY-Sprint-2020-07-22, Unplanned-Sprint-Work.
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-07-22 board.
gerritbot added a comment.Aug 4 2020, 6:46 PM

Change 618369 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Fix lookup code failing on titles with invalid characters

https://gerrit.wikimedia.org/r/618369

thiemowmde mentioned this in T239208: Lexemes: Grammatical form can render as `[object Object]`.Aug 4 2020, 7:00 PM
gerritbot added a comment.Aug 6 2020, 10:38 AM

Change 618729 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[oojs/ui@master] Fix several broken code paths related to LabelElement#getLabel

https://gerrit.wikimedia.org/r/618729

gerritbot added a comment.Aug 10 2020, 1:08 PM

Change 619293 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[oojs/ui@master] Rewrite insufficient label mixin documentation

https://gerrit.wikimedia.org/r/619293

thiemowmde set the point value for this task to 1.Aug 12 2020, 9:49 AM
thiemowmde closed this task as a duplicate of T249167: Removing category filter in Advanced search shows "[object Object]".Aug 12 2020, 9:54 AM
gerritbot added a comment.Aug 19 2020, 12:08 PM

Change 618338 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Fix "[object Object]" bug in page name lookups

https://gerrit.wikimedia.org/r/618338

gerritbot added a comment.Aug 19 2020, 12:18 PM

Change 619293 merged by jenkins-bot:
[oojs/ui@master] Rewrite insufficient label mixin documentation

https://gerrit.wikimedia.org/r/619293

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 19 2020, 1:00 PM
gerritbot added a comment.Aug 21 2020, 11:54 AM

Change 621711 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.40.2

https://gerrit.wikimedia.org/r/621711

Reedy mentioned this in T245824: Error in "App closes on clicking the cancel button".Aug 22 2020, 4:31 PM
gerritbot added a comment.Aug 24 2020, 9:55 AM

Change 621989 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[oojs/ui@master] Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

gerritbot added a comment.Aug 24 2020, 1:06 PM

Change 621989 merged by jenkins-bot:
[oojs/ui@master] Follow-up I669cfeeb: Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

gerritbot added a comment.Aug 25 2020, 11:58 AM

Change 618369 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Fix lookup code failing on titles with invalid characters

https://gerrit.wikimedia.org/r/618369

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.8; 2020-09-08); removed MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 25 2020, 12:00 PM
gerritbot added a comment.Sep 2 2020, 3:58 PM

Change 623824 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.40.3

https://gerrit.wikimedia.org/r/623824

gerritbot added a comment.Sep 3 2020, 2:36 AM

Change 621711 abandoned by Reedy:
[mediawiki/core@master] Update OOUI to v0.40.2

Reason:
Replaced by https://gerrit.wikimedia.org/r/c/mediawiki/core/ /623824

https://gerrit.wikimedia.org/r/621711

gerritbot added a comment.Sep 9 2020, 2:19 PM

Change 623824 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.40.3

https://gerrit.wikimedia.org/r/623824

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL