Page MenuHomePhabricator

Advanced search doesn't handle removing template name
Closed, DuplicatePublic1 Estimated Story Points

Description

Chrome Version 83.0.4103.116 (Official Build) (64-bit)
MacOS 10.13.6 (17G13035)

Repeat by:

  1. Navigate to the advanced search form (https://en.wikipedia.org/w/index.php?search=&title=Special%3ASearch&go=Go)
  1. Enter a template name into "Pages with these templates". You should now have something that looks like the first attached screenshot.
  1. Position the cursor after this template and type Delete.

Expected result: The template name will be deleted.

Observed result: It turns into "[object Object]". See second screenshot.

Event Timeline

RoySmith created this task.Jul 18 2020, 9:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2020, 9:11 PM

This only happens if you use the Delete key. You can easily remove it with the x button that's on the template name.

That's said, when you used the delete key, an error is logged in the console: "Uncaught TypeError: Cannot read property 'getUrl' of null", maybe that's the root cause

Change 618338 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Fix "[object Object]" bug in page name lookups

https://gerrit.wikimedia.org/r/618338

Change 618369 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Fix lookup code failing on titles with invalid characters

https://gerrit.wikimedia.org/r/618369

Change 618729 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[oojs/ui@master] Fix several broken code paths related to LabelElement#getLabel

https://gerrit.wikimedia.org/r/618729

Change 619293 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[oojs/ui@master] Rewrite insufficient label mixin documentation

https://gerrit.wikimedia.org/r/619293

thiemowmde set the point value for this task to 1.Aug 12 2020, 9:49 AM

Change 618338 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Fix "[object Object]" bug in page name lookups

https://gerrit.wikimedia.org/r/618338

Change 619293 merged by jenkins-bot:
[oojs/ui@master] Rewrite insufficient label mixin documentation

https://gerrit.wikimedia.org/r/619293

Change 621711 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.40.2

https://gerrit.wikimedia.org/r/621711

Change 621989 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[oojs/ui@master] Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

Change 621989 merged by jenkins-bot:
[oojs/ui@master] Follow-up I669cfeeb: Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

Change 618369 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Fix lookup code failing on titles with invalid characters

https://gerrit.wikimedia.org/r/618369

Change 623824 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.40.3

https://gerrit.wikimedia.org/r/623824

Change 621711 abandoned by Reedy:
[mediawiki/core@master] Update OOUI to v0.40.2

Reason:
Replaced by https://gerrit.wikimedia.org/r/c/mediawiki/core/ /623824

https://gerrit.wikimedia.org/r/621711

Change 623824 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.40.3

https://gerrit.wikimedia.org/r/623824