Page MenuHomePhabricator

Error in "App closes on clicking the cancel button"
Closed, ResolvedPublic

Description

Seen in https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/21548/console on mw core patch to wmf deployment branch (https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/573993/)

Also in https://gerrit.wikimedia.org/r/572265 on https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/21547/console

14:28:50 [0-1] 2020-02-21T13:28:50.016Z ERROR webdriver: Request failed due to Error: unknown command: session/dbb8ec040c577d8f66a670f4257bb328/se/log
14:28:50     at getErrorFromResponseBody (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/webdriver/build/utils.js:117:12)
14:28:50     at Request._callback (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/webdriver/build/request.js:111:64)
14:28:50     at Request.self.callback (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/request/request.js:185:22)
14:28:50     at Request.emit (events.js:189:13)
14:28:50     at Request.EventEmitter.emit (domain.js:441:20)
14:28:50     at Request.<anonymous> (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/request/request.js:1154:10)
14:28:50     at Request.emit (events.js:189:13)
14:28:50     at Request.EventEmitter.emit (domain.js:441:20)
14:28:50     at IncomingMessage.<anonymous> (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/request/request.js:1076:12)
14:28:50     at Object.onceWrapper (events.js:277:13)
14:28:50     at IncomingMessage.emit (events.js:194:15)
14:28:50     at IncomingMessage.EventEmitter.emit (domain.js:441:20)
14:28:50     at endReadableNT (_stream_readable.js:1103:12)
14:28:50     at process._tickCallback (internal/process/next_tick.js:63:19)
14:28:50 2020-02-21T13:28:50.018Z ERROR @wdio/sync: Error: unknown command: session/dbb8ec040c577d8f66a670f4257bb328/se/log
14:28:50     at endReadableNT (_stream_readable.js:1103:12)
14:28:50     at Object.afterTest (/workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/wdio.conf.js:158:14)
14:28:50 [0-1] Error in "AfterTest Hook"
14:28:50 unknown command: session/dbb8ec040c577d8f66a670f4257bb328/se/log
14:28:50 [0-1] Error in "App closes on clicking the cancel button"

Event Timeline

Change 574394 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] bridge: Fix failing browser tests

https://gerrit.wikimedia.org/r/574394

Change 572205 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Maybe make browser test less flaky

https://gerrit.wikimedia.org/r/572205

Change 574394 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Remove getLogs from wdio config

https://gerrit.wikimedia.org/r/574394

Change 572205 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Maybe make browser test less flaky

https://gerrit.wikimedia.org/r/572205

Pablo-WMDE claimed this task.
Pablo-WMDE added a subscriber: Pablo-WMDE.

We did not receive any reports that this happened again, let's call it until further notice.

And in https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/56367/console seemingly

Maybe not the same error, but very similar...

13:30:37 [chrome 73.0.3683.75 Linux #0-1] Spec: /workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/canCancel.js
13:30:37 [chrome 73.0.3683.75 Linux #0-1] Running: chrome (v73.0.3683.75) on Linux
13:30:37 [chrome 73.0.3683.75 Linux #0-1] Session ID: 086aa197bc05bd7378fbbb5265cc8585
13:30:37 [chrome 73.0.3683.75 Linux #0-1]
13:30:37 [chrome 73.0.3683.75 Linux #0-1] App
13:30:37 [chrome 73.0.3683.75 Linux #0-1]    ✖ closes on clicking the close button
13:30:37 [chrome 73.0.3683.75 Linux #0-1]
13:30:37 [chrome 73.0.3683.75 Linux #0-1] 1 failing (13.8s)
13:30:37 [chrome 73.0.3683.75 Linux #0-1]
13:30:37 [chrome 73.0.3683.75 Linux #0-1] 1) App closes on clicking the close button
13:30:37 [chrome 73.0.3683.75 Linux #0-1] App still exists in the DOM after clicking the close button
13:30:37 [chrome 73.0.3683.75 Linux #0-1] Error: App still exists in the DOM after clicking the close button
13:30:37 [chrome 73.0.3683.75 Linux #0-1]     at Context.it (/workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/canCancel.js:40:22)

In this patch, it has happened twice back to back: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/621711

If it happens for the third time, I guess It would be a UBN.

Third error back to back, this might be a really really flaky thing or upgrading ooui to 0.40.2 would actually break the bridge. cc. This week's IM @Michael

Reedy triaged this task as High priority.EditedAug 22 2020, 4:31 PM
Reedy added a project: Wikidata-Campsite.

Sticking this as high, even though I've just reverted and bumped the vendor patch. I don't really see how that vendor patch (they're just l10n updates) is causing the problems; it's probably the changes in the core patch at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/621711...

Either way... It results in the fixes for T249167, T258337, T258428, T259906, T259912, T260519 being blocked for rollout etc

Ugh, always on a Friday evening. Looking into it a bit and also coordinating with this weeks IM @Addshore

Change 621989 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[oojs/ui@master] Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

This is not a Data Bridge bug. It is a bug in the new release of the OOJS-UI library and our browser tests merely caught that bug. Good thing that we have them.

Change 621989 merged by jenkins-bot:
[oojs/ui@master] Follow-up I669cfeeb: Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

Change 623824 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.40.3

https://gerrit.wikimedia.org/r/623824

Change 623824 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.40.3

https://gerrit.wikimedia.org/r/623824

Jakob_WMDE removed Pablo-WMDE as the assignee of this task.
Jakob_WMDE added a subscriber: Jakob_WMDE.

This has been fixed for a while. Nothing left to be done.