Error in "App closes on clicking the cancel button"
Closed, ResolvedPublic
Actions

Description

Seen in https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/21548/console on mw core patch to wmf deployment branch (https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/573993/)

Also in https://gerrit.wikimedia.org/r/572265 on https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/21547/console

14:28:50 [0-1] 2020-02-21T13:28:50.016Z ERROR webdriver: Request failed due to Error: unknown command: session/dbb8ec040c577d8f66a670f4257bb328/se/log
14:28:50     at getErrorFromResponseBody (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/webdriver/build/utils.js:117:12)
14:28:50     at Request._callback (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/webdriver/build/request.js:111:64)
14:28:50     at Request.self.callback (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/request/request.js:185:22)
14:28:50     at Request.emit (events.js:189:13)
14:28:50     at Request.EventEmitter.emit (domain.js:441:20)
14:28:50     at Request.<anonymous> (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/request/request.js:1154:10)
14:28:50     at Request.emit (events.js:189:13)
14:28:50     at Request.EventEmitter.emit (domain.js:441:20)
14:28:50     at IncomingMessage.<anonymous> (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/request/request.js:1076:12)
14:28:50     at Object.onceWrapper (events.js:277:13)
14:28:50     at IncomingMessage.emit (events.js:194:15)
14:28:50     at IncomingMessage.EventEmitter.emit (domain.js:441:20)
14:28:50     at endReadableNT (_stream_readable.js:1103:12)
14:28:50     at process._tickCallback (internal/process/next_tick.js:63:19)
14:28:50 2020-02-21T13:28:50.018Z ERROR @wdio/sync: Error: unknown command: session/dbb8ec040c577d8f66a670f4257bb328/se/log
14:28:50     at endReadableNT (_stream_readable.js:1103:12)
14:28:50     at Object.afterTest (/workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/wdio.conf.js:158:14)
14:28:50 [0-1] Error in "AfterTest Hook"
14:28:50 unknown command: session/dbb8ec040c577d8f66a670f4257bb328/se/log
14:28:50 [0-1] Error in "App closes on clicking the cancel button"

Details

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.40.3	mediawiki/core	master	+254 -121
Follow-up I669cfeeb: Fix the removing of windows being broken by `this` scoping issue	oojs/ui	master	+17 -2
bridge: Maybe make browser test less flaky	mediawiki/extensions/Wikibase	master	+1 -0
bridge: Remove getLogs from wdio config	mediawiki/extensions/Wikibase	master	+0 -8

Customize query in gerrit

Related Objects

Mentioned In: T261045: App still exists in the DOM after clicking the close button Wikibase client test fails
Mentioned Here: T249167: Removing category filter in Advanced search shows "[object Object]"
T258337: Advanced search doesn't handle removing template name
T258428: TypeError: element is undefined (from OO.ui.mixin.AccessKeyedElement)
T259906: Add 'volumeUp', 'volumeDown' and 'volumeMute' icons in Design Style Guide & OOUI
T259912: Keyboard Tabbing Order for PopupWidget in Reverse(shift-tabbing) is out-of-order
T260519: ToggleSwitchWidget: widget has wrong role 'checkbox' when it should be 'switch'

Event Timeline

Reedy created this task.Feb 21 2020, 1:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2020, 1:33 PM

Reedy added a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Feb 21 2020, 1:33 PM

Reedy updated the task description. (Show Details)

Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.Feb 24 2020, 9:16 AM

Addshore subscribed.

WMDE-leszek subscribed.Feb 24 2020, 9:18 AM

• Tonina_Zhelyazkova_WMDE added a project: Wikidata-Bridge-Sprint-14.Feb 24 2020, 9:23 AM

Tarrow subscribed.Feb 24 2020, 9:37 AM

Change 574394 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] bridge: Fix failing browser tests

https://gerrit.wikimedia.org/r/574394

gerritbot added a project: Patch-For-Review.Feb 24 2020, 9:59 AM

• Pablo-WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-14 board.Feb 24 2020, 10:45 AM

Change 572205 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Maybe make browser test less flaky

https://gerrit.wikimedia.org/r/572205

Change 574394 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Remove getLogs from wdio config

https://gerrit.wikimedia.org/r/574394

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 24 2020, 1:00 PM

Change 572205 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Maybe make browser test less flaky

https://gerrit.wikimedia.org/r/572205

Maintenance_bot removed a project: Patch-For-Review.Feb 24 2020, 3:10 PM

• Tonina_Zhelyazkova_WMDE moved this task from Doing to Verification on the Wikidata-Bridge-Sprint-14 board.Feb 24 2020, 4:03 PM

Lydia_Pintscher removed a project: Wikidata-Campsite.Feb 25 2020, 1:23 PM

• Pablo-WMDE added a project: Wikidata-Bridge-Sprint-15.Feb 26 2020, 9:45 AM

• Pablo-WMDE moved this task from To do to Verification on the Wikidata-Bridge-Sprint-15 board.

We did not receive any reports that this happened again, let's call it until further notice.

• Pablo-WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-15 board.Mar 3 2020, 10:39 AM

It happened again, in wmf-quibble-selenium-php72-docker #24928 for I2046893053.

Edit: also in #26619

Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Apr 18 2020, 10:53 PM

And in https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/56367/console seemingly

Maybe not the same error, but very similar...

13:30:37 [chrome 73.0.3683.75 Linux #0-1] Spec: /workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/canCancel.js
13:30:37 [chrome 73.0.3683.75 Linux #0-1] Running: chrome (v73.0.3683.75) on Linux
13:30:37 [chrome 73.0.3683.75 Linux #0-1] Session ID: 086aa197bc05bd7378fbbb5265cc8585
13:30:37 [chrome 73.0.3683.75 Linux #0-1]
13:30:37 [chrome 73.0.3683.75 Linux #0-1] App
13:30:37 [chrome 73.0.3683.75 Linux #0-1]    ✖ closes on clicking the close button
13:30:37 [chrome 73.0.3683.75 Linux #0-1]
13:30:37 [chrome 73.0.3683.75 Linux #0-1] 1 failing (13.8s)
13:30:37 [chrome 73.0.3683.75 Linux #0-1]
13:30:37 [chrome 73.0.3683.75 Linux #0-1] 1) App closes on clicking the close button
13:30:37 [chrome 73.0.3683.75 Linux #0-1] App still exists in the DOM after clicking the close button
13:30:37 [chrome 73.0.3683.75 Linux #0-1] Error: App still exists in the DOM after clicking the close button
13:30:37 [chrome 73.0.3683.75 Linux #0-1]     at Context.it (/workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/canCancel.js:40:22)

In this patch, it has happened twice back to back: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/621711

If it happens for the third time, I guess It would be a UBN.

Third error back to back, this might be a really really flaky thing or upgrading ooui to 0.40.2 would actually break the bridge. cc. This week's IM @Michael

Reedy mentioned this in T261045: App still exists in the DOM after clicking the close button Wikibase client test fails.Aug 22 2020, 4:24 PM

Sticking this as high, even though I've just reverted and bumped the vendor patch. I don't really see how that vendor patch (they're just l10n updates) is causing the problems; it's probably the changes in the core patch at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/621711...

Either way... It results in the fixes for T249167, T258337, T258428, T259906, T259912, T260519 being blocked for rollout etc

Reedy edited projects, added Wikidata-Bridge; removed Wikidata-Bridge-Sprint-15, Wikidata-Bridge-Sprint-14.Aug 22 2020, 4:46 PM

xSavitar merged a task: T261045: App still exists in the DOM after clicking the close button Wikibase client test fails.Aug 22 2020, 7:12 PM

xSavitar added subscribers: xSavitar, DannyS712.

Ugh, always on a Friday evening. Looking into it a bit and also coordinating with this weeks IM @Addshore

Change 621989 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[oojs/ui@master] Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

gerritbot added a project: Patch-For-Review.Aug 24 2020, 9:55 AM

This is not a Data Bridge bug. It is a bug in the new release of the OOJS-UI library and our browser tests merely caught that bug. Good thing that we have them.

Change 621989 merged by jenkins-bot:
[oojs/ui@master] Follow-up I669cfeeb: Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

Maintenance_bot removed a project: Patch-For-Review.Aug 24 2020, 1:11 PM

WMDE-leszek edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Sep 1 2020, 12:25 PM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Sep 1 2020, 1:15 PM

Change 623824 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.40.3

https://gerrit.wikimedia.org/r/623824

gerritbot added a project: Patch-For-Review.Sep 2 2020, 3:58 PM

Change 623824 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.40.3