Page MenuHomePhabricator

ToggleSwitchWidget: widget has wrong role 'checkbox' when it should be 'switch'
Closed, ResolvedPublic

Description

Impact: Assistive technology doesn't announce it as the right control and might cause confusion for impaired users

image.png (719×1 px, 103 KB)

Event Timeline

Change 620662 had a related patch set uploaded (by Tam-edwin-microsoft; owner: Tam-edwin-microsoft):
[oojs/ui@master] ToggleSwitchWidget: fixed wrong role type

https://gerrit.wikimedia.org/r/620662

Change 620662 merged by jenkins-bot:
[oojs/ui@master] ToggleSwitchWidget: fixed wrong role type

https://gerrit.wikimedia.org/r/620662

Change 621711 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.40.2

https://gerrit.wikimedia.org/r/621711

Change 621989 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[oojs/ui@master] Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

Change 621989 merged by jenkins-bot:
[oojs/ui@master] Follow-up I669cfeeb: Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

Is there more to do in this task, or could this task be resolved (via Add Action...Change Status in the dropdown menu)? Thanks in advance! :)

@Volker_E merged the original patch with suggestion. Is there a need to link a separate item to track this feedback or is just documenting here enough?

Merging with some cautionary feedback. Haven't found any clear overview if switch role is as well rendered (supported) as checkbox. Also it's not fully clear if screenreader users are as familiar with toggle switches as with checkboxes. I assume the switch role would imply a direct action in the interface like a light switch. Sadly our ToggleSwitches are not limited to these use cases in current implementation, they are used basically as checkboxes with a submit button further down in some views.

But let's go for the aspirational standard approach.

Change 623824 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.40.3

https://gerrit.wikimedia.org/r/623824

Change 621711 abandoned by Reedy:
[mediawiki/core@master] Update OOUI to v0.40.2

Reason:
Replaced by https://gerrit.wikimedia.org/r/c/mediawiki/core/ /623824

https://gerrit.wikimedia.org/r/621711

Change 623824 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.40.3

https://gerrit.wikimedia.org/r/623824

@Aklapper Since "recently" we kept those tasks open until the next release of OOUI is merged into core, vendor and VE to openly clarify when folks can expect changes being visible on test environments and in production.

Volker_E triaged this task as Medium priority.
Volker_E moved this task from Backlog to OOUI-0.40.3 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.40.3); removed OOUI.
Volker_E removed a project: Patch-For-Review.