Page MenuHomePhabricator
Create Task
Maniphest T259186

Parsoid CI is failing when parser tests are run
Closed, ResolvedPublic
Actions

Description

This seems to be fallout from T246358: Jenkins no longer fails build if mw-error.log or mw-dberror.log are non-empty. All Parsoid CI is failing in parsoidsvc-parsertests-docker, which is supposed to check out mediawiki-core and run parsoid's copy of the parser tests with the current master branch of mediawiki, to ensure that we don't commit parser tests to Parsoid which fail when sync'ed back to mediawiki-core. Example: PS2 of https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/616194 has https://integration.wikimedia.org/ci/job/parsoidsvc-parsertests-docker/9757/console which ends with:

13:28:26 Passed 10 of 10 tests (100%)... ALL TESTS PASSED!
13:28:26 INFO:backend.DevWebServer:Terminating DevWebServer
13:28:26 INFO:quibble.commands:<<< Finish: User commands: services/parsoid/tools/ci-mw-parsertests.sh, in 12.160 s
13:28:28 [parsoidsvc-parsertests-docker] $ /bin/bash -xe /tmp/jenkins3792618522510488452.sh
13:28:28 + set -eu
13:28:28 + ERROR_FILES=(mw-dberror.log mw-error.log)
13:28:28 + echo 'Asserting empty files: mw-dberror.log mw-error.log'
13:28:28 Asserting empty files: mw-dberror.log mw-error.log
13:28:28 ++ cd /srv/jenkins/workspace/workspace/parsoidsvc-parsertests-docker/log
13:28:28 ++ ls mw-dberror.log mw-error.log
13:28:28 + log_files='mw-dberror.log
13:28:28 mw-error.log'
13:28:28 + '[' '!' 'mw-dberror.log
13:28:28 mw-error.log' ']'
13:28:28 + echo 'Dumping file(s) mw-dberror.log
13:28:28 mw-error.log'
13:28:28 Dumping file(s) mw-dberror.log
13:28:28 mw-error.log
13:28:28 + set +e
13:28:28 + cd /srv/jenkins/workspace/workspace/parsoidsvc-parsertests-docker/log
13:28:28 + grep --color . mw-dberror.log mw-error.log
13:28:28 mw-dberror.log:Wed Jul 29 17:28:16 UTC 2020	5f1db4b712dd	wikidb-parsertest_	Error 1 from ChangeTags::getTags, no such table: parsertest_change_tag SELECT  ct_tag_id AS "value"  FROM parsertest_change_tag    WHERE ct_rc_id = 12 AND ct_rev_id = 12 AND ct_log_id = '19'   localhost
13:28:28 mw-dberror.log:#0 /workspace/src/includes/libs/rdbms/database/Database.php(1654): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
13:28:28 mw-dberror.log:#1 /workspace/src/includes/libs/rdbms/database/Database.php(1227): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
13:28:28 mw-dberror.log:#2 /workspace/src/includes/libs/rdbms/database/Database.php(1903): Wikimedia\Rdbms\Database->query(string, string, integer)
13:28:28 mw-dberror.log:#3 /workspace/src/includes/libs/rdbms/database/Database.php(1765): Wikimedia\Rdbms\Database->select(string, array, array, string, array, array)
13:28:28 mw-dberror.log:#4 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->selectFieldValues(string, string, array, string)
13:28:28 mw-dberror.log:#5 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(306): Wikimedia\Rdbms\DBConnRef->__call(string, array)
13:28:28 mw-dberror.log:#6 /workspace/src/includes/changetags/ChangeTags.php(499): Wikimedia\Rdbms\DBConnRef->selectFieldValues(string, string, array, string)
13:28:28 mw-dberror.log:#7 /workspace/src/includes/changetags/ChangeTags.php(382): ChangeTags::getTags(Wikimedia\Rdbms\MaintainableDBConnRef, integer, integer, string)
13:28:28 mw-dberror.log:#8 /workspace/src/includes/changetags/ChangeTags.php(275): ChangeTags::updateTags(array, array, integer, integer, string, NULL, RecentChange)
13:28:28 mw-dberror.log:#9 /workspace/src/includes/changes/RecentChange.php(400): ChangeTags::addTags(array, integer, integer, string, NULL, RecentChange)
13:28:28 mw-dberror.log:#10 /workspace/src/includes/changes/RecentChange.php(764): RecentChange->save()
13:28:28 mw-dberror.log:#11 /workspace/src/includes/deferred/MWCallableUpdate.php(38): RecentChange::{closure}()
13:28:28 mw-dberror.log:#12 /workspace/src/includes/deferred/DeferredUpdates.php(467): MWCallableUpdate->doUpdate()
13:28:28 mw-dberror.log:#13 /workspace/src/includes/deferred/DeferredUpdates.php(344): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
13:28:28 mw-dberror.log:#14 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, MediaWiki\Logger\LegacyLogger, BufferingStatsdDataFactory, string)
13:28:28 mw-dberror.log:#15 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
13:28:28 mw-dberror.log:#16 /workspace/src/includes/deferred/DeferredUpdates.php(491): DeferredUpdates::doUpdates(string)
13:28:28 mw-dberror.log:#17 /workspace/src/maintenance/includes/Maintenance.php(695): DeferredUpdates::tryOpportunisticExecute(string)
13:28:28 mw-dberror.log:#18 /workspace/src/includes/libs/rdbms/database/Database.php(4224): Maintenance::{closure}(integer, Wikimedia\Rdbms\DatabaseSqlite)
13:28:28 mw-dberror.log:#19 /workspace/src/includes/libs/rdbms/database/Database.php(4593): Wikimedia\Rdbms\Database->runTransactionListenerCallbacks(integer)
13:28:28 mw-dberror.log:#20 /workspace/src/includes/libs/rdbms/database/Database.php(4354): Wikimedia\Rdbms\Database->commit(string, string)
13:28:28 mw-dberror.log:#21 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->endAtomic(string)
13:28:28 mw-dberror.log:#22 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(629): Wikimedia\Rdbms\DBConnRef->__call(string, array)
13:28:28 mw-dberror.log:#23 /workspace/src/includes/Storage/PageUpdater.php(1305): Wikimedia\Rdbms\DBConnRef->endAtomic(string)
13:28:28 mw-dberror.log:#24 /workspace/src/includes/Storage/PageUpdater.php(812): MediaWiki\Storage\PageUpdater->doCreate(CommentStoreComment, User, integer)
13:28:28 mw-dberror.log:#25 /workspace/src/includes/page/WikiPage.php(2024): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
13:28:28 mw-dberror.log:#26 /workspace/src/tests/parser/ParserTestRunner.php(1687): WikiPage->doEditContent(WikitextContent, CommentStoreComment, integer)
13:28:28 mw-dberror.log:#27 /workspace/src/tests/parser/ParserTestRunner.php(1627): ParserTestRunner->addArticle(string, string, string, integer)
13:28:28 mw-dberror.log:#28 /workspace/src/tests/parser/ParserTestRunner.php(776): ParserTestRunner->addArticles(array)
13:28:28 mw-dberror.log:#29 /workspace/src/tests/parser/ParserTestRunner.php(711): ParserTestRunner->runTests(array)
13:28:28 mw-dberror.log:#30 /workspace/src/tests/parser/parserTests.php(189): ParserTestRunner->runTestsFromFiles(array)
13:28:28 mw-dberror.log:#31 /workspace/src/maintenance/doMaintenance.php(107): ParserTestsMaintenance->execute()
13:28:28 mw-dberror.log:#32 /workspace/src/tests/parser/parserTests.php(200): require_once(string)
13:28:28 mw-dberror.log:#33 {main}
13:28:28 mw-dberror.log:Wed Jul 29 17:28:17 UTC 2020	5f1db4b712dd	wikidb-parsertest_	Error 1 from ChangeTags::getTags, no such table: parsertest_change_tag SELECT  ct_tag_id AS "value"  FROM parsertest_change_tag    WHERE ct_rc_id = 65 AND ct_rev_id = 66 AND ct_log_id = '73'   localhost
13:28:28 mw-dberror.log:#0 /workspace/src/includes/libs/rdbms/database/Database.php(1654): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
13:28:28 mw-dberror.log:#1 /workspace/src/includes/libs/rdbms/database/Database.php(1227): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
13:28:28 mw-dberror.log:#2 /workspace/src/includes/libs/rdbms/database/Database.php(1903): Wikimedia\Rdbms\Database->query(string, string, integer)
13:28:28 mw-dberror.log:#3 /workspace/src/includes/libs/rdbms/database/Database.php(1765): Wikimedia\Rdbms\Database->select(string, array, array, string, array, array)
13:28:28 mw-dberror.log:#4 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->selectFieldValues(string, string, array, string)
13:28:28 mw-dberror.log:#5 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(306): Wikimedia\Rdbms\DBConnRef->__call(string, array)
13:28:28 mw-dberror.log:#6 /workspace/src/includes/changetags/ChangeTags.php(499): Wikimedia\Rdbms\DBConnRef->selectFieldValues(string, string, array, string)
13:28:28 mw-dberror.log:#7 /workspace/src/includes/changetags/ChangeTags.php(382): ChangeTags::getTags(Wikimedia\Rdbms\MaintainableDBConnRef, integer, integer, string)
13:28:28 mw-dberror.log:#8 /workspace/src/includes/changetags/ChangeTags.php(275): ChangeTags::updateTags(array, array, integer, integer, string, NULL, RecentChange)
13:28:28 mw-dberror.log:#9 /workspace/src/includes/changes/RecentChange.php(400): ChangeTags::addTags(array, integer, integer, string, NULL, RecentChange)
13:28:28 mw-dberror.log:#10 /workspace/src/includes/changes/RecentChange.php(764): RecentChange->save()
13:28:28 mw-dberror.log:#11 /workspace/src/includes/deferred/MWCallableUpdate.php(38): RecentChange::{closure}()
13:28:28 mw-dberror.log:#12 /workspace/src/includes/deferred/DeferredUpdates.php(467): MWCallableUpdate->doUpdate()
13:28:28 mw-dberror.log:#13 /workspace/src/includes/deferred/DeferredUpdates.php(344): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
13:28:28 mw-dberror.log:#14 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, MediaWiki\Logger\LegacyLogger, BufferingStatsdDataFactory, string)
13:28:28 mw-dberror.log:#15 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
13:28:28 mw-dberror.log:#16 /workspace/src/includes/deferred/DeferredUpdates.php(491): DeferredUpdates::doUpdates(string)
13:28:28 mw-dberror.log:#17 /workspace/src/maintenance/includes/Maintenance.php(695): DeferredUpdates::tryOpportunisticExecute(string)
13:28:28 mw-dberror.log:#18 /workspace/src/includes/libs/rdbms/database/Database.php(4224): Maintenance::{closure}(integer, Wikimedia\Rdbms\DatabaseSqlite)
13:28:28 mw-dberror.log:#19 /workspace/src/includes/libs/rdbms/database/Database.php(4593): Wikimedia\Rdbms\Database->runTransactionListenerCallbacks(integer)
13:28:28 mw-dberror.log:#20 /workspace/src/includes/libs/rdbms/database/Database.php(4354): Wikimedia\Rdbms\Database->commit(string, string)
13:28:28 mw-dberror.log:#21 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->endAtomic(string)
13:28:28 mw-dberror.log:#22 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(629): Wikimedia\Rdbms\DBConnRef->__call(string, array)
13:28:28 mw-dberror.log:#23 /workspace/src/includes/Storage/PageUpdater.php(1305): Wikimedia\Rdbms\DBConnRef->endAtomic(string)
13:28:28 mw-dberror.log:#24 /workspace/src/includes/Storage/PageUpdater.php(812): MediaWiki\Storage\PageUpdater->doCreate(CommentStoreComment, User, integer)
13:28:28 mw-dberror.log:#25 /workspace/src/includes/page/WikiPage.php(2024): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
13:28:28 mw-dberror.log:#26 /workspace/src/tests/parser/ParserTestRunner.php(1687): WikiPage->doEditContent(WikitextContent, CommentStoreComment, integer)
13:28:28 mw-dberror.log:#27 /workspace/src/tests/parser/ParserTestRunner.php(1627): ParserTestRunner->addArticle(string, string, string, integer)
13:28:28 mw-dberror.log:#28 /workspace/src/tests/parser/ParserTestRunner.php(776): ParserTestRunner->addArticles(array)
13:28:28 mw-dberror.log:#29 /workspace/src/tests/parser/ParserTestRunner.php(711): ParserTestRunner->runTests(array)
13:28:28 mw-dberror.log:#30 /workspace/src/tests/parser/parserTests.php(189): ParserTestRunner->runTestsFromFiles(array)
13:28:28 mw-dberror.log:#31 /workspace/src/maintenance/doMaintenance.php(107): ParserTestsMaintenance->execute()
13:28:28 mw-dberror.log:#32 /workspace/src/tests/parser/parserTests.php(200): require_once(string)
13:28:28 mw-dberror.log:#33 {main}
13:28:28 mw-dberror.log:Wed Jul 29 17:28:17 UTC 2020	5f1db4b712dd	wikidb-parsertest_	Error 1 from ChangeTags::getTags, no such table: parsertest_change_tag SELECT  ct_tag_id AS "value"  FROM parsertest_change_tag    WHERE ct_rc_id = 94 AND ct_rev_id = 96 AND ct_log_id = '103'   localhost
13:28:28 mw-dberror.log:#0 /workspace/src/includes/libs/rdbms/database/Database.php(1654): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
13:28:28 mw-dberror.log:#1 /workspace/src/includes/libs/rdbms/database/Database.php(1227): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
13:28:28 mw-dberror.log:#2 /workspace/src/includes/libs/rdbms/database/Database.php(1903): Wikimedia\Rdbms\Database->query(string, string, integer)
13:28:28 mw-dberror.log:#3 /workspace/src/includes/libs/rdbms/database/Database.php(1765): Wikimedia\Rdbms\Database->select(string, array, array, string, array, array)
13:28:28 mw-dberror.log:#4 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->selectFieldValues(string, string, array, string)
13:28:28 mw-dberror.log:#5 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(306): Wikimedia\Rdbms\DBConnRef->__call(string, array)
13:28:28 mw-dberror.log:#6 /workspace/src/includes/changetags/ChangeTags.php(499): Wikimedia\Rdbms\DBConnRef->selectFieldValues(string, string, array, string)
13:28:28 mw-dberror.log:#7 /workspace/src/includes/changetags/ChangeTags.php(382): ChangeTags::getTags(Wikimedia\Rdbms\MaintainableDBConnRef, integer, integer, string)
13:28:28 mw-dberror.log:#8 /workspace/src/includes/changetags/ChangeTags.php(275): ChangeTags::updateTags(array, array, integer, integer, string, NULL, RecentChange)
13:28:28 mw-dberror.log:#9 /workspace/src/includes/changes/RecentChange.php(400): ChangeTags::addTags(array, integer, integer, string, NULL, RecentChange)
13:28:28 mw-dberror.log:#10 /workspace/src/includes/changes/RecentChange.php(764): RecentChange->save()
13:28:28 mw-dberror.log:#11 /workspace/src/includes/deferred/MWCallableUpdate.php(38): RecentChange::{closure}()
13:28:28 mw-dberror.log:#12 /workspace/src/includes/deferred/DeferredUpdates.php(467): MWCallableUpdate->doUpdate()
13:28:28 mw-dberror.log:#13 /workspace/src/includes/deferred/DeferredUpdates.php(344): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
13:28:28 mw-dberror.log:#14 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, MediaWiki\Logger\LegacyLogger, BufferingStatsdDataFactory, string)
13:28:28 mw-dberror.log:#15 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
13:28:28 mw-dberror.log:#16 /workspace/src/includes/deferred/DeferredUpdates.php(491): DeferredUpdates::doUpdates(string)
13:28:28 mw-dberror.log:#17 /workspace/src/maintenance/includes/Maintenance.php(695): DeferredUpdates::tryOpportunisticExecute(string)
13:28:28 mw-dberror.log:#18 /workspace/src/includes/libs/rdbms/database/Database.php(4224): Maintenance::{closure}(integer, Wikimedia\Rdbms\DatabaseSqlite)
13:28:28 mw-dberror.log:#19 /workspace/src/includes/libs/rdbms/database/Database.php(4593): Wikimedia\Rdbms\Database->runTransactionListenerCallbacks(integer)
13:28:28 mw-dberror.log:#20 /workspace/src/includes/libs/rdbms/database/Database.php(4354): Wikimedia\Rdbms\Database->commit(string, string)
13:28:28 mw-dberror.log:#21 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->endAtomic(string)
13:28:28 mw-dberror.log:#22 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(629): Wikimedia\Rdbms\DBConnRef->__call(string, array)
13:28:28 mw-dberror.log:#23 /workspace/src/includes/Storage/PageUpdater.php(1305): Wikimedia\Rdbms\DBConnRef->endAtomic(string)
13:28:28 mw-dberror.log:#24 /workspace/src/includes/Storage/PageUpdater.php(812): MediaWiki\Storage\PageUpdater->doCreate(CommentStoreComment, User, integer)
13:28:28 mw-dberror.log:#25 /workspace/src/includes/page/WikiPage.php(2024): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
13:28:28 mw-dberror.log:#26 /workspace/src/tests/parser/ParserTestRunner.php(1687): WikiPage->doEditContent(WikitextContent, CommentStoreComment, integer)
13:28:28 mw-dberror.log:#27 /workspace/src/tests/parser/ParserTestRunner.php(1627): ParserTestRunner->addArticle(string, string, string, integer)
13:28:28 mw-dberror.log:#28 /workspace/src/tests/parser/ParserTestRunner.php(776): ParserTestRunner->addArticles(array)
13:28:28 mw-dberror.log:#29 /workspace/src/tests/parser/ParserTestRunner.php(711): ParserTestRunner->runTests(array)
13:28:28 mw-dberror.log:#30 /workspace/src/tests/parser/parserTests.php(189): ParserTestRunner->runTestsFromFiles(array)
13:28:28 mw-dberror.log:#31 /workspace/src/maintenance/doMaintenance.php(107): ParserTestsMaintenance->execute()
13:28:28 mw-dberror.log:#32 /workspace/src/tests/parser/parserTests.php(200): require_once(string)
13:28:28 mw-dberror.log:#33 {main}
13:28:28 mw-error.log:2020-07-29 17:28:16 5f1db4b712dd wikidb-parsertest_: [7cfdd6aa571ef959bc0ad8f2] [no req]   Wikimedia\Rdbms\DBQueryError from line 1695 of /workspace/src/includes/libs/rdbms/database/Database.php: Error 1: no such table: parsertest_change_tag
13:28:28 mw-error.log:Function: ChangeTags::getTags
13:28:28 mw-error.log:Query: SELECT  ct_tag_id AS "value"  FROM parsertest_change_tag    WHERE ct_rc_id = 12 AND ct_rev_id = 12 AND ct_log_id = '19'  
13:28:28 mw-error.log:#0 /workspace/src/includes/libs/rdbms/database/Database.php(1679): Wikimedia\Rdbms\Database->getQueryException(string, integer, string, string)
13:28:28 mw-error.log:#1 /workspace/src/includes/libs/rdbms/database/Database.php(1654): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
13:28:28 mw-error.log:#2 /workspace/src/includes/libs/rdbms/database/Database.php(1227): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
13:28:28 mw-error.log:#3 /workspace/src/includes/libs/rdbms/database/Database.php(1903): Wikimedia\Rdbms\Database->query(string, string, integer)
13:28:28 mw-error.log:#4 /workspace/src/includes/libs/rdbms/database/Database.php(1765): Wikimedia\Rdbms\Database->select(string, array, array, string, array, array)
13:28:28 mw-error.log:#5 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->selectFieldValues(string, string, array, string)
13:28:28 mw-error.log:#6 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(306): Wikimedia\Rdbms\DBConnRef->__call(string, array)
13:28:28 mw-error.log:#7 /workspace/src/includes/changetags/ChangeTags.php(499): Wikimedia\Rdbms\DBConnRef->selectFieldValues(string, string, array, string)
13:28:28 mw-error.log:#8 /workspace/src/includes/changetags/ChangeTags.php(382): ChangeTags::getTags(Wikimedia\Rdbms\MaintainableDBConnRef, integer, integer, string)
13:28:28 mw-error.log:#9 /workspace/src/includes/changetags/ChangeTags.php(275): ChangeTags::updateTags(array, array, integer, integer, string, NULL, RecentChange)
13:28:28 mw-error.log:#10 /workspace/src/includes/changes/RecentChange.php(400): ChangeTags::addTags(array, integer, integer, string, NULL, RecentChange)
13:28:28 mw-error.log:#11 /workspace/src/includes/changes/RecentChange.php(764): RecentChange->save()
13:28:28 mw-error.log:#12 /workspace/src/includes/deferred/MWCallableUpdate.php(38): RecentChange::{closure}()
13:28:28 mw-error.log:#13 /workspace/src/includes/deferred/DeferredUpdates.php(467): MWCallableUpdate->doUpdate()
13:28:28 mw-error.log:#14 /workspace/src/includes/deferred/DeferredUpdates.php(344): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
13:28:28 mw-error.log:#15 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, MediaWiki\Logger\LegacyLogger, BufferingStatsdDataFactory, string)
13:28:28 mw-error.log:#16 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
13:28:28 mw-error.log:#17 /workspace/src/includes/deferred/DeferredUpdates.php(491): DeferredUpdates::doUpdates(string)
13:28:28 mw-error.log:#18 /workspace/src/maintenance/includes/Maintenance.php(695): DeferredUpdates::tryOpportunisticExecute(string)
13:28:28 mw-error.log:#19 /workspace/src/includes/libs/rdbms/database/Database.php(4224): Maintenance::{closure}(integer, Wikimedia\Rdbms\DatabaseSqlite)
13:28:28 mw-error.log:#20 /workspace/src/includes/libs/rdbms/database/Database.php(4593): Wikimedia\Rdbms\Database->runTransactionListenerCallbacks(integer)
13:28:28 mw-error.log:#21 /workspace/src/includes/libs/rdbms/database/Database.php(4354): Wikimedia\Rdbms\Database->commit(string, string)
13:28:28 mw-error.log:#22 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->endAtomic(string)
13:28:28 mw-error.log:#23 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(629): Wikimedia\Rdbms\DBConnRef->__call(string, array)
13:28:28 mw-error.log:#24 /workspace/src/includes/Storage/PageUpdater.php(1305): Wikimedia\Rdbms\DBConnRef->endAtomic(string)
13:28:28 mw-error.log:#25 /workspace/src/includes/Storage/PageUpdater.php(812): MediaWiki\Storage\PageUpdater->doCreate(CommentStoreComment, User, integer)
13:28:28 mw-error.log:#26 /workspace/src/includes/page/WikiPage.php(2024): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
13:28:28 mw-error.log:#27 /workspace/src/tests/parser/ParserTestRunner.php(1687): WikiPage->doEditContent(WikitextContent, CommentStoreComment, integer)
13:28:28 mw-error.log:#28 /workspace/src/tests/parser/ParserTestRunner.php(1627): ParserTestRunner->addArticle(string, string, string, integer)
13:28:28 mw-error.log:#29 /workspace/src/tests/parser/ParserTestRunner.php(776): ParserTestRunner->addArticles(array)
13:28:28 mw-error.log:#30 /workspace/src/tests/parser/ParserTestRunner.php(711): ParserTestRunner->runTests(array)
13:28:28 mw-error.log:#31 /workspace/src/tests/parser/parserTests.php(189): ParserTestRunner->runTestsFromFiles(array)
13:28:28 mw-error.log:#32 /workspace/src/maintenance/doMaintenance.php(107): ParserTestsMaintenance->execute()
13:28:28 mw-error.log:#33 /workspace/src/tests/parser/parserTests.php(200): require_once(string)
13:28:28 mw-error.log:#34 {main}
13:28:28 mw-error.log:2020-07-29 17:28:17 5f1db4b712dd wikidb-parsertest_: [7cfdd6aa571ef959bc0ad8f2] [no req]   Wikimedia\Rdbms\DBQueryError from line 1695 of /workspace/src/includes/libs/rdbms/database/Database.php: Error 1: no such table: parsertest_change_tag
13:28:28 mw-error.log:Function: ChangeTags::getTags
13:28:28 mw-error.log:Query: SELECT  ct_tag_id AS "value"  FROM parsertest_change_tag    WHERE ct_rc_id = 65 AND ct_rev_id = 66 AND ct_log_id = '73'  
13:28:28 mw-error.log:#0 /workspace/src/includes/libs/rdbms/database/Database.php(1679): Wikimedia\Rdbms\Database->getQueryException(string, integer, string, string)
13:28:28 mw-error.log:#1 /workspace/src/includes/libs/rdbms/database/Database.php(1654): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
13:28:28 mw-error.log:#2 /workspace/src/includes/libs/rdbms/database/Database.php(1227): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
13:28:28 mw-error.log:#3 /workspace/src/includes/libs/rdbms/database/Database.php(1903): Wikimedia\Rdbms\Database->query(string, string, integer)
13:28:28 mw-error.log:#4 /workspace/src/includes/libs/rdbms/database/Database.php(1765): Wikimedia\Rdbms\Database->select(string, array, array, string, array, array)
13:28:28 mw-error.log:#5 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->selectFieldValues(string, string, array, string)
13:28:28 mw-error.log:#6 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(306): Wikimedia\Rdbms\DBConnRef->__call(string, array)
13:28:28 mw-error.log:#7 /workspace/src/includes/changetags/ChangeTags.php(499): Wikimedia\Rdbms\DBConnRef->selectFieldValues(string, string, array, string)
13:28:28 mw-error.log:#8 /workspace/src/includes/changetags/ChangeTags.php(382): ChangeTags::getTags(Wikimedia\Rdbms\MaintainableDBConnRef, integer, integer, string)
13:28:28 mw-error.log:#9 /workspace/src/includes/changetags/ChangeTags.php(275): ChangeTags::updateTags(array, array, integer, integer, string, NULL, RecentChange)
13:28:28 mw-error.log:#10 /workspace/src/includes/changes/RecentChange.php(400): ChangeTags::addTags(array, integer, integer, string, NULL, RecentChange)
13:28:28 mw-error.log:#11 /workspace/src/includes/changes/RecentChange.php(764): RecentChange->save()
13:28:28 mw-error.log:#12 /workspace/src/includes/deferred/MWCallableUpdate.php(38): RecentChange::{closure}()
13:28:28 mw-error.log:#13 /workspace/src/includes/deferred/DeferredUpdates.php(467): MWCallableUpdate->doUpdate()
13:28:28 mw-error.log:#14 /workspace/src/includes/deferred/DeferredUpdates.php(344): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
13:28:28 mw-error.log:#15 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, MediaWiki\Logger\LegacyLogger, BufferingStatsdDataFactory, string)
13:28:28 mw-error.log:#16 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
13:28:28 mw-error.log:#17 /workspace/src/includes/deferred/DeferredUpdates.php(491): DeferredUpdates::doUpdates(string)
13:28:28 mw-error.log:#18 /workspace/src/maintenance/includes/Maintenance.php(695): DeferredUpdates::tryOpportunisticExecute(string)
13:28:28 mw-error.log:#19 /workspace/src/includes/libs/rdbms/database/Database.php(4224): Maintenance::{closure}(integer, Wikimedia\Rdbms\DatabaseSqlite)
13:28:28 mw-error.log:#20 /workspace/src/includes/libs/rdbms/database/Database.php(4593): Wikimedia\Rdbms\Database->runTransactionListenerCallbacks(integer)
13:28:28 mw-error.log:#21 /workspace/src/includes/libs/rdbms/database/Database.php(4354): Wikimedia\Rdbms\Database->commit(string, string)
13:28:28 mw-error.log:#22 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->endAtomic(string)
13:28:28 mw-error.log:#23 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(629): Wikimedia\Rdbms\DBConnRef->__call(string, array)
13:28:28 mw-error.log:#24 /workspace/src/includes/Storage/PageUpdater.php(1305): Wikimedia\Rdbms\DBConnRef->endAtomic(string)
13:28:28 mw-error.log:#25 /workspace/src/includes/Storage/PageUpdater.php(812): MediaWiki\Storage\PageUpdater->doCreate(CommentStoreComment, User, integer)
13:28:28 mw-error.log:#26 /workspace/src/includes/page/WikiPage.php(2024): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
13:28:28 mw-error.log:#27 /workspace/src/tests/parser/ParserTestRunner.php(1687): WikiPage->doEditContent(WikitextContent, CommentStoreComment, integer)
13:28:28 mw-error.log:#28 /workspace/src/tests/parser/ParserTestRunner.php(1627): ParserTestRunner->addArticle(string, string, string, integer)
13:28:28 mw-error.log:#29 /workspace/src/tests/parser/ParserTestRunner.php(776): ParserTestRunner->addArticles(array)
13:28:28 mw-error.log:#30 /workspace/src/tests/parser/ParserTestRunner.php(711): ParserTestRunner->runTests(array)
13:28:28 mw-error.log:#31 /workspace/src/tests/parser/parserTests.php(189): ParserTestRunner->runTestsFromFiles(array)
13:28:28 mw-error.log:#32 /workspace/src/maintenance/doMaintenance.php(107): ParserTestsMaintenance->execute()
13:28:28 mw-error.log:#33 /workspace/src/tests/parser/parserTests.php(200): require_once(string)
13:28:28 mw-error.log:#34 {main}
13:28:28 mw-error.log:2020-07-29 17:28:17 5f1db4b712dd wikidb-parsertest_: [7cfdd6aa571ef959bc0ad8f2] [no req]   Wikimedia\Rdbms\DBQueryError from line 1695 of /workspace/src/includes/libs/rdbms/database/Database.php: Error 1: no such table: parsertest_change_tag
13:28:28 mw-error.log:Function: ChangeTags::getTags
13:28:28 mw-error.log:Query: SELECT  ct_tag_id AS "value"  FROM parsertest_change_tag    WHERE ct_rc_id = 94 AND ct_rev_id = 96 AND ct_log_id = '103'  
13:28:28 mw-error.log:#0 /workspace/src/includes/libs/rdbms/database/Database.php(1679): Wikimedia\Rdbms\Database->getQueryException(string, integer, string, string)
13:28:28 mw-error.log:#1 /workspace/src/includes/libs/rdbms/database/Database.php(1654): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
13:28:28 mw-error.log:#2 /workspace/src/includes/libs/rdbms/database/Database.php(1227): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
13:28:28 mw-error.log:#3 /workspace/src/includes/libs/rdbms/database/Database.php(1903): Wikimedia\Rdbms\Database->query(string, string, integer)
13:28:28 mw-error.log:#4 /workspace/src/includes/libs/rdbms/database/Database.php(1765): Wikimedia\Rdbms\Database->select(string, array, array, string, array, array)
13:28:28 mw-error.log:#5 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->selectFieldValues(string, string, array, string)
13:28:28 mw-error.log:#6 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(306): Wikimedia\Rdbms\DBConnRef->__call(string, array)
13:28:28 mw-error.log:#7 /workspace/src/includes/changetags/ChangeTags.php(499): Wikimedia\Rdbms\DBConnRef->selectFieldValues(string, string, array, string)
13:28:28 mw-error.log:#8 /workspace/src/includes/changetags/ChangeTags.php(382): ChangeTags::getTags(Wikimedia\Rdbms\MaintainableDBConnRef, integer, integer, string)
13:28:28 mw-error.log:#9 /workspace/src/includes/changetags/ChangeTags.php(275): ChangeTags::updateTags(array, array, integer, integer, string, NULL, RecentChange)
13:28:28 mw-error.log:#10 /workspace/src/includes/changes/RecentChange.php(400): ChangeTags::addTags(array, integer, integer, string, NULL, RecentChange)
13:28:28 mw-error.log:#11 /workspace/src/includes/changes/RecentChange.php(764): RecentChange->save()
13:28:28 mw-error.log:#12 /workspace/src/includes/deferred/MWCallableUpdate.php(38): RecentChange::{closure}()
13:28:28 mw-error.log:#13 /workspace/src/includes/deferred/DeferredUpdates.php(467): MWCallableUpdate->doUpdate()
13:28:28 mw-error.log:#14 /workspace/src/includes/deferred/DeferredUpdates.php(344): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
13:28:28 mw-error.log:#15 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, MediaWiki\Logger\LegacyLogger, BufferingStatsdDataFactory, string)
13:28:28 mw-error.log:#16 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
13:28:28 mw-error.log:#17 /workspace/src/includes/deferred/DeferredUpdates.php(491): DeferredUpdates::doUpdates(string)
13:28:28 mw-error.log:#18 /workspace/src/maintenance/includes/Maintenance.php(695): DeferredUpdates::tryOpportunisticExecute(string)
13:28:28 mw-error.log:#19 /workspace/src/includes/libs/rdbms/database/Database.php(4224): Maintenance::{closure}(integer, Wikimedia\Rdbms\DatabaseSqlite)
13:28:28 mw-error.log:#20 /workspace/src/includes/libs/rdbms/database/Database.php(4593): Wikimedia\Rdbms\Database->runTransactionListenerCallbacks(integer)
13:28:28 mw-error.log:#21 /workspace/src/includes/libs/rdbms/database/Database.php(4354): Wikimedia\Rdbms\Database->commit(string, string)
13:28:28 mw-error.log:#22 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->endAtomic(string)
13:28:28 mw-error.log:#23 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(629): Wikimedia\Rdbms\DBConnRef->__call(string, array)
13:28:28 mw-error.log:#24 /workspace/src/includes/Storage/PageUpdater.php(1305): Wikimedia\Rdbms\DBConnRef->endAtomic(string)
13:28:28 mw-error.log:#25 /workspace/src/includes/Storage/PageUpdater.php(812): MediaWiki\Storage\PageUpdater->doCreate(CommentStoreComment, User, integer)
13:28:28 mw-error.log:#26 /workspace/src/includes/page/WikiPage.php(2024): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
13:28:28 mw-error.log:#27 /workspace/src/tests/parser/ParserTestRunner.php(1687): WikiPage->doEditContent(WikitextContent, CommentStoreComment, integer)
13:28:28 mw-error.log:#28 /workspace/src/tests/parser/ParserTestRunner.php(1627): ParserTestRunner->addArticle(string, string, string, integer)
13:28:28 mw-error.log:#29 /workspace/src/tests/parser/ParserTestRunner.php(776): ParserTestRunner->addArticles(array)
13:28:28 mw-error.log:#30 /workspace/src/tests/parser/ParserTestRunner.php(711): ParserTestRunner->runTests(array)
13:28:28 mw-error.log:#31 /workspace/src/tests/parser/parserTests.php(189): ParserTestRunner->runTestsFromFiles(array)
13:28:28 mw-error.log:#32 /workspace/src/maintenance/doMaintenance.php(107): ParserTestsMaintenance->execute()
13:28:28 mw-error.log:#33 /workspace/src/tests/parser/parserTests.php(200): require_once(string)
13:28:28 mw-error.log:#34 {main}

Details

SubjectRepoBranchLines +/-
Fix parserTests.php by ensuring change_tag tables are clonedmediawiki/coremaster+1 -0
DNP: no-op change to test CImediawiki/services/parsoidmaster+1 -1
DNP: no-op change to test CImediawiki/services/parsoidmaster+1 -1
DNP: test to see if/where ChangeTags::addTag() is triggered in phpunit CImediawiki/coremaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

cscott created this task.Jul 29 2020, 7:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2020, 7:11 PM
cscott added a comment.EditedJul 29 2020, 7:14 PM

This is likely some code added which caused a regression in the parserTests.php CLI script, but not the phpunit version of the parserTest runner, which is ever-so-slightly different. The CI for mediawiki-core only tests the phpunit runner, not the CLI runner, and this is not the first time we've had to chase down regressions.

https://gerrit.wikimedia.org/r/c/integration/quibble/+/612937 (part of T227352) is a patch that (among other things) will allow us to run Parsoid's tests via the phpunit runner. That would make this not a blocker bug for us, but wouldn't address future code rot in the parserTests.php runner.

cscott mentioned this in T259123: mediawiki/core REL1_34 CI failure due to DB/PHP errors.Jul 29 2020, 7:17 PM
Krinkle updated the task description. (Show Details)Jul 29 2020, 7:22 PM
cscott mentioned this in T246358: Jenkins no longer fails build if mw-error.log or mw-dberror.log are non-empty.Jul 29 2020, 7:28 PM
Krinkle subscribed.EditedJul 29 2020, 7:42 PM

Most the things we encountered in core as part of T246358 were PHP warnings that bypassed PHPUnit's warning-to-exception mapper (e.g. emittedd too early or too late, or override it in some way), or database warnings that turn into exceptions but that were intentionally triggered to test the failure scenario (but did not declare an "expected" fatal error log message).

What you have here however is a hard DB error:

mw-dberror.log:Wed Jul 29 17:28:16 UTC 2020	5f1db4b712dd	wikidb-parsertest_	Error 1 from ChangeTags::getTags, no such table: parsertest_change_tag SELECT  ct_tag_id AS "value"  FROM parsertest_change_tag    WHERE ct_rc_id = 12 AND ct_rev_id = 12 AND ct_log_id = '19'   localhost

… which turns into a fatal exception:

2020-07-29 17:28:17 5f1db4b712dd wikidb-parsertest_: [7cfdd6aa571ef959bc0ad8f2] [no req]   Wikimedia\Rdbms\DBQueryError from line 1695 of /workspace/src/includes/libs/rdbms/database/Database.php: Error 1: no such table: parsertest_change_tag
Function: ChangeTags::getTags
Query: SELECT  ct_tag_id AS "value"  FROM parsertest_change_tag    WHERE ct_rc_id = 94 AND ct_rev_id = 96 AND ct_log_id = '103'  

#0 /workspace/src/includes/libs/rdbms/database/Database.php(1679): Wikimedia\Rdbms\Database->getQueryException(string, integer, string, string)
#1 /workspace/src/includes/libs/rdbms/database/Database.php(1654): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#2 /workspace/src/includes/libs/rdbms/database/Database.php(1227): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#3 /workspace/src/includes/libs/rdbms/database/Database.php(1903): Wikimedia\Rdbms\Database->query(string, string, integer)
#4 /workspace/src/includes/libs/rdbms/database/Database.php(1765): Wikimedia\Rdbms\Database->select(string, array, array, string, array, array)
#5 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->selectFieldValues(string, string, array, string)
#6 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(306): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#7 /workspace/src/includes/changetags/ChangeTags.php(499): Wikimedia\Rdbms\DBConnRef->selectFieldValues(string, string, array, string)
#8 /workspace/src/includes/changetags/ChangeTags.php(382): ChangeTags::getTags(Wikimedia\Rdbms\MaintainableDBConnRef, integer, integer, string)
#9 /workspace/src/includes/changetags/ChangeTags.php(275): ChangeTags::updateTags(array, array, integer, integer, string, NULL, RecentChange)
#10 /workspace/src/includes/changes/RecentChange.php(400): ChangeTags::addTags(array, integer, integer, string, NULL, RecentChange)
#11 /workspace/src/includes/changes/RecentChange.php(764): RecentChange->save()
#12 /workspace/src/includes/deferred/MWCallableUpdate.php(38): RecentChange::{closure}()
#13 /workspace/src/includes/deferred/DeferredUpdates.php(467): MWCallableUpdate->doUpdate()
#14 /workspace/src/includes/deferred/DeferredUpdates.php(344): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
#15 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, MediaWiki\Logger\LegacyLogger, BufferingStatsdDataFactory, string)
#16 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
#17 /workspace/src/includes/deferred/DeferredUpdates.php(491): DeferredUpdates::doUpdates(string)
#18 /workspace/src/maintenance/includes/Maintenance.php(695): DeferredUpdates::tryOpportunisticExecute(string)
#19 /workspace/src/includes/libs/rdbms/database/Database.php(4224): Maintenance::{closure}(integer, Wikimedia\Rdbms\DatabaseSqlite)
#20 /workspace/src/includes/libs/rdbms/database/Database.php(4593): Wikimedia\Rdbms\Database->runTransactionListenerCallbacks(integer)
#21 /workspace/src/includes/libs/rdbms/database/Database.php(4354): Wikimedia\Rdbms\Database->commit(string, string)
#22 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->endAtomic(string)
#23 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(629): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#24 /workspace/src/includes/Storage/PageUpdater.php(1305): Wikimedia\Rdbms\DBConnRef->endAtomic(string)
#25 /workspace/src/includes/Storage/PageUpdater.php(812): MediaWiki\Storage\PageUpdater->doCreate(CommentStoreComment, User, integer)
#26 /workspace/src/includes/page/WikiPage.php(2024): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
#27 /workspace/src/tests/parser/ParserTestRunner.php(1687): WikiPage->doEditContent(WikitextContent, CommentStoreComment, integer)
#28 /workspace/src/tests/parser/ParserTestRunner.php(1627): ParserTestRunner->addArticle(string, string, string, integer)
#29 /workspace/src/tests/parser/ParserTestRunner.php(776): ParserTestRunner->addArticles(array)
#30 /workspace/src/tests/parser/ParserTestRunner.php(711): ParserTestRunner->runTests(array)
#31 /workspace/src/tests/parser/parserTests.php(189): ParserTestRunner->runTestsFromFiles(array)
#32 /workspace/src/maintenance/doMaintenance.php(107): ParserTestsMaintenance->execute()
#33 /workspace/src/tests/parser/parserTests.php(200): require_once(string)
#34 {main}

With RecentChange->save() getting called and throwing an exception, I don't see how this passed before when the change_tag table isn't created at all.

In any event, the usual applies for CI errors:

  • If this is expected and intentional as part of a failure-mode test, then make sure it is caught/nulled/expected accordingly.
  • If this is expected in the source code and recovered from, then make sure it silences the db error (not the case here, since it's a db error which turns into an exception, these can't be intentional/silenced in source code).
  • If this is unexpected but insignificant to the test:
    • … try to skip, disable, or mock this step.
    • … try to make it work.
    • … silence it by catching the exception or nulling/un-nulling the error channel around this step.
gerritbot added a comment.Jul 29 2020, 7:44 PM

Change 617252 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: T259186

https://gerrit.wikimedia.org/r/617252

gerritbot added a project: Patch-For-Review.Jul 29 2020, 7:44 PM

Change 617253 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] DNP: no-op change to test CI

https://gerrit.wikimedia.org/r/617253

cscott added a comment.Jul 29 2020, 7:47 PM

https://gerrit.wikimedia.org/r/617252 has a WIP patch which ensures the 'change_tag' table is created in the ParserTestRunner. The question I can't figure out though is -- how does this manage to work in core when parser tests are run via phpunit? It should be failing the same way, I'd think. As you pointed out, it can't be the case that this is just being silenced by phpunit...

cscott added a comment.Jul 29 2020, 7:58 PM

Best guess at this point is that this is a regression caused by 435d5f4d55d3d88880c44978e7aeabe740ad5635, which mapped EditResult::REVERT_MANUAL (which must be triggered by something in the parser test framework when it is setting up the mock article db) to a change tag, and thus triggered ChangeTags::addTags() (from RecentChange::save() when count($this->tags) is non-zero) where it wasn't being triggered before.

gerritbot added a comment.Jul 29 2020, 7:59 PM

Change 617256 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] DNP: test to see if/where ChangeTags::addTag() is triggered in phpunit CI

https://gerrit.wikimedia.org/r/617256

gerritbot added a comment.Jul 29 2020, 8:09 PM

Change 617252 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Fix parserTests.php by ensuring change_tag tables are cloned

https://gerrit.wikimedia.org/r/617252

cscott added a comment.Jul 29 2020, 8:10 PM

Ok, patch works: https://gerrit.wikimedia.org/r/617252 -- still don't know why this isn't making the phpunit tests fail, but I'm working on that...

gerritbot added a comment.Jul 29 2020, 8:15 PM

Change 617256 abandoned by C. Scott Ananian:
[mediawiki/core@master] DNP: test to see if/where ChangeTags::addTag() is triggered in phpunit CI

Reason:
Served its purpose. Short answer is that addTag is not being triggered by the phpunit version of ParserTestRunner; the only CI failures in core's phpunit tests with this throw error is a single test case, ArticleViewTest::testViewRedirect. All of the parsertests completed successfully.

https://gerrit.wikimedia.org/r/617256

gerritbot added a comment.Jul 29 2020, 8:21 PM

Change 617259 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] DNP: no-op change to test CI

https://gerrit.wikimedia.org/r/617259

gerritbot added a comment.Jul 29 2020, 8:32 PM

Change 617253 abandoned by C. Scott Ananian:
[mediawiki/services/parsoid@master] DNP: no-op change to test CI

Reason:
Served its purpose!

https://gerrit.wikimedia.org/r/617253

cscott added a comment.Jul 29 2020, 8:59 PM

Ah -- the culprit is ParserTestRunner::setupDatabase, whose phpdoc comment says, "This is basically an unrefactored copy of MediaWikiIntegrationTestCase::setupAllTestDBs. They should be factored out somehow."

When run via phpunit, we use MediaWikiIntegrationTestCase::setupAllTestDBs, which calls MediaWikiIntegrationTestCase::listOriginalTables() to dynamically query the current DB for all its tables, so it can clone them all.

When run via bin/parserTests.php, we use ParserTestRunner::setupDatabase which calls ParserTests::listTables(), which has a hard-coded list of tables to use.

So that's why it works in phpunit, but not in bin/parserTests.php. As the comment says, we should really refactor ParserTestRunner to (re)use the code from MediaWikiIntegrationTestCase instead, which would help keep the two test modes from diverging.

gerritbot added a comment.Jul 29 2020, 9:01 PM

Change 617259 abandoned by C. Scott Ananian:
[mediawiki/services/parsoid@master] DNP: no-op change to test CI

Reason:
I figured it out. Story in https://phabricator.wikimedia.org/T259186#6346786

https://gerrit.wikimedia.org/r/617259

gerritbot added a comment.Jul 29 2020, 9:15 PM

Change 617252 merged by jenkins-bot:
[mediawiki/core@master] Fix parserTests.php by ensuring change_tag tables are cloned

https://gerrit.wikimedia.org/r/617252

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 29 2020, 10:00 PM
cscott closed this task as Resolved.Jul 30 2020, 5:06 AM
cscott claimed this task.
Krinkle awarded a token.Jul 30 2020, 9:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits