Page MenuHomePhabricator

Set up extension tests for Parsoid repo
Open, HighPublic

Description

In T224979: Parsoid REST Routes Extension, we have turned the Parsoid library repo into a makeshift extension, to use for testing core integration until the codebase stabilizes and can be moved into core (or maybe a proper extension). We'll need to set up extension tests for that.

Event Timeline

hashar added a subscriber: hashar.

Should be straight forward. It is usually all about adding an entry in integration/config.git in zuul/layout.yaml

We should update our developer docs as well to reflect best practices to installing Parsoid & running PHP tests. Should Parsoid be installed inside core/extensions/Parsoid and/or is setting $MW_INSTALL_PATH sufficient? Ideally composer extension-test or something would Do The Right Thing assuming proper set up (whether that's installing Parsoid inside the extension folder or setting MW_INSTALL_PATH or whatever else the Right Thing needs to be).

Arlolra triaged this task as High priority.Dec 4 2019, 9:47 PM
Arlolra added a subscriber: Arlolra.

Since Parsoid/PHP is in production, a train rollout without proper integration testing could have dire effects.

Change 612430 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[integration/config@master] Turn on standard quibble tests for Parsoid as an extension

https://gerrit.wikimedia.org/r/612430

Change 612430 merged by jenkins-bot:
[integration/config@master] Turn on standard quibble tests for Parsoid as an extension

https://gerrit.wikimedia.org/r/612430

Change 612937 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[integration/quibble@master] Load Parsoid as an extension when it is cloned into services/parsoid

https://gerrit.wikimedia.org/r/612937

Change 612937 merged by jenkins-bot:
[integration/quibble@master] Load Parsoid as an extension when it is cloned into services/parsoid

https://gerrit.wikimedia.org/r/612937

Ok, just waiting for another release of quibble to the CI infra. Watching https://github.com/wikimedia/quibble/commits/master ...

Change 628138 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/quibble@master] Release Quibble 0.0.45

https://gerrit.wikimedia.org/r/628138

Change 628138 merged by jenkins-bot:
[integration/quibble@master] Release Quibble 0.0.45

https://gerrit.wikimedia.org/r/628138

Change 701346 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] Add parsoid dependency to VisualEditor

https://gerrit.wikimedia.org/r/701346

Change 703182 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/quibble@master] Load Parsoid from vendor as fallback, and configure

https://gerrit.wikimedia.org/r/703182

Change 703182 merged by jenkins-bot:

[integration/quibble@master] Load Parsoid from vendor as fallback, and configure

https://gerrit.wikimedia.org/r/703182

Change 704936 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/quibble@master] Release Quibble 1.0.0

https://gerrit.wikimedia.org/r/704936

Change 704936 merged by jenkins-bot:

[integration/quibble@master] Release Quibble 1.0.0

https://gerrit.wikimedia.org/r/704936

Change 705907 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[integration/quibble@master] Revert "Load Parsoid from vendor as fallback, and configure"

https://gerrit.wikimedia.org/r/705907

Change 705907 merged by jenkins-bot:

[integration/quibble@master] Revert \"Load Parsoid from vendor as fallback, and configure\"

https://gerrit.wikimedia.org/r/705907

Change 701346 abandoned by Hashar:

[integration/config@master] Add parsoid dependency to VisualEditor

Reason:

I am pretty sure this is obsolete nowadays. The last injections of parsoid got removed in July 2022 https://gerrit.wikimedia.org/r/c/integration/config/+/803990 .

https://gerrit.wikimedia.org/r/701346