Page MenuHomePhabricator
Create Task
Maniphest T227352

Set up extension tests for Parsoid repo
Open, HighPublic
Actions

Description

In T224979: Parsoid REST Routes Extension, we have turned the Parsoid library repo into a makeshift extension, to use for testing core integration until the codebase stabilizes and can be moved into core (or maybe a proper extension). We'll need to set up extension tests for that.

Details

SubjectRepoBranchLines +/-
Add parsoid dependency to VisualEditorintegration/configmaster+5 -3
Revert "Load Parsoid from vendor as fallback, and configure"integration/quibblemaster+7 -17
Load Parsoid from vendor as fallback, and configureintegration/quibblemaster+17 -7
Release Quibble 1.0.0integration/quibblemaster+41 -3
Release Quibble 0.0.45integration/quibblemaster+54 -2
Load Parsoid as an extension when it is cloned into services/parsoidintegration/quibblemaster+12 -0
Turn on standard quibble tests for Parsoid as an extensionintegration/configmaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tgr created this task.Jul 5 2019, 5:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 5 2019, 5:24 PM
Tgr mentioned this in T224979: Parsoid REST Routes Extension.Jul 5 2019, 5:25 PM
hashar moved this task from Backlog to Repo setup on the Continuous-Integration-Config board.Jul 8 2019, 12:48 PM
hashar subscribed.

Should be straight forward. It is usually all about adding an entry in integration/config.git in zuul/layout.yaml

cscott subscribed.Jul 8 2019, 3:33 PM

We should update our developer docs as well to reflect best practices to installing Parsoid & running PHP tests. Should Parsoid be installed inside core/extensions/Parsoid and/or is setting $MW_INSTALL_PATH sufficient? Ideally composer extension-test or something would Do The Right Thing assuming proper set up (whether that's installing Parsoid inside the extension folder or setting MW_INSTALL_PATH or whatever else the Right Thing needs to be).

ssastry moved this task from Backlog to Deployment on the Parsoid-PHP board.Jul 26 2019, 12:50 AM
ssastry moved this task from Deployment to Testing / QA on the Parsoid-PHP board.Jul 30 2019, 4:56 PM
Arlolra mentioned this in T233736: Testing the REST API in CI.Oct 11 2019, 11:31 PM
Arlolra triaged this task as High priority.Dec 4 2019, 9:47 PM
Arlolra subscribed.

Since Parsoid/PHP is in production, a train rollout without proper integration testing could have dire effects.

cscott added a parent task: T248694: Improve testing of Parsoid/PHP (1.36).Mar 27 2020, 4:11 PM
Aklapper edited projects, added Parsoid; removed Parsoid-PHP.Apr 10 2020, 4:27 PM
ssastry moved this task from Needs Triage to Testing on the Parsoid board.Apr 10 2020, 4:59 PM
cscott added a subtask: T248726: Run phan on code in extension/.May 1 2020, 11:30 PM
gerritbot added a comment.Jul 13 2020, 10:22 PM

Change 612430 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[integration/config@master] Turn on standard quibble tests for Parsoid as an extension

https://gerrit.wikimedia.org/r/612430

gerritbot added a project: Patch-For-Review.Jul 13 2020, 10:22 PM
gerritbot added a comment.Jul 14 2020, 7:55 PM

Change 612430 merged by jenkins-bot:
[integration/config@master] Turn on standard quibble tests for Parsoid as an extension

https://gerrit.wikimedia.org/r/612430

Maintenance_bot removed a project: Patch-For-Review.Jul 14 2020, 8:11 PM
gerritbot added a comment.Jul 15 2020, 7:46 PM

Change 612937 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[integration/quibble@master] Load Parsoid as an extension when it is cloned into services/parsoid

https://gerrit.wikimedia.org/r/612937

gerritbot added a project: Patch-For-Review.Jul 15 2020, 7:46 PM
cscott mentioned this in T259186: Parsoid CI is failing when parser tests are run.Jul 29 2020, 7:16 PM
cscott closed subtask T248726: Run phan on code in extension/ as Resolved.Aug 4 2020, 5:00 AM
gerritbot added a comment.Aug 4 2020, 2:05 PM

Change 612937 merged by jenkins-bot:
[integration/quibble@master] Load Parsoid as an extension when it is cloned into services/parsoid

https://gerrit.wikimedia.org/r/612937

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2020, 2:10 PM
cscott added a comment.Aug 13 2020, 3:28 AM

Ok, just waiting for another release of quibble to the CI infra. Watching https://github.com/wikimedia/quibble/commits/master ...

Jdforrester-WMF subscribed.Aug 26 2020, 4:24 PM
gerritbot added a comment.Sep 17 2020, 4:37 PM

Change 628138 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/quibble@master] Release Quibble 0.0.45

https://gerrit.wikimedia.org/r/628138

gerritbot added a project: Patch-For-Review.Sep 17 2020, 4:37 PM
gerritbot added a comment.Sep 18 2020, 1:28 PM

Change 628138 merged by jenkins-bot:
[integration/quibble@master] Release Quibble 0.0.45

https://gerrit.wikimedia.org/r/628138

gerritbot added a comment.Jun 24 2021, 9:21 AM

Change 701346 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] Add parsoid dependency to VisualEditor

https://gerrit.wikimedia.org/r/701346

gerritbot added a comment.Jul 8 2021, 7:57 AM

Change 703182 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/quibble@master] Load Parsoid from vendor as fallback, and configure

https://gerrit.wikimedia.org/r/703182

kostajh added a parent task: T285649: Switch all Quibble Selenium and api-testing jobs to use apache.Jul 8 2021, 8:46 AM
gerritbot added a comment.Jul 16 2021, 8:29 AM

Change 703182 merged by jenkins-bot:

[integration/quibble@master] Load Parsoid from vendor as fallback, and configure

https://gerrit.wikimedia.org/r/703182

gerritbot added a comment.Jul 16 2021, 10:27 AM

Change 704936 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/quibble@master] Release Quibble 1.0.0

https://gerrit.wikimedia.org/r/704936

gerritbot added a comment.Jul 16 2021, 3:17 PM

Change 704936 merged by jenkins-bot:

[integration/quibble@master] Release Quibble 1.0.0

https://gerrit.wikimedia.org/r/704936

Stashbot mentioned this in T218534: Run Parsoid service in quibble.Jul 16 2021, 5:12 PM
Stashbot mentioned this in T286187: Release Quibble 1.0.0.
Stashbot mentioned this in T280506: Is it intended Quibble does not install the dependencies of the installed skins?.
Stashbot mentioned this in T90875: Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php.

Mentioned in SAL (#wikimedia-releng) [2021-07-16T17:12:11Z] <hashar> Tag Quibble 1.0.0 @ a13d133f7d1 # T286187 T280506 T90875 T218534 T227352

gerritbot added a comment.Jul 21 2021, 2:01 PM

Change 705907 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[integration/quibble@master] Revert "Load Parsoid from vendor as fallback, and configure"

https://gerrit.wikimedia.org/r/705907

gerritbot added a comment.Jul 23 2021, 12:48 PM

Change 705907 merged by jenkins-bot:

[integration/quibble@master] Revert \"Load Parsoid from vendor as fallback, and configure\"

https://gerrit.wikimedia.org/r/705907

gerritbot added a comment.Sep 27 2022, 12:43 PM

Change 701346 abandoned by Hashar:

[integration/config@master] Add parsoid dependency to VisualEditor

Reason:

I am pretty sure this is obsolete nowadays. The last injections of parsoid got removed in July 2022 https://gerrit.wikimedia.org/r/c/integration/config/+/803990 .

https://gerrit.wikimedia.org/r/701346

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits