Page MenuHomePhabricator
Create Task
Maniphest T233736

Testing the REST API in CI
Closed, ResolvedPublic
Actions

Description

Currently, in CI, Parsoid/JS spins up a service using mockAPI.js as the MediaWiki API and runs the mocha/api.js suite.

For the purpose of the port, we have a patch which lets a local MediaWiki instance with the installed Parsoid/PHP extension also use mockAPI.js for DataAccess and then we can run the mocha/api.js test suite with a supplied PARSOID_URL (added in T221168).

Moving forward though, we probably want to move to whatever the MediaWiki action API is tested with and do away with mocha altogether.

Details

SubjectRepoBranchLines +/-
Skip some api tests, for nowmediawiki/services/parsoidmaster+465 -435
Take api testing out of experimental for Parsoidintegration/configmaster+2 -2
Fix api test broken in a4b8b38mediawiki/services/parsoidmaster+1 -1
Fix api test broken in 6849f5fmediawiki/services/parsoidmaster+2 -2
Setup for parsing oldHTML if none providedmediawiki/services/parsoidmaster+5 -0
Bump parsoid to 0.13.0-a1mediawiki/vendormaster+1 K -824
Add a test for serializing when a revision isn't foundmediawiki/services/parsoidmaster+20 -0
Turn on API integration tests for Parsoidintegration/configmaster+2 -0
Use api-testing to run integration testsmediawiki/services/parsoidmaster+225 -174
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT261329 Prepare Parsoid for MW
 ResolvedArlolraT248694 Improve testing of Parsoid/PHP (1.36)
 ResolvedArlolraT233736 Testing the REST API in CI

Event Timeline

Arlolra created this task.Sep 24 2019, 4:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2019, 4:34 PM
• ssastry moved this task from Backlog to Testing / QA on the Parsoid-PHP board.Sep 25 2019, 12:56 AM
Arlolra mentioned this in T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision?.Oct 11 2019, 11:13 PM
Arlolra added a comment.Oct 11 2019, 11:31 PM

Probably depends on T227352

Arlolra triaged this task as High priority.Dec 4 2019, 9:46 PM
cscott added a parent task: T248694: Improve testing of Parsoid/PHP (1.36).Mar 27 2020, 4:11 PM
Arlolra merged a task: T248693: Migrate mocha tests to a more appropriate PHP-based test runner.Mar 27 2020, 7:31 PM
Arlolra added a subscriber: cscott.
Arlolra added a comment.Apr 6 2020, 3:26 PM

Making a note to add the test requested here,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/583450#message-a2b8b64d684b3eb5a1d6d6b01a0b7dd339b7ed8c

Aklapper edited projects, added Parsoid; removed Parsoid-PHP.Apr 10 2020, 4:27 PM
• ssastry moved this task from Needs Triage to Testing on the Parsoid board.Apr 10 2020, 4:56 PM
Arlolra claimed this task.May 8 2020, 2:05 PM
gerritbot added a comment.Jun 30 2020, 12:40 AM

Change 608495 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] [WIP] Use api-testing to run integration tests

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/ /608495

gerritbot added a project: Patch-For-Review.Jun 30 2020, 12:40 AM
gerritbot added a comment.Jul 13 2020, 10:10 PM

Change 608495 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Use api-testing to run integration tests

https://gerrit.wikimedia.org/r/608495

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2020, 11:10 PM
gerritbot added a comment.Jul 14 2020, 10:27 PM

Change 612673 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[integration/config@master] Turn on API integration tests for Parsoid

https://gerrit.wikimedia.org/r/612673

gerritbot added a project: Patch-For-Review.Jul 14 2020, 10:27 PM
gerritbot added a comment.Jul 15 2020, 3:44 PM

Change 612673 merged by jenkins-bot:
[integration/config@master] Turn on API integration tests for Parsoid

https://gerrit.wikimedia.org/r/612673

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2020, 4:11 PM
gerritbot added a comment.Jul 16 2020, 12:06 AM

Change 612992 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Add a test for serializing when a revision isn't found

https://gerrit.wikimedia.org/r/612992

gerritbot added a project: Patch-For-Review.Jul 16 2020, 12:06 AM
gerritbot added a comment.Jul 16 2020, 5:52 PM

Change 612992 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add a test for serializing when a revision isn't found

https://gerrit.wikimedia.org/r/612992

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2020, 6:10 PM
gerritbot added a comment.Jul 20 2020, 9:11 PM

Change 614872 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump parsoid to 0.13.0-a1

https://gerrit.wikimedia.org/r/614872

gerritbot added a project: Patch-For-Review.Jul 20 2020, 9:11 PM
gerritbot added a comment.Jul 21 2020, 1:01 AM

Change 614872 merged by jenkins-bot:
[mediawiki/vendor@master] Bump parsoid to 0.13.0-a1

https://gerrit.wikimedia.org/r/614872

gerritbot added a comment.Oct 29 2020, 10:11 PM

Change 637570 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Setup for parsing oldHTML if none provided

https://gerrit.wikimedia.org/r/637570

gerritbot added a comment.Oct 29 2020, 10:57 PM

Change 637570 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Setup for parsing oldHTML if none provided

https://gerrit.wikimedia.org/r/637570

cscott added a comment.Dec 8 2020, 7:55 PM

Currently if you comment check experimental on a gerrit patch it will run npm run api-testing.

@Arlolra says: "the only thing that's missing is that the db needs to be populated with the necessary pages"

Arlolra added a comment.Dec 8 2020, 8:01 PM

When I want to test this locally, I'll put in my LocalSettings.php,

$wgEnableRestAPI = true;
$wgParsoidSettings = [
	'linting' => true,
	'useSelser' => true,
	'debugApi' => "http://localhost:12345/api.php",
	'wt2htmlLimits' => [
		'wikitextSize' => 20000,
	],
	'html2wtLimits' => [
		'htmlSize' => 10000,
	],
];

and then run MOCKPORT=12345 node tests/mockAPI.js

I've got a .api-testing.config.json with values like,

{
	"base_uri": "http://localhost:8080/",
	"main_page": "Main_Page",
	"root_user": {
		"name": "Admin",
		"password": ""
	},
	"secret_key": "XXX"
}

and then I can run npm run api-testing

A properly setup db wouldn't need any of that LocalSettings configuration or mockAPI.js nonsense.

cscott added a comment.Dec 8 2020, 8:13 PM

https://www.mediawiki.org/wiki/MediaWiki_API_integration_tests#Resetting_the_target_wiki

gerritbot added a comment.May 26 2021, 7:59 PM

Change 695476 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Fix api test broken in 6849f5f

https://gerrit.wikimedia.org/r/695476

gerritbot added a comment.May 26 2021, 7:59 PM

Change 695477 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Fix api test broken in a4b8b38

https://gerrit.wikimedia.org/r/695477

gerritbot added a comment.May 26 2021, 10:33 PM

Change 695561 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Skip variant tests, for now

https://gerrit.wikimedia.org/r/695561

gerritbot added a comment.May 27 2021, 4:05 PM

Change 695476 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Fix api test broken in 6849f5f

https://gerrit.wikimedia.org/r/695476

gerritbot added a comment.May 27 2021, 4:06 PM

Change 695477 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Fix api test broken in a4b8b38

https://gerrit.wikimedia.org/r/695477

gerritbot added a comment.May 27 2021, 4:19 PM

Change 696566 had a related patch set uploaded (by Arlolra; author: Arlolra):

[integration/config@master] Take api testing out of experimental for Parsoid

https://gerrit.wikimedia.org/r/696566

gerritbot added a comment.May 27 2021, 5:42 PM

Change 695561 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Skip some api tests, for now

https://gerrit.wikimedia.org/r/695561

gerritbot added a comment.May 27 2021, 5:45 PM

Change 696566 merged by jenkins-bot:

[integration/config@master] Take api testing out of experimental for Parsoid

https://gerrit.wikimedia.org/r/696566

Arlolra closed this task as Resolved.May 27 2021, 8:17 PM
Arlolra mentioned this in T283875: Re-enable skipped API tests.May 27 2021, 8:30 PM
cscott mentioned this in T287001: Core tests failing due to Flow HTTP requests and ServiceContainer access.Jul 21 2021, 12:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits