Page MenuHomePhabricator
Create Task
Maniphest T248726

Run phan on code in extension/
Closed, ResolvedPublic
Actions

Description

Would have saved a lot of pain,

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/583944/1/extension/src/Config/DataAccess.php#330
https://github.com/wikimedia/parsoid/commit/5b6c1aab7977579133d4a08ce24146a3b0d31502
https://github.com/wikimedia/parsoid/commit/8072dd7b2b05b9fe7ac2c048802acb3f715b56fc
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/583477/1..2/extension/src/Rest/Handler/PageHandler.php
etc

There's a WIP here,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/583985

Details

SubjectRepoBranchLines +/-
Turn on "integrated" phan tests for Parsoidintegration/configmaster+5 -2
jjb: [parsoidsvc-parsertests-docker] Update path to parsoidintegration/configmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Arlolra created this task.Mar 28 2020, 1:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2020, 1:29 AM
Arlolra assigned this task to cscott.Mar 28 2020, 1:29 AM
Arlolra triaged this task as High priority.
gerritbot added a comment.Mar 28 2020, 1:29 AM

Change 583985 had a related patch set uploaded (by Arlolra; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] WIP: Run phan on code in extension/

https://gerrit.wikimedia.org/r/583985

gerritbot added a project: Patch-For-Review.Mar 28 2020, 1:29 AM
Arlolra moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.Mar 28 2020, 1:30 AM
ssastry added a project: Parsing-Active-Work.Apr 20 2020, 9:19 PM
ssastry moved this task from Incoming Work (but not yet ready) to Doing (Other Work) on the Parsing-Active-Work board.
cscott added a parent task: T227352: Set up extension tests for Parsoid repo.May 1 2020, 11:30 PM
gerritbot added a comment.May 1 2020, 11:31 PM

Change 588026 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[integration/config@master] jjb: [parsoidsvc-parsertests-docker] Update path to parsoid

https://gerrit.wikimedia.org/r/588026

cscott added a comment.May 8 2020, 9:46 PM

Currently blocked on getting a new version of quibble released. See https://gerrit.wikimedia.org/r/594522

Jdforrester-WMF subscribed.Jun 5 2020, 7:41 PM

No longer blocked. Finally.

gerritbot added a comment.Jun 5 2020, 7:43 PM

Change 588026 merged by jenkins-bot:
[integration/config@master] jjb: [parsoidsvc-parsertests-docker] Update path to parsoid

https://gerrit.wikimedia.org/r/588026

ssastry moved this task from Tech Debt / Big changes to Current & Upcoming Work on the Parsoid board.Jul 2 2020, 6:41 PM
gerritbot added a comment.Jul 13 2020, 10:22 PM

Change 612429 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[integration/config@master] Turn on "integrated" phan tests for Parsoid

https://gerrit.wikimedia.org/r/612429

gerritbot added a comment.Jul 14 2020, 7:42 PM

Change 612429 merged by jenkins-bot:
[integration/config@master] Turn on "integrated" phan tests for Parsoid

https://gerrit.wikimedia.org/r/612429

cscott closed this task as Resolved.Aug 4 2020, 5:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits