Page MenuHomePhabricator
Create Task
Maniphest T218534

Run Parsoid service in quibble
Closed, ResolvedPublicFeature
Actions

Description

My work in T218345: Investigate Selenium tests for validating event logging data looked promising locally until it was time to make the tests pass in CI. I've since discovered that the issue documented in T150435#3479616 is going to block further progress. I need Parsoid in Quibble so that my Selenium tests which exercise actions that happen in a VisualEditor context can run.

Looking at quibble/cmd.py#execute, perhaps after with quibble.backend.ChromeWebDriver(display=display): we could also start a Parsoid service? From setting this up locally, I think all we'd need to do is clone the parsoid repo, have a minimal config (~12 lines), and npm run start.

Details

SubjectRepoBranchLines +/-
Allow Flow to use Parsoid for API testsintegration/configmaster+1 -1
Revert "Load Parsoid from vendor as fallback, and configure"integration/quibblemaster+7 -17
Load Parsoid from vendor as fallback, and configureintegration/quibblemaster+17 -7
Release Quibble 1.0.0integration/quibblemaster+41 -3
(wip) Add configuration for Parsoid/PHPintegration/quibblemaster+11 -0
Add Parsoid to docker image and run for Selenium testsintegration/quibblemaster+64 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Mar 18 2019, 1:25 AM
gerritbot subscribed.Mar 18 2019, 2:05 AM

Change 497222 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/quibble@master] [WIP] Add Parsoid to docker image and run for Selenium tests

https://gerrit.wikimedia.org/r/497222

gerritbot added a project: Patch-For-Review.Mar 18 2019, 2:05 AM
kostajh mentioned this in rQUIBBLE4f29589ac304: [WIP] Add Parsoid to docker image and run for Selenium tests.Mar 18 2019, 2:07 AM
kostajh changed the subtype of this task from "Task" to "Feature Request".Mar 18 2019, 2:08 AM
gerritbot added a comment.Mar 21 2019, 2:51 AM

Change 497222 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/quibble@master] [WIP] Add Parsoid to docker image and run for Selenium tests

https://gerrit.wikimedia.org/r/497222

kostajh mentioned this in rQUIBBLE77de05470526: [WIP] Add Parsoid to docker image and run for Selenium tests.Mar 21 2019, 2:55 AM
kostajh mentioned this in rQUIBBLEf52248b25383: [WIP] Add Parsoid to docker image and run for Selenium tests.Mar 21 2019, 4:26 PM
kostajh added a comment.Mar 21 2019, 4:31 PM

@hashar I started with an idea of how this could work but am going to put it on hold. I'm having trouble testing my specific extension locally with Quibble, and you probably have opinions and ideas of how Parsoid could be better installed in the container (or even if you're open to doing that). Let me know if you'd like to talk through it sometime.

kostajh mentioned this in T218345: Investigate Selenium tests for validating event logging data.Mar 22 2019, 8:44 PM
Krinkle added a parent task: T76586: K3. Run Flow tests with Parsoid on Jenkins.Apr 13 2019, 1:40 AM
kostajh mentioned this in rQUIBBLE05454d8a0cfd: Add Parsoid to docker image and run for Selenium tests.Apr 15 2019, 4:01 PM
kostajh mentioned this in rQUIBBLEb0a94632ba41: Add Parsoid to docker image and run for Selenium tests.Apr 15 2019, 4:29 PM
kostajh mentioned this in rQUIBBLEabca85846e9b: Add Parsoid to docker image and run for Selenium tests.
kostajh mentioned this in rQUIBBLEe3767b1a566a: Add Parsoid to docker image and run for Selenium tests.Apr 15 2019, 4:35 PM
gerritbot added a comment.Jun 14 2019, 2:35 PM

Change 497222 abandoned by Kosta Harlan:
Add Parsoid to docker image and run for Selenium tests

Reason:
not going to be pursued, maybe with local-charts someday

https://gerrit.wikimedia.org/r/497222

gerritbot added a comment.Nov 27 2019, 12:21 PM

Change 553333 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/quibble@master] (wip) Add configuration for Parsoid/PHP

https://gerrit.wikimedia.org/r/553333

hashar added a comment.Dec 19 2019, 3:23 PM

T235865 is a similar need but requiring ElasticSearch.

hashar mentioned this in T235865: Modify Quibble to accept a LocalSettings.php file .Dec 19 2019, 3:29 PM
• Clarakosi subscribed.Jan 6 2020, 3:53 PM
Jdforrester-WMF added a subtask: T225218: Consider httpd for quibble instead of php built-in server.Apr 14 2020, 5:29 PM
awight moved this task from Backlog to In progress on the Quibble board.Apr 19 2020, 8:18 AM
cscott subscribed.May 2 2020, 4:10 AM

Parsoid is in PHP now, could make this easier?

gerritbot added a comment.Jul 15 2020, 7:50 PM

Change 553333 abandoned by C. Scott Ananian:
[integration/quibble@master] (wip) Add configuration for Parsoid/PHP

Reason:
Not needed, w/ VE autoconfig work. See also I19253b15c797054245aa46bcb44f82352967888f

https://gerrit.wikimedia.org/r/553333

awight closed subtask T225218: Consider httpd for quibble instead of php built-in server as Resolved.Mar 4 2021, 9:31 AM
kostajh claimed this task.Jul 5 2021, 8:08 AM
gerritbot added a comment.Jul 5 2021, 9:34 AM

Change 703182 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/quibble@master] Load parsoid from vendor as fall-back, and configure

https://gerrit.wikimedia.org/r/703182

zeljkofilipin added a project: User-zeljkofilipin.Jul 12 2021, 4:38 PM
zeljkofilipin moved this task from Backlog 🪒 to Watching 📺 on the User-zeljkofilipin board.
gerritbot added a comment.Jul 16 2021, 8:29 AM

Change 703182 merged by jenkins-bot:

[integration/quibble@master] Load Parsoid from vendor as fallback, and configure

https://gerrit.wikimedia.org/r/703182

gerritbot added a comment.Jul 16 2021, 10:27 AM

Change 704936 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/quibble@master] Release Quibble 1.0.0

https://gerrit.wikimedia.org/r/704936

gerritbot added a comment.Jul 16 2021, 3:17 PM

Change 704936 merged by jenkins-bot:

[integration/quibble@master] Release Quibble 1.0.0

https://gerrit.wikimedia.org/r/704936

Stashbot added a comment.Jul 16 2021, 5:12 PM

Mentioned in SAL (#wikimedia-releng) [2021-07-16T17:12:11Z] <hashar> Tag Quibble 1.0.0 @ a13d133f7d1 # T286187 T280506 T90875 T218534 T227352

Stashbot mentioned this in T286187: Release Quibble 1.0.0.Jul 16 2021, 5:12 PM
Stashbot mentioned this in T280506: Is it intended Quibble does not install the dependencies of the installed skins?.
Stashbot mentioned this in T90875: Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php.
Stashbot mentioned this in T227352: Set up extension tests for Parsoid repo.
gerritbot added a comment.Jul 21 2021, 2:01 PM

Change 705907 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[integration/quibble@master] Revert "Load Parsoid from vendor as fallback, and configure"

https://gerrit.wikimedia.org/r/705907

cscott added a comment.Jul 21 2021, 2:03 PM

Running the Parsoid service in quibble was already done; we use it to run api tests in CI. You just need to make Flow depend on the Parsoid extension.

gerritbot added a comment.Jul 21 2021, 3:24 PM

Change 705932 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[integration/config@master] Allow Flow to use Parsoid for API tests

https://gerrit.wikimedia.org/r/705932

cscott mentioned this in T287001: Core tests failing due to Flow HTTP requests and ServiceContainer access.Jul 21 2021, 3:34 PM
gerritbot added a comment.Jul 23 2021, 12:48 PM

Change 705907 merged by jenkins-bot:

[integration/quibble@master] Revert \"Load Parsoid from vendor as fallback, and configure\"

https://gerrit.wikimedia.org/r/705907

awight closed this task as Resolved.Jan 26 2022, 10:43 AM
awight subscribed.

Looks like this is done.

gerritbot added a comment.Sep 27 2022, 12:44 PM

Change 705932 abandoned by Hashar:

[integration/config@master] Allow Flow to use Parsoid for API tests

Reason:

I am pretty sure this is obsolete nowadays. The last injections of parsoid got removed in July 2022 https://gerrit.wikimedia.org/r/c/integration/config/+/803990

https://gerrit.wikimedia.org/r/705932

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL