Page MenuHomePhabricator

Investigate Selenium tests for validating event logging data
Closed, DeclinedPublic

Description

As noted in T217802, we've had issues with changes to our help panel code resulting in incorrect event logging. We've documented some scenarios (https://meta.wikimedia.org/wiki/Schema_talk:HelpPanel) to attempt to reduce problems in the future, but it's not really sustainable to run through these scenarios for each change to our code, not to mention whenever external dependencies like VisualEditor and MobileFrontend are updated.

This task is an exploration of whether we can use Selenium tests to inspect mw.trackQueue and ensure that a core set of interactions with the help panel are logged correctly.

cc'ing @jlinehan as @MMiller_WMF mentioned you might be interested in this.

Related Objects

Mentioned In
T229389: Invert configuration for GrowthExperiments
rEGRE43216b1c85cc: [WIP] Selenium tests for help panel and help module event logging
rEGREb502f40b02ef: [WIP] Selenium tests for help panel and help module event logging
rEGREae209b8f4103: [WIP] Selenium tests for help panel and help module event logging
rEGRE7418b1c44617: [WIP] Selenium tests for help panel and help module event logging
T218534: Run Parsoid service in quibble
rEGRE24a3bdedd118: [WIP] Selenium tests for help panel and help module event logging
rEGRE5864178bbb7c: [WIP] Selenium tests for validating help panel and help module events
rEGRE9adbd0eb66eb: [WIP] Selenium tests for validating help panel and help module events
rEGRE19faac586703: [WIP] Selenium tests for validating help panel and help module events
rEGRE62cb606505e6: [WIP] Selenium tests for validating help panel and help module events
rEGREd82ccdaa6b63: [WIP] Selenium tests for validating help panel and help module events
rEGREed196764dc69: [WIP] Selenium tests for validating help panel and help module events
T199939: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature
rEGRE739393a98425: [WIP] Selenium tests for validating help panel and help module events
rEGREa875122ea4c1: [WIP] Selenium tests for validating help panel and help module events
rEGRE327b95ba99e0: [WIP] Selenium tests for validating help panel and help module events
rEGRE2cd95a8dc6b5: [WIP] Selenium tests for validating help panel and help module events
rEGRE4b2b54d722c9: [WIP] Selenium tests for validating help panel and help module events
rEGRE501a4bea1f61: [WIP] Selenium tests for validating help panel and help module events
rEGREc71b3aec64d9: [WIP] Selenium tests for validating help panel and help module events
Mentioned Here
T218534: Run Parsoid service in quibble
T218370: [betalabs-regression] Special:Block displays Uncaught Error: Circular dependency! mw-input-wpExpiry
T217802: Help panel: impressions with VE are incorrectly marked as reading editor_interface

Event Timeline

Change 496559 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] GrowthExperiments: Add MobileFrontend and VisualEditor dependencies

https://gerrit.wikimedia.org/r/496559

Change 496528 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] [WIP] Selenium tests for validating help panel and help module events

https://gerrit.wikimedia.org/r/496528

This comment has been deleted.

Change 496528 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] [WIP] Selenium tests for help panel and help module event logging

https://gerrit.wikimedia.org/r/496528

This is blocked on T218534: Run Parsoid service in quibble, so I'm moving this out of the current sprint and we can revisit it later.

Change 496559 abandoned by Jforrester:
GrowthExperiments: Add MobileFrontend and VisualEditor dependencies

Reason:
Not needed for now.

https://gerrit.wikimedia.org/r/496559

Change 496528 abandoned by Kosta Harlan:
[WIP] Selenium tests for help panel and help module event logging

https://gerrit.wikimedia.org/r/496528

We didn't pursue this. Maybe we'll want to in the future, but no need to keep this aound.