Page MenuHomePhabricator

Compare the contents: Support opening the articles
Closed, ResolvedPublic

Description

As part of the "Compare the contents before translating" step (T241589) of the Section Translation workflow, a "new tab indicator" next to the top article/section title enables users to open the current article for both the source and target content:

Compare contents - Contents.png (768×1 px, 223 KB)
Compare contents - Contents Dimensions.png (768×1 px, 160 KB)

Event Timeline

Pginer-WMF triaged this task as Medium priority.
Pginer-WMF created this task.

Change 618262 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXContentComparator: Add support for opening articles

https://gerrit.wikimedia.org/r/618262

Change 618262 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SXContentComparator: Add support for opening articles

https://gerrit.wikimedia.org/r/618262

The "open in new tab" icon was intended to be using Base30 color (#72777d). However, it is shown in black currently which gives more visual weight than intended.

@ngkountas, is this something easy to adjust or the icon system needs more general improvements for allowing icons in different colors?

Change 628931 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXContentComparator: Fix UI color glitch in open tab icon

https://gerrit.wikimedia.org/r/628931

The "open in new tab" icon was intended to be using Base30 color (#72777d). However, it is shown in black currently which gives more visual weight than intended.

@ngkountas, is this something easy to adjust or the icon system needs more general improvements for allowing icons in different colors?

This was an isolated issue caused by regression from refactoring. Fixed in patch above

Change 628931 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SXContentComparator: Fix UI color glitch in open tab icon

https://gerrit.wikimedia.org/r/628931