Page MenuHomePhabricator

Visual diff doesn't show all of a complex multi-line reference, only shows the first line.
Closed, ResolvedPublic

Description

See https://en.wikipedia.org/w/index.php?title=Isabel_Allende&type=revision&diff=947220532&oldid=946589528

It replaces plain text inside ref tags with a template. The template displays in the article, but not in the visual diff.

Reported by @Lent at https://www.mediawiki.org/wiki/Topic:Vj829wt7uhj3ktv6

Minimal test case

*Create a multi-line reference (<ref>Foo<p>bar</p></ref>)
*Change both lines <ref>Foooo<p>bazzz</p></ref>
*View visual diff

Example: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:ESanders_(WMF)/sandbox/ref&type=revision&diff=534534&oldid=534532&diffmode=visual

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders renamed this task from Visual diff doesn't show the addition of a template to Visual diff doesn't show the addition of a template in a reference.Sep 8 2020, 12:22 PM
Esanders renamed this task from Visual diff doesn't show the addition of a template in a reference to Visual diff doesn't show all of a complex multi-line reference, only shows the first line..Jan 16 2022, 2:29 PM

Change 754103 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] DiffElement: Fix rendering of internal list items with multiple child nodes

https://gerrit.wikimedia.org/r/754103

Testing with monkey-patched code above:

image.png (973×982 px, 222 KB)

Change 754103 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] DiffElement: Fix rendering of internal list items with multiple child nodes

https://gerrit.wikimedia.org/r/754103

Change 755058 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (20902e538)

https://gerrit.wikimedia.org/r/755058

Change 755058 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (20902e538)

https://gerrit.wikimedia.org/r/755058

matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to QA on the Editing-team (FY2021-22 Kanban Board) board.
matmarex added a project: Editing QA.
matmarex moved this task from Inbox to Low Priority on the Editing QA board.
ppelberg claimed this task.