Page MenuHomePhabricator

PHP Fatal error: Uncaught Error: Call to undefined method TitleValue::isSubpage() in /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/Skins/SkinUserPageHelper.php:55 in /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/Skins/SkinUserPageHelper.php on line 55
Closed, ResolvedPublic

Description

Occurs on https://m.mediawiki.org/wiki/User_talk:2001:16B8:1080:4E00:85A0:B72F:EC1:E270

 	Uncaught Error: Call to undefined method TitleValue::isSubpage() in /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/Skins/SkinUserPageHelper.php:55
t exception.trace 	
	#0 /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/Skins/SkinUserPageHelper.php(95): MediaWiki\Minerva\Skins\SkinUserPageHelper->fetchData()
#1 /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/ServiceWiring.php(105): MediaWiki\Minerva\Skins\SkinUserPageHelper->isUserPage()
#2 /srv/mediawiki/php-1.36.0-wmf.4/vendor/wikimedia/services/src/ServiceContainer.php(447): Wikimedia\Services\ServiceContainer->{closure}(Object(MediaWiki\MediaWikiServices))
#3 /srv/mediawiki/php-1.36.0-wmf.4/vendor/wikimedia/services/src/ServiceContainer.php(416): Wikimedia\Services\ServiceContainer->createService('Minerva.Menu.Pa...')
#4 /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/Skins/SkinMinerva.php(169): Wikimedia\Services\ServiceContainer->getService('Minerva.Menu.Pa...')
#5 /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/inc

My (unconfirmed) guess is this might have been caused by https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/619118 cc @D3r1ck01

Event Timeline

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptAug 11 2020, 3:45 PM
Jdlrobson renamed this task from [fd7521e7-e94e-4e46-a6dc-a37028380c00] PHP Fatal error: Uncaught Error: Call to undefined method TitleValue::isSubpage() in /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/Skins/SkinUserPageHelper.php:55 in /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/Skins/SkinUserPageHelper.php on line 55 to PHP Fatal error: Uncaught Error: Call to undefined method TitleValue::isSubpage() in /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/Skins/SkinUserPageHelper.php:55 in /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/Skins/SkinUserPageHelper.php on line 55.Aug 11 2020, 3:45 PM
Jdlrobson triaged this task as Unbreak Now! priority.

Fatal errors in production is something I don't think we ever want to see so marking UBN.

Should this block the train?

hashar added a subscriber: hashar.EditedAug 11 2020, 3:49 PM

Seems to happen on any anon talk page.

Example: https://m.mediawiki.org/w/index.php?title=User_talk:Hashar

Change 619375 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Revert "ServiceWiring: Avoid usage of deprecated Title::getSubjectPage()"

https://gerrit.wikimedia.org/r/619375

Change 619376 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@wmf/1.36.0-wmf.4] Revert "ServiceWiring: Avoid usage of deprecated Title::getSubjectPage()"

https://gerrit.wikimedia.org/r/619376

Jdlrobson added a comment.EditedAug 11 2020, 3:51 PM

@hashar revert fixes it - can https://gerrit.wikimedia.org/r/619376 be folded into the current deploy branch?

Change 619376 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.36.0-wmf.4] Revert "ServiceWiring: Avoid usage of deprecated Title::getSubjectPage()"

https://gerrit.wikimedia.org/r/619376

Change 619375 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Revert "ServiceWiring: Avoid usage of deprecated Title::getSubjectPage()"

https://gerrit.wikimedia.org/r/619375

Oops, really sorry about the mess @Jdlrobson, thanks for reverting and fixing the issue. 🙏🏽

Going to deploy it right now.

Mentioned in SAL (#wikimedia-operations) [2020-08-11T16:53:17Z] <hashar@deploy1001> Synchronized php-1.36.0-wmf.4/skins/MinervaNeue/: Revert "ServiceWiring: Avoid usage of deprecated Title::getSubjectPage()" - T260155 (duration: 01m 06s)

Tested it on mwdebug1001 using https://m.mediawiki.org/w/index.php?title=User_talk:Hashar as a test area. It did not came up immediately after I have pulled the code on mwdebug1001, but after a few retries it went through.

The patch is now on all servers. Thank you for the very very quick fix! I am removing the task from the blockers. Maybe you want to keep the task to redo the patch?

hashar lowered the priority of this task from Unbreak Now! to High.Aug 11 2020, 4:55 PM

Maybe you want to keep the task to redo the patch?

Yes, will like to redo the patch again. Also, yes I tested (with your test area and others like what Jon reported above https://m.mediawiki.org/wiki/User_talk:2001:16B8:1080:4E00:85A0:B72F:EC1:E270) the revert and everything is fine again.

Jdlrobson closed this task as Resolved.Aug 11 2020, 6:32 PM
Jdlrobson claimed this task.

Thanks for taking care of this!

Team work! Thank you \o/