1.36.0-wmf.4 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	• mmodell
	Jul 14 2020, 8:19 PM

Details

Backup Train Conductor: • mmodell
Release Version: 1.36.0-wmf.4
Release Date: Aug 10 2020, 12:00 AM

2020 week 33 1.36-wmf.4 Changes wmf/1.36.0-wmf.4

This MediaWiki Train Deployment is scheduled for the week of Monday, August 10th:

Monday August 10th	Tuesday, August 11th	Wednesday, August 12th	Thursday, August 13th	Friday
Backports only.	Branch `wmf.4` and deploy to Group 0 Wikis.	Deploy `wmf.4` to Group 1 Wikis.	Deploy `wmf.4` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.4 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.36.0-wmf.3

Next: 1.36.0-wmf.5

	Subject	Repo	Branch	Lines +/-
	Revert "group1 wikis to 1.36.0-wmf.4"	operations/mediawiki-config	master	+513 -513
	Branch commit for wmf/1.36.0-wmf.4	mediawiki/core	wmf/1.36.0-wmf.4	+961 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	hashar	T257972 1.36.0-wmf.4 deployment blockers
		Resolved		hashar	T260145 Old MediaWiki versions are not purged from staging/app server

Event Timeline

• mmodell created this task.Jul 14 2020, 8:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2020, 8:19 PM

BEANS-X2 subscribed.Jul 27 2020, 8:07 AM

Lucas_Werkmeister_WMDE added a subtask: T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given.Aug 6 2020, 11:31 AM

thcipriani assigned this task to hashar.Aug 7 2020, 6:44 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: • mmodell.

thcipriani added a project: Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).

taavi removed a subtask: T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given.Aug 8 2020, 8:53 AM

Change 619397 had a related patch set uploaded (by DannyS712; owner: trainbranchbot):
[mediawiki/core@wmf/1.36.0-wmf.4] Branch commit for wmf/1.36.0-wmf.4

https://gerrit.wikimedia.org/r/619397

gerritbot added a project: Patch-For-Review.Aug 11 2020, 2:09 AM

Change 619397 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.4] Branch commit for wmf/1.36.0-wmf.4

https://gerrit.wikimedia.org/r/619397

Mentioned in SAL (#wikimedia-operations) [2020-08-11T13:12:36Z] <hashar> Applied 1.36.0-wmf.4 security patches # T257972

hashar mentioned this in T260145: Old MediaWiki versions are not purged from staging/app server.Aug 11 2020, 2:42 PM

Ladsgroup subscribed.Aug 11 2020, 2:47 PM

hashar added a subtask: T260145: Old MediaWiki versions are not purged from staging/app server.Aug 11 2020, 2:48 PM

Had to abort the deployment to testwiki due to some disk space issue (T260145, T260146). I am not running scap sync to ensure everything is in sync.

hashar added a subtask: T260155: PHP Fatal error: Uncaught Error: Call to undefined method TitleValue::isSubpage() in /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/Skins/SkinUserPageHelper.php:55 in /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/Skins/SkinUserPageHelper.php on line 55.Aug 11 2020, 3:49 PM

hashar removed a subtask: T260155: PHP Fatal error: Uncaught Error: Call to undefined method TitleValue::isSubpage() in /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/Skins/SkinUserPageHelper.php:55 in /srv/mediawiki/php-1.36.0-wmf.4/skins/MinervaNeue/includes/Skins/SkinUserPageHelper.php on line 55.Aug 11 2020, 4:55 PM

status

We had to clear out very old mediawiki versions from the servers since at least mwdebug1001 went out of disk space (no user impact). Fixed now.
A lot of Icinga alarms when I aborted sync wikiversions. Thewikiversions.json had different versions for the testswikis, hardly a big issue afaik.
Some faulty patch in Minervaneue got promptly reverted

Logstash is all clear for now so that sounds promising.

Next steps:

Wed, 12 Aug, EU Train Window, 13:00 UTC: Group1
Wed 12 Aug, US Train Window, 19:00 UTC: All Wikis

thcipriani closed subtask T260145: Old MediaWiki versions are not purged from staging/app server as Resolved.Aug 11 2020, 5:48 PM

Change 619613 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/mediawiki-config@master] Revert "group1 wikis to 1.36.0-wmf.4"

https://gerrit.wikimedia.org/r/619613

Change 619613 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "group1 wikis to 1.36.0-wmf.4"

https://gerrit.wikimedia.org/r/619613

Blocked on MediaWiki application servers going out of memory. Private report is https://docs.google.com/document/d/1x1sXbklz98fBTKMBsv4fnbeAedG0RMjGEFJ8mrvD454/edit#

Went with sysctl -w vm/compact_memory=1 which should workaround the issue. SRE stated we can resume.

[13:27:13] <logmsgbot> !log hashar@deploy1001 Synchronized php: group1 wikis to 1.36.0-wmf.4 (duration: 01m 16s)

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)) board.Aug 12 2020, 5:07 PM

Looks like it is a success ! :]

1.36.0-wmf.4 deployment blockersClosed, ResolvedPublicReleaseActions