Page MenuHomePhabricator

Allow to set a caller on BatchRowIterator and BatchRowWriter
Closed, ResolvedPublic

Description

As seen on T260232 it could be hard to find the caller for a select query when it is coming from BatchRowIterator.

It would be nice to allow the caller (METHOD) to pass in like possible on GenderCache or Linkbatch instances and pass it to the database abstraction layer for better debugging.

It could be done by a new arg on constructor or a setCaller method or such.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2020, 1:52 PM

Change 620432 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Add setCaller to BatchRowIterator

https://gerrit.wikimedia.org/r/620432

Change 620793 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Add setCaller to BatchRowWriter

https://gerrit.wikimedia.org/r/620793

Change 620793 merged by jenkins-bot:
[mediawiki/core@master] Add setCaller to BatchRowWriter

https://gerrit.wikimedia.org/r/620793

Umherirrender closed this task as Resolved.Aug 21 2020, 6:03 PM
Umherirrender assigned this task to Reedy.
Umherirrender triaged this task as Medium priority.

Change 620432 merged by jenkins-bot:
[mediawiki/core@master] Add setCaller to BatchRowIterator

https://gerrit.wikimedia.org/r/620432

Reedy renamed this task from Allow to set a caller on BatchRowIterator and BatchRowUpdate/BatchRowWriter to Allow to set a caller on BatchRowIterator and BatchRowWriter.Aug 21 2020, 7:57 PM