Page MenuHomePhabricator
Create Task
Maniphest T260354

Allow to set a caller on BatchRowIterator and BatchRowWriter
Closed, ResolvedPublic
Actions

Description

As seen on T260232 it could be hard to find the caller for a select query when it is coming from BatchRowIterator.

It would be nice to allow the caller (METHOD) to pass in like possible on GenderCache or Linkbatch instances and pass it to the database abstraction layer for better debugging.

It could be done by a new arg on constructor or a setCaller method or such.

Details

SubjectRepoBranchLines +/-
Add setCaller to BatchRowIteratormediawiki/coremaster+25 -1
Add setCaller to BatchRowWritermediawiki/coremaster+24 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Aug 13 2020, 1:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2020, 1:52 PM
Umherirrender mentioned this in T260232: BatchRowIterator slow query on commonswiki.Aug 15 2020, 12:05 PM
Reedy merged a task: T260473: Having `BatchRowIterator::next` as the fname of the caller to $db->select() is not helpful.Aug 15 2020, 12:06 PM
Reedy subscribed.
gerritbot added a comment.Aug 15 2020, 12:09 PM

Change 620432 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Add setCaller to BatchRowIterator

https://gerrit.wikimedia.org/r/620432

gerritbot added a project: Patch-For-Review.Aug 15 2020, 12:09 PM
gerritbot added a comment.Aug 17 2020, 10:05 PM

Change 620793 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Add setCaller to BatchRowWriter

https://gerrit.wikimedia.org/r/620793

gerritbot added a comment.Aug 21 2020, 5:47 PM

Change 620793 merged by jenkins-bot:
[mediawiki/core@master] Add setCaller to BatchRowWriter

https://gerrit.wikimedia.org/r/620793

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 21 2020, 6:00 PM
Umherirrender closed this task as Resolved.Aug 21 2020, 6:03 PM
Umherirrender assigned this task to Reedy.
Umherirrender triaged this task as Medium priority.
gerritbot added a comment.Aug 21 2020, 6:15 PM

Change 620432 merged by jenkins-bot:
[mediawiki/core@master] Add setCaller to BatchRowIterator

https://gerrit.wikimedia.org/r/620432

Maintenance_bot removed a project: Patch-For-Review.Aug 21 2020, 7:10 PM
Reedy renamed this task from Allow to set a caller on BatchRowIterator and BatchRowUpdate/BatchRowWriter to Allow to set a caller on BatchRowIterator and BatchRowWriter.Aug 21 2020, 7:57 PM
Reedy mentioned this in T261014: Make use of (BatchRowIterator|BatchRowWriter)::setCaller.Aug 21 2020, 7:59 PM
Reedy added a parent task: T261014: Make use of (BatchRowIterator|BatchRowWriter)::setCaller.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits