Argument 1 passed to GlobalPreferences\GlobalPreferencesFactory::setGlobalPreferences() must be an instance of User, null given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Wiki version: php-1.36.0-wmf.4
Referrer: https://ta.m.wikipedia.org/
URL: https://ta.m.wikipedia.org/wiki/Special:ContentTranslation?title=Special:ContentTranslation&campaign

Error

[51c08ac8-f94f-4a16-be34-c97c96089330] /wiki/Special:ContentTranslation?title=Special:ContentTranslation&campaign   TypeError from line 511 of /srv/mediawiki/php-1.36.0-wmf.4/extensions/GlobalPreferences/includes/GlobalPreferencesFactory.php: Argument 1 passed to GlobalPreferences\GlobalPreferencesFactory::setGlobalPreferences() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.4/extensions/ContentTranslation/includes/PreferenceHelper.php on line 71

trace

#0 /srv/mediawiki/php-1.36.0-wmf.4/extensions/ContentTranslation/includes/PreferenceHelper.php(71): GlobalPreferences\GlobalPreferencesFactory->setGlobalPreferences(NULL, array, RequestContext)
#1 /srv/mediawiki/php-1.36.0-wmf.4/extensions/ContentTranslation/specials/SpecialContentTranslation.php(254): ContentTranslation\PreferenceHelper::setGlobalPreference(NULL, string, string)
#2 /srv/mediawiki/php-1.36.0-wmf.4/includes/specialpage/SpecialPage.php(601): SpecialContentTranslation->afterExecute(NULL)
#3 /srv/mediawiki/php-1.36.0-wmf.4/includes/specialpage/SpecialPageFactory.php(681): SpecialPage->run(NULL)
#4 /srv/mediawiki/php-1.36.0-wmf.4/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#5 /srv/mediawiki/php-1.36.0-wmf.4/includes/MediaWiki.php(940): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.36.0-wmf.4/includes/MediaWiki.php(543): MediaWiki->main()
#7 /srv/mediawiki/php-1.36.0-wmf.4/index.php(53): MediaWiki->run()
#8 /srv/mediawiki/php-1.36.0-wmf.4/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Impact

Anonymous users accessing Special:CX with campaign parameter saw an error page instead of an invite to log in.

Details

	Subject	Repo	Branch	Lines +/-
	Fix fatal error on Special:CX if user is anonymous	mediawiki/extensions/ContentTranslation	master	+3 -2

Customize query in gerrit

Event Timeline

KartikMistry created this task.Aug 17 2020, 1:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2020, 1:18 PM

KartikMistry updated the task description. (Show Details)Aug 17 2020, 1:30 PM

Change 622551 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] Fix fatal error on Special:CX if user is anonymous

https://gerrit.wikimedia.org/r/622551

gerritbot added a project: Patch-For-Review.Aug 26 2020, 11:51 AM

Nikerabbit claimed this task.Aug 26 2020, 11:52 AM

Nikerabbit triaged this task as Low priority.

Nikerabbit updated the task description. (Show Details)

Nikerabbit added a project: Language-Team (Language-2020-July-September).

Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2020-July-September) board.

Nikerabbit added a project: Unplanned-Sprint-Work.

Change 622551 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix fatal error on Special:CX if user is anonymous

https://gerrit.wikimedia.org/r/622551

Nikerabbit moved this task from In Review to Needs QA on the Language-Team (Language-2020-July-September) board.Sep 1 2020, 6:43 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 1 2020, 7:10 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 1 2020, 12:00 PM

• Jpita moved this task from Needs QA to Recheck after deployment on the Language-Team (Language-2020-July-September) board.Sep 8 2020, 9:54 AM

Nikerabbit moved this task from Recheck after deployment to Needs QA on the Language-Team (Language-2020-July-September) board.Sep 16 2020, 6:21 AM

I went back one month and couldn't find this log.
Either I'm not searching correctly or this was fixed in a previous version.
@Nikerabbit @KartikMistry help?

• Jpita moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2020-July-September) board.Sep 16 2020, 10:21 PM

I can find five (old) entries when I search for setGlobalPreferences for past 30 days.

Direct way to test this is to visit the named URL while logged out.

• Jpita moved this task from Needs QA to Done on the Language-Team (Language-2020-July-September) board.Sep 17 2020, 8:18 PM

Nikerabbit changed the subtype of this task from "Task" to "Production Error".Sep 23 2020, 7:46 AM

Nikerabbit closed this task as Resolved.Sep 30 2020, 2:13 PM

Nikerabbit added a project: Wikimedia-production-error.

Argument 1 passed to GlobalPreferences\GlobalPreferencesFactory::setGlobalPreferences() must be an instance of User, null givenClosed, ResolvedPublicPRODUCTION ERRORActions