Page MenuHomePhabricator
Create Task
Maniphest T261218

Upgrade WebdriverIO to v6 in wdio-wikibase
Closed, ResolvedPublic
Actions

Description

TODO

  • update wdio-wikibase to webdriverio v6: PR
  • test it locally in wikibase with something like this: "wdio-mediawiki": "file:tests/selenium/wdio-mediawiki", (source)
  • test it in CI in wikibase with something like this: "wdio-wikibase": "wmde/wdio-wikibase#dependabot/npm_and_yarn/acorn-6.4.1",

Several Wikibase repositories make use of wdio-wikibase plugin for testing. The plugin currently supports WebdriverIO v5

While upgrading Wikibase to support WebdriverIO v6 one of the failure was:

Cannot destructure property `timeout` of 'undefined' or 'null'.
TypeError: Cannot destructure property `timeout` of 'undefined' or 'null'. at ItemPage.addMainStatement (/workspace/src/extensions/Wikibase/node_modules/wdio-wikibase/pagesections/main.statement.section.js:63:5)

Similarly, one of the failures of WikibaseLexeme was:

Cannot destructure property `timeout` of 'undefined' or 'null'.
TypeError: Cannot destructure property `timeout` of 'undefined' or 'null' at LexemePage.addMainStatement (/workspace/src/extensions/WikibaseLexeme/node_modules/wdio-wikibase/pagesections/main.statement.section.js:63:5)

PR seems to have solved the problem

15:18:28 [Chrome 73.0.3683.75 linux #0-3] Spec: /workspace/src/extensions/Wikibase/repo/tests/selenium/specs/readmode.references.js
15:18:28 [Chrome 73.0.3683.75 linux #0-3] Running: Chrome (v73.0.3683.75) on linux
15:18:28 [Chrome 73.0.3683.75 linux #0-3] Session ID: e7062c78-24ff-46ac-b040-bf083325f4e4
15:18:28 [Chrome 73.0.3683.75 linux #0-3]
15:18:28 [Chrome 73.0.3683.75 linux #0-3] WikibaseReferenceOnProtectedPage
15:18:28 [Chrome 73.0.3683.75 linux #0-3]    ✖ can expand collapsed references on a protected page as unprivileged user
15:18:28 [Chrome 73.0.3683.75 linux #0-3]
15:18:28 [Chrome 73.0.3683.75 linux #0-3] 1 failing (4s)
15:18:28 [Chrome 73.0.3683.75 linux #0-3]
15:18:28 [Chrome 73.0.3683.75 linux #0-3] 1) WikibaseReferenceOnProtectedPage can expand collapsed references on a protected page as unprivileged user
15:18:28 [Chrome 73.0.3683.75 linux #0-3] Cannot destructure property `timeout` of 'undefined' or 'null'.
15:18:28 [Chrome 73.0.3683.75 linux #0-3] TypeError: Cannot destructure property `timeout` of 'undefined' or 'null'.
15:18:28 [Chrome 73.0.3683.75 linux #0-3]     at ItemPage.addMainStatement (/workspace/src/extensions/Wikibase/node_modules/wdio-wikibase/pagesections/main.statement.section.js:63:5)
15:18:28 [Chrome 73.0.3683.75 linux #0-3]     at Context.<anonymous> (/workspace/src/extensions/Wikibase/repo/tests/selenium/specs/readmode.references.js:14:12)
.
.
15:18:28 Spec Files:	 4 passed, 5 failed, 9 total (100% completed) in 00:01:49
16:55:39 [Chrome 73.0.3683.75 linux #0-3] Spec: /workspace/src/extensions/Wikibase/repo/tests/selenium/specs/readmode.references.js
16:55:39 [Chrome 73.0.3683.75 linux #0-3] Running: Chrome (v73.0.3683.75) on linux
16:55:39 [Chrome 73.0.3683.75 linux #0-3] Session ID: 1eb6a192-4fab-4e38-8526-55eda982f0d4
16:55:39 [Chrome 73.0.3683.75 linux #0-3]
16:55:39 [Chrome 73.0.3683.75 linux #0-3] WikibaseReferenceOnProtectedPage
16:55:39 [Chrome 73.0.3683.75 linux #0-3]    ✓ can expand collapsed references on a protected page as unprivileged user
16:55:39 [Chrome 73.0.3683.75 linux #0-3]
16:55:39 [Chrome 73.0.3683.75 linux #0-3] 1 passing (8.6s)
.
.
16:55:39 Spec Files:	 5 passed, 4 failed, 9 total (100% completed) in 00:01:59

Related Objects
Search...

Event Timeline

Vidhi-Mody created this task.Aug 25 2020, 4:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2020, 4:01 PM
Vidhi-Mody triaged this task as Medium priority.Aug 25 2020, 4:02 PM
Vidhi-Mody added projects: Quality-and-Test-Engineering-Team, User-zeljkofilipin, User-Vidhi-Mody.Aug 25 2020, 6:21 PM
zeljkofilipin added a parent task: T255045: Upgrade WebdriverIO in the Wikibase repository.Aug 26 2020, 9:12 AM
zeljkofilipin moved this task from Inbox to Test engineering on the Quality-and-Test-Engineering-Team board.
zeljkofilipin mentioned this in T255045: Upgrade WebdriverIO in the Wikibase repository.
zeljkofilipin moved this task from Backlog 🪒 to Learn/Teach 💡 on the User-zeljkofilipin board.
WMDE-leszek subscribed.Aug 26 2020, 9:17 AM
zeljkofilipin assigned this task to Vidhi-Mody.Aug 26 2020, 9:18 AM
zeljkofilipin moved this task from Backlog to In Progress on the User-Vidhi-Mody board.
zeljkofilipin updated the task description. (Show Details)Aug 26 2020, 9:52 AM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin mentioned this in T247844: Upgrade WebdriverIO to v6 in all repositories.Aug 26 2020, 10:34 AM
zeljkofilipin mentioned this in T255051: Upgrade WebdriverIO in the WikibaseLexeme repository.
zeljkofilipin added a parent task: T255051: Upgrade WebdriverIO in the WikibaseLexeme repository.
Vidhi-Mody updated the task description. (Show Details)Aug 26 2020, 1:50 PM
Vidhi-Mody updated the task description. (Show Details)Aug 28 2020, 9:08 AM
zeljkofilipin removed Vidhi-Mody as the assignee of this task.Aug 28 2020, 9:46 AM
zeljkofilipin moved this task from In Progress to Waiting/Blocked on the User-Vidhi-Mody board.
zeljkofilipin moved this task from Learn/Teach 💡 to Backlog 🪒 on the User-zeljkofilipin board.Sep 9 2020, 8:18 AM
Addshore added a project: Wikidata-Campsite.Sep 15 2020, 8:56 AM
Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
• Pablo-WMDE claimed this task.Oct 9 2020, 3:01 PM
• Pablo-WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
• Pablo-WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
zeljkofilipin moved this task from Backlog 🪒 to Watching 📺 on the User-zeljkofilipin board.Oct 9 2020, 3:18 PM
• Pablo-WMDE added a comment.Oct 12 2020, 8:27 AM

https://github.com/wmde/wdio-wikibase/pull/26

• Pablo-WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 12 2020, 8:27 AM
Vidhi-Mody moved this task from Waiting/Blocked to Backlog on the User-Vidhi-Mody board.Oct 12 2020, 9:40 AM
• toan subscribed.Oct 12 2020, 2:02 PM

All PR:s mentioned here seems to be merged, and the package has been released here https://github.com/wmde/wdio-wikibase/releases/tag/v4.0.1

Can this to be considered done?

• Pablo-WMDE closed this task as Resolved.Oct 13 2020, 9:01 AM
• Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
zeljkofilipin awarded a token.Oct 13 2020, 11:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits