Page MenuHomePhabricator

Cannot rollback to revisions with hidden username/IP
Closed, ResolvedPublic

Description

Author: bdanee88

Description:
If I try to rollback to a version with hidden username/IP, I get the following permission error (even if I am an admin):

You do not have permission to do that, for the following reason:
The last revision by a different user has been deleted

You can see an affected page history here[1].

To reproduce the error, do the following:

  1. Find a page :)
  2. Edit the page logged out
  3. Log in, and edit the page now
  4. Hide the IP of the logged out edit
  5. Try to rollback the logged in edit

The error may occour if you edit with an other account instead of logged out. I haven't tried it.

[1] http://hu.wikipedia.org/w/index.php?title=Szerkeszt%C5%91:Dani/eu&action=history


Version: unspecified
Severity: normal

Details

Reference
bz24154

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:05 PM
bzimport set Reference to bz24154.
bzimport added a subscriber: Unknown Object (MLST).

Permissions error probably has to do with either considering the revision to be deleted even if the text isn't deleted or with not being allowed to grab the username to put in the revert message.

If the diff-text has been deleted, revertion/undoing shouldn't be allowed. but if the IP/date has been hidden it sounds logical to be able to revert to that. Perhaps use the same wfMgs text as when the IP-address is hidden ([[MediaWiki:Revertpage]], [[MediaWiki:Block-log-flags-hiddenname]] )

Reverted edits by Foobar to latest revision by <s>(username hidden)</s>

fixed since r55764, where a new message revertpage-nouser was added.