@DStrine It looks like the previous iframe code (that we switched off due to the cookie bug last month) was detecting whether the donor was using either an Apple tablet or phone OR was wanting to use IDEAL via Adyen and if either of those cases were true we'd redirect the donors to the Adyen's payment pages and not show the iframe. Do we wanna keep that behaviour for the new iframe variant also?

To be clear, if we kept the original behaviour the iframe variant would be ignored even if passed if the donor was using an Apple phone, tablet or they wanted to donate using IDEAL via Adyen

Ok, it looks like we redirect for apple devices as the iframe wasn't working in safari. I guess we could test whether this is still the case and if so, keep the original redirect behaviour for these devices.

Change 626219 had a related patch set uploaded (by Jgleeson; owner: Jgleeson):
[mediawiki/extensions/DonationInterface@master] WIP: Added adyenIframe variant.

https://gerrit.wikimedia.org/r/626219

When testing I was able to get the continue button to show up with the skins but I am getting an error message on continue

Invalid Request
Unfortunately we were unable to process this request.
Perhaps your browser does not accept cookies or the previous page was a saved or cached copy?

Error:
(Note: these error messages are not visible on the live platform)

The redirect flow is working fine and I'm not seeing anything weird in the syslog.

So I tried this locally and it works for me. I wonder if they fix the bug since?

Here's my test

Looks like I hadn't rebased over master when testing previously in the screen capture above which meant I was still seeing the three-step Adyen checkout process. I can confirm after rebasing the patch over latest master I now see the expected two-step process and it completes successfully on my end.

@Cstone did you test the final patch?

I did @mepps the variant in the iframe loads for me but it gives me an error when I try and complete a payment.

My skin codes and browser version match the ones @jgleeson is using and non iframe payments process fine so not sure what is going on with my local setup.

@Cstone could you screenshot and post what you see if you get a chance? thanks!

Okay this is happening when I open the iframe in an incognito window

Change 626219 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Added adyenIframe variant.

https://gerrit.wikimedia.org/r/626219

@DStrine this is now live. I put through a test donation and it worked as expected.

Here is a US payments form link with the variant set: https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&payment_method=cc&recurring=&uselang=en&language=en&currency=USD&amount=10&country=US&ffname=adyen&variant=adyenIframe