Page MenuHomePhabricator

Watchlist Expiry: MobileFrontend and Minerva: No gap between watchlist expiry label and rest of the popup text
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

As a Watchlist Expiry user, I want the "watchlist time period" label to be on a separate line, so that I can clearly and easily read applicable text.

Acceptance Criteria
  • Make "watchlist time period" in a separate line in MobileFrontend and Minerva
What is the problem?

In the watch star popup, there is no gap between the blah and the watchlist expiry label.

For example, it reads:
...have been added to your watchlist permanently.Watchlist time period:
(see screenshot)

It only appears to happen if all the text appears on one line. So, the screen size needs to be wide enough (or the font size small enough) for this to happen.

I have not seen this happen on any phones or tablets I have tested so far (either portrait or landscape orientation). So, it may not affect MobileFrontend in practice, but it will probably affect desktop users of Minerva.

If it wraps, the "Watchlist time period" label appears in its own paragraph (see other screenshot).

Steps to reproduce problem
  1. Visit a page with Minerva skin on (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Conflict-title-0.5674052665883058-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n?useskin=minerva)
  2. Click watch star
Environment

Browser: Firefox, Chromium

Screenshots (if applicable):

Bug appears when all text on one line:

Looks fine when the text is wrapped:

Event Timeline

ARamirez_WMF set the point value for this task to 1.Sep 17 2020, 11:20 PM
ARamirez_WMF moved this task from To Be Estimated/Discussed to Estimated on the Community-Tech board.

Change 628629 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Ensure dropdown label is always on its own line

https://gerrit.wikimedia.org/r/628629

Change 628629 merged by jenkins-bot:
[mediawiki/core@master] Ensure dropdown label is always on its own line

https://gerrit.wikimedia.org/r/628629

Change 628818 had a related patch set uploaded (by MusikAnimal; owner: Samwilson):
[mediawiki/core@REL1_35] Ensure dropdown label is always on its own line

https://gerrit.wikimedia.org/r/628818

Change 628818 merged by jenkins-bot:
[mediawiki/core@REL1_35] Ensure dropdown label is always on its own line

https://gerrit.wikimedia.org/r/628818

The label is now on a newline:

I briefly checked how the popup looked on each of the skins and on mobile.

This change doesn't make a difference if watchlist expiry is disabled.

Test environment: https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (4453d4a) 2020-10-02T06:23:18.

ifried added a subscriber: ifried.

I now see the label on a new line. I tested with Minerva skin on frwiki (see screenshot example below). I'm marking this as Done.