Note: We can find an example of this bottom sheet when someone tries to watch a page when logged off in mobile view. See example below.

Here is some initial conversation that happened about this ticket: https://wikimedia.slack.com/archives/CDG6XHT3Q/p1592851460421300.

Half star can be found at: https://doc.wikimedia.org/oojs-ui/master/demos/?page=icons&theme=wikimediaui&direction=ltr&platform=desktop

We should copy the above Slack conversation to this ticket, if it's useful, because not everyone has access to the WMF Slack workspace.

Change 622203 had a related patch set uploaded (by MusikAnimal; owner: MusikAnimal):
[mediawiki/skins/MinervaNeue@master] Show half star for temporarily watched pages

https://gerrit.wikimedia.org/r/622203

Change 622203 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Show half star for temporarily watched pages

https://gerrit.wikimedia.org/r/622203

Everything in the acceptance criteria should be done, with exception of "The full star becomes half star" as soon as you watch temporarily (T261970). So really the only work I did was to show the half-star on page load accordingly (e.g. watch temporarily, refresh, and you should see a half star).

Change 626531 had a related patch set uploaded (by MusikAnimal; owner: MusikAnimal):
[mediawiki/skins/MinervaNeue@REL1_35] Show half star for temporarily watched pages

https://gerrit.wikimedia.org/r/626531

Change 626531 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@REL1_35] Show half star for temporarily watched pages

https://gerrit.wikimedia.org/r/626531

• The user should be able to still watch a star permanently with existing behavior (i.e., click on star to watch permanently)

Sure.

• The notification at the bottom should be changed to read: The user will first see the following message at the top: [page name] and its talk page have been added to your watchlist permanently

Sure.

• The dropdown should be labeled with "Watchlist time period" and display the following options:
  • Permanent (as default)
  • 1 week
  • 1 month
  • 3 months
  • 6 months

Sure.

Sometimes, if the screen is wide enough or the font small enough, there is no gap between the two sentences, so it reads:
...have been added to your watchlist permanently.Watchlist time period:

I have not seen this happen on any phones or tablets I have tested so far (either portrait or landscape orientation). Still, it affects desktop Minerva as well so raised T262934.

• If a temporary expiry was chosen, the following behavior should occur:
  • The full star becomes half star (covered in T261970)

As Dayllan mentioned, initially the star appears incorrectly oriented:

I also notice that there is no spinning transition when going from permanent to temporary, like there is going from unwatched to permanent (or vice versa). I don't know if that will be covered in T261970 (or if that should be added to the acceptance criteria).

Also, when you first visit a page you are already temporarily watching, the star does not spin like it does when the page is permanently watched. Again, this might be covered in T261970.

• Display a success message: [page name] and its talk page have been added to your watchlist [time period, such as "one week"]

Sure.

• • Adjust the watch state of the page to have an expiry
• If a temporary expiry is not chosen (i.e., the user keeps permanent selection):
  • They will see original message notification
  • The original dismissal behavior of the pop-up should remain in place

It dismisses after ~6 seconds after it was last interacted with (hovering over, selecting expiry, etc.)

It can be dismissed by clicking/tapping on it.

Test environment: various versions of https://en.wikipedia.beta.wmflabs.org, most recent MediaWiki 1.36.0-alpha (1c56c9f) 2020-09-15T01:49:13

Test devices:

• Samsung S9 Chrome
• iPad 7th Safari
• Samsung S4 Chrome (low PPI screen)