Page MenuHomePhabricator

[S] command+click should open image in new tab, not quickview
Closed, ResolvedPublic

Description

The click event is captured and opens quickview, but when I command+click, I explicitly signal that I want it to open in a separate tab.
The event handler should check that KeyboardEvent.metaKey is false before opening clickview - otherwise it should preserve default browser behavior.

Event Timeline

CBogen renamed this task from command+click should open image in new tab, not quickview to [S] command+click should open image in new tab, not quickview.Sep 23 2020, 4:48 PM

Change 644335 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Improve UX when clicking on result

https://gerrit.wikimedia.org/r/644335

Change 644335 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Improve UX when clicking on result

https://gerrit.wikimedia.org/r/644335