Page MenuHomePhabricator

Some SmashPig php classes do not comply with psr-4 autoloading standard
Open, Needs TriagePublic

Description

Spotted while working on T261777, doing a composer update with DonationInterface / mediawiki/vendor fundraising/REL1_35 cause composer update to complain about some PHP classes not conforming with psr-4 autoloading standard.

Can be seen on a dummy change such as https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/629319

An example:

Deprecation Notice: Class SmashPig\PaymentProviders\PayPal\Tests\CaptureIncomingMessageTest located in ./vendor/wikimedia/smash-pig/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201[39;49m

Stack trace:[39;49m
 phar:///usr/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:116[39;49m
 phar:///usr/bin/composer/src/Composer/Autoload/AutoloadGenerator.php:355[39;49m
 phar:///usr/bin/composer/src/Composer/Autoload/AutoloadGenerator.php:341[39;49m
 phar:///usr/bin/composer/src/Composer/Autoload/AutoloadGenerator.php:264[39;49m
 phar:///usr/bin/composer/src/Composer/Installer.php:307[39;49m
 phar:///usr/bin/composer/src/Composer/Command/UpdateCommand.php:163[39;49m
 phar:///usr/bin/composer/vendor/symfony/console/Command/Command.php:245[39;49m
 phar:///usr/bin/composer/vendor/symfony/console/Application.php:835[39;49m
 phar:///usr/bin/composer/vendor/symfony/console/Application.php:185[39;49m
 phar:///usr/bin/composer/src/Composer/Console/Application.php:281[39;49m
 phar:///usr/bin/composer/vendor/symfony/console/Application.php:117[39;49m
 phar:///usr/bin/composer/src/Composer/Console/Application.php:113[39;49m
 phar:///usr/bin/composer/bin/composer:61[39;49m
 /usr/bin/composer:24[39;49m

All affected classes:

SmashPig\PaymentProviders\PayPal\Tests\CaptureIncomingMessageTest./vendor/wikimedia/smash-pig/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
SmashPig\PaymentProviders\Amazon\Tests\RecordPaymentsJobTest./vendor/wikimedia/smash-pig/PaymentProviders/Amazon/Tests/phpunit/RecordPaymentsJobTest.php
SmashPig\PaymentProviders\Amazon\Tests\AuditTest./vendor/wikimedia/smash-pig/PaymentProviders/Amazon/Tests/phpunit/AuditTest.php
SmashPig\PaymentProviders\Amazon\Tests\ApiTest./vendor/wikimedia/smash-pig/PaymentProviders/Amazon/Tests/phpunit/ApiTest.php
SmashPig\PaymentProviders\Amazon\Tests\NormalizeTest./vendor/wikimedia/smash-pig/PaymentProviders/Amazon/Tests/phpunit/NormalizeTest.php
SmashPig\PaymentProviders\Amazon\Tests\ActionsTest./vendor/wikimedia/smash-pig/PaymentProviders/Amazon/Tests/phpunit/ActionsTest.php
SmashPig\PaymentProviders\Adyen\WSDL\NotificationRequest./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/WSDL/Notification.php
SmashPig\PaymentProviders\Adyen\WSDL\NotificationRequestItem./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/WSDL/Notification.php
SmashPig\PaymentProviders\Adyen\WSDL\anyType2anyTypeMap./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/WSDL/Notification.php
SmashPig\PaymentProviders\Adyen\WSDL\entry./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/WSDL/Notification.php
SmashPig\PaymentProviders\Adyen\WSDL\sendNotification./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/WSDL/Notification.php
SmashPig\PaymentProviders\Adyen\WSDL\sendNotificationResponse./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/WSDL/Notification.php
SmashPig\PaymentProviders\Adyen\WSDL\Amount./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/WSDL/Notification.php
SmashPig\PaymentProviders\Adyen\WSDL\ServiceException./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/WSDL/Notification.php
SmashPig\PaymentProviders\Adyen\WSDL\Error./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/WSDL/Notification.php
SmashPig\PaymentProviders\Adyen\WSDL\Type./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/WSDL/Notification.php
SmashPig\PaymentProviders\Adyen\WSDL\ClassMap./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/WSDL/Notification.php
SmashPig\PaymentProviders\Adyen\Test\RequeueMessageTest./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/Tests/phpunit/RequeueMessageTest.php
SmashPig\PaymentProviders\Adyen\Tests\ReportAvailableTest./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/Tests/phpunit/ReportAvailableTest.php
SmashPig\PaymentProviders\Adyen\Tests\PaymentCaptureActionTest./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/Tests/phpunit/PaymentCaptureActionTest.php
SmashPig\PaymentProviders\Adyen\Test\RecordCaptureJobTest./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/Tests/phpunit/RecordCaptureJobTest.php
SmashPig\PaymentProviders\Adyen\Test\CaptureJobTest./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/Tests/phpunit/CaptureJobTest.php
SmashPig\PaymentProviders\Adyen\Test\AuditTest./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/Tests/phpunit/AuditTest.php
SmashPig\PaymentProviders\Adyen\Test\RecurringPaymentTest./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/Tests/phpunit/RecurringPaymentTest.php
SmashPig\PaymentProviders\Adyen\Tests\CaptureResponseActionTest./vendor/wikimedia/smash-pig/PaymentProviders/Adyen/Tests/phpunit/CaptureResponseActionTest.php
SmashPig\PaymentProviders\AstroPay\Test\AuditTest./vendor/wikimedia/smash-pig/PaymentProviders/AstroPay/Tests/phpunit/AuditTest.php
SmashPig\PaymentProviders\AstroPay\Test\NormalizeTest./vendor/wikimedia/smash-pig/PaymentProviders/AstroPay/Tests/phpunit/NormalizeTest.php
SmashPig\PaymentProviders\Ingenico\Tests\Manual\TestCreatePayment./vendor/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/manual/TestCreatePayment.php
SmashPig\PaymentProviders\Ingenico\Tests\AuthenticatorTest./vendor/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/AuthenticatorTest.php
SmashPig\PaymentProviders\Ingenico\Tests\TokenizeRecurringJobTest./vendor/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/TokenizeRecurringJobTest.php
SmashPig\PaymentProviders\Ingenico\Tests\IdealStatusProviderTest./vendor/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/IdealStatusProviderTest.php
SmashPig\PaymentProviders\Ingenico\Tests\BankPaymentProviderTest./vendor/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/BankPaymentProviderTest.php
SmashPig\PaymentProviders\Ingenico\Tests\HostedCheckoutProviderTest./vendor/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/HostedCheckoutProviderTest.php
SmashPig\PaymentProviders\Ingenico\Tests\AuditTest./vendor/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
SmashPig\PaymentProviders\Ingenico\Tests\ApiTest./vendor/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/ApiTest.php
SmashPig\PaymentProviders\Ingenico\Tests\PaymentProviderTest./vendor/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/PaymentProviderTest.php