Broken link in MediaWiki:Rev-deleted-text-permission
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xiplus
	Oct 4 2020, 3:21 AM

Description

If parameter $1 contains whitespace, the link to deletion log will be broken.
For example: https://zh.wikipedia.org/w/index.php?title=Wikipedia_talk:Guestbook_for_non-Chinese_speakers&oldid=62141285&uselang=en
See also: https://zh.wikipedia.org/w/index.php?title=MediaWiki:Rev-deleted-text-permission/en&action=edit

Actual result: This page revision has been deleted. Details can be found in the talk:Guestbook for non-Chinese speakers deletion log.
Expected result: This page revision has been deleted. Details can be found in the deletion log.

Details

	Subject	Repo	Branch	Lines +/-
	Fix links to Special:Log in message rev-deleted-text-permission	mediawiki/core	master	+11 -6

Customize query in gerrit

Related Objects

Mentioned In: T265477: Link to deletion log in message "rev-deleted-text-permission" is broken
Mentioned Here: T196669: The link to deletion log on Special:Undelete sometimes sends to the wrong page

Event Timeline

Xiplus created this task.Oct 4 2020, 3:21 AM

Restricted Application added subscribers: Stang, Aklapper. · View Herald TranscriptOct 4 2020, 3:21 AM

Xiplus updated the task description. (Show Details)Oct 4 2020, 3:23 AM

A regression from fix for T196669

Change 632291 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Fix links to Special:Log in message rev-deleted-text-permission

https://gerrit.wikimedia.org/r/632291

gerritbot added a project: Patch-For-Review.Oct 5 2020, 4:50 PM

Umherirrender claimed this task.Oct 5 2020, 4:53 PM

Umherirrender triaged this task as High priority.

Change 632291 merged by jenkins-bot:
[mediawiki/core@master] Fix links to Special:Log in message rev-deleted-text-permission

https://gerrit.wikimedia.org/r/632291

Umherirrender closed this task as Resolved.Oct 6 2020, 6:29 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Oct 6 2020, 7:03 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 6 2020, 7:11 PM

Umherirrender mentioned this in T265477: Link to deletion log in message "rev-deleted-text-permission" is broken.Oct 14 2020, 5:23 PM

Raymond merged a task: T265477: Link to deletion log in message "rev-deleted-text-permission" is broken.Oct 15 2020, 6:12 AM

Raymond added subscribers: Raymond, Ammarpad, Daimona.