Page MenuHomePhabricator
Create Task
Maniphest T264561

"Auto number headings" preference shouldn't affect edit summary
Closed, ResolvedPublicBUG REPORT
Actions

Description

As a user,
When I have the "Auto number headings" preference enabled,
And I reply to a comment in a section (eg with section title Section title)
The auto numbering should not be included in the summary (i.e. the section name in the summary should be /* Section title */, not /* 10 Section title */ or whatever the number is)

Examples:
http://meta.wikimedia.org/wiki/Special:Diff/20513735 - without the autonumbering
http://meta.wikimedia.org/wiki/Special:Diff/20513737 - with the autonumbering

Details

SubjectRepoBranchLines +/-
Use 'id' attributes rather than heading text for edit autosummariesmediawiki/extensions/DiscussionToolsmaster+27 -6
Remove number when reading heading nodemediawiki/extensions/DiscussionToolsmaster+5 -2
Customize query in gerrit

Event Timeline

DannyS712 created this task.Oct 5 2020, 3:39 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptOct 5 2020, 3:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.Oct 5 2020, 3:39 AM
DannyS712 changed the subtype of this task from "Task" to "Bug Report".
ppelberg subscribed.Oct 5 2020, 4:54 PM
ppelberg added a project: Editing-team (Kanban Board).Oct 5 2020, 5:38 PM
ppelberg moved this task from Incoming to Upcoming on the Editing-team (Kanban Board) board.
gerritbot added a comment.Oct 5 2020, 8:59 PM

Change 632321 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Remove number when reading heading node

https://gerrit.wikimedia.org/r/632321

gerritbot added a project: Patch-For-Review.Oct 5 2020, 8:59 PM
Esanders claimed this task.Oct 5 2020, 9:00 PM
Esanders moved this task from Upcoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Oct 5 2020, 11:22 PM

Change 632321 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Remove number when reading heading node

https://gerrit.wikimedia.org/r/632321

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED).Oct 6 2020, 12:00 AM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 6 2020, 12:10 AM
matmarex edited projects, added Skipped QA; removed Patch-For-Review.
ppelberg closed this task as Resolved.Oct 6 2020, 2:02 AM
gerritbot added a comment.Nov 4 2020, 10:07 PM

Change 639305 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Use 'id' attributes rather than heading text for edit autosummaries

https://gerrit.wikimedia.org/r/639305

gerritbot added a project: Patch-For-Review.Nov 4 2020, 10:07 PM
gerritbot added a comment.Nov 5 2020, 4:00 PM

Change 639305 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Use 'id' attributes rather than heading text for edit autosummaries

https://gerrit.wikimedia.org/r/639305

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits