Page MenuHomePhabricator

The original panel of section translation editor needs adjustment
Closed, ResolvedPublic

Description

Once users edit a sentence in the Section translation mobile editor
(T251928), a panel is shown with the original sentence above the Mobile Visual editor.
When dragging the "original" panel there are some aspects that need adjustment:

  • Currently the panel is expanded with no limit. It is intended to stop expanding once the whole sentence is visible.
  • Dragging it down and up again does not return to the initial state.
  • The up arrow to collapse the panel when it is expanded is expected to be in the same place as the up arrow that allows scrolling.

These are captured in this animation and analyzed in more detail below:

Oct-08-2020 19-06-13.gif (528×316 px, 2 MB)

Current behaviour
Screenshot 2020-10-08 at 19.07.15.png (1×566 px, 80 KB)
Screenshot 2020-10-08 at 19.14.43.png (1×566 px, 79 KB)
Screenshot 2020-10-08 at 19.07.28.png (1×566 px, 80 KB)
The original panel can be expanded with no limits, the "up" arrow changed positionOnce dragged up, only one arrow up is shown. It should return to the initial state instead.
Expected behaviour
Screenshot 2020-10-08 at 19.07.15.png (1×566 px, 80 KB)
Artboard.jpg (1×566 px, 116 KB)
Screenshot 2020-10-08 at 19.07.15.png (1×566 px, 80 KB)

Event Timeline

Screencast of panel maximum expansion after fix

fixed_max_drag.gif (908×426 px, 750 KB)

Screencast of dragging the panel up and down (with navigation arrows returning to their initial state) after fix. The position of up arrow is also fixed as visible in the screencast.

fix_navigation_arrows_after_dragging.gif (908×426 px, 553 KB)

Change 753051 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXEditorOriginalContent SFC: Fix UI issues for original panel

https://gerrit.wikimedia.org/r/753051

Change 753051 merged by Santhosh:

[mediawiki/extensions/ContentTranslation@master] SXEditorOriginalContent SFC: Fix UI issues for original panel

https://gerrit.wikimedia.org/r/753051

Change 758121 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20220131

https://gerrit.wikimedia.org/r/758121

Change 758121 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20220131

https://gerrit.wikimedia.org/r/758121