Page MenuHomePhabricator
Create Task
Maniphest T265778

Make FileBackend code that scrapes PHP warning robust
Closed, ResolvedPublic
Actions

Description

FileBackendIntegrationTest::testGetFileList fails when null is returned instead of [], which happens if the locale in not English. Printing the suppressed PHP warnings, in my case, yields:

"failed to open dir: Aucun fichier ou dossier de ce type"

Details

SubjectRepoBranchLines +/-
Fix English/*nix specific error messages in FSFileBackendmediawiki/coreREL1_31+160 -1
Fix English/*nix specific error messages in FSFileBackendmediawiki/coreREL1_35+58 -11
Fix English/*nix specific error messages in FSFileBackendmediawiki/coremaster+58 -11
Customize query in gerrit

Event Timeline

aaron created this task.Oct 16 2020, 11:50 PM
Restricted Application added a project: Commons. · View Herald TranscriptOct 16 2020, 11:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
aaron added a project: Performance-Team.Oct 20 2020, 7:30 PM
• Gilles moved this task from Inbox, needs triage to Radar on the Performance-Team board.Oct 20 2020, 7:32 PM
• Gilles edited projects, added Performance-Team (Radar); removed Performance-Team.
• Gilles moved this task from Radar to Backlog: Maintenance, non-prioritized on the Performance-Team board.
• Gilles edited projects, added Performance-Team; removed Performance-Team (Radar).
tstarling subscribed.Dec 2 2020, 10:25 PM

Does this happen even if $wgShellLocale is set to the default of C.UTF8? We call setlocale() in Setup.php, and I think it should always be C.UTF8 or en_US.UTF8, there's not much justification for changing it.

tstarling added a comment.Dec 2 2020, 10:35 PM

It's possible to use socket_strerror(SOCKET_ENOENT). A bit of a hack maybe, but it should work, as long as the extension is available.

gerritbot added a comment.Dec 3 2020, 12:06 AM

Change 643605 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/core@master] Fix English/*nix specific error messages in FSFileBackend

https://gerrit.wikimedia.org/r/643605

gerritbot added a project: Patch-For-Review.Dec 3 2020, 12:06 AM
gerritbot added a comment.Dec 6 2020, 1:15 AM

Change 645361 had a related patch set uploaded (by Reedy; owner: Tim Starling):
[mediawiki/core@REL1_35] Fix English/*nix specific error messages in FSFileBackend

https://gerrit.wikimedia.org/r/645361

gerritbot added a comment.Dec 6 2020, 1:15 AM

Change 645362 had a related patch set uploaded (by Reedy; owner: Tim Starling):
[mediawiki/core@REL1_31] Fix English/*nix specific error messages in FSFileBackend

https://gerrit.wikimedia.org/r/645362

gerritbot added a comment.Dec 6 2020, 1:37 AM

Change 643605 merged by jenkins-bot:
[mediawiki/core@master] Fix English/*nix specific error messages in FSFileBackend

https://gerrit.wikimedia.org/r/643605

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 6 2020, 2:00 AM
gerritbot added a comment.Dec 8 2020, 11:37 PM

Change 645361 merged by jenkins-bot:
[mediawiki/core@REL1_35] Fix English/*nix specific error messages in FSFileBackend

https://gerrit.wikimedia.org/r/645361

ReleaseTaggerBot added a project: MW-1.35-notes.Dec 9 2020, 12:00 AM
aaron closed this task as Resolved.Dec 9 2020, 11:02 PM
aaron claimed this task.
In T265778#6665113, @tstarling wrote:

Does this happen even if $wgShellLocale is set to the default of C.UTF8? We call setlocale() in Setup.php, and I think it should always be C.UTF8 or en_US.UTF8, there's not much justification for changing it.

C.UTF8 works fine. As of master, "fr_FR.UTF-8" works fine too.

gerritbot added a comment.Dec 15 2020, 12:51 PM

Change 645362 abandoned by Reedy:
[mediawiki/core@REL1_31] Fix English/*nix specific error messages in FSFileBackend

Reason:

https://gerrit.wikimedia.org/r/645362

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL