Investigate need for &$byref in CRUD and PersistentVisitor
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kalle
	Oct 20 2020, 1:13 PM

Description

Some methods in the CRUD pattern use &$byref function parameters. Do we need all of them?

Details

	Subject	Repo	Branch	Lines +/-
	Remove &$byref from PersistentVisitor functions	mediawiki/extensions/WikispeechSpeechDataCollector	master	+265 -264
	Remove use of &$byref from CRUD	mediawiki/extensions/WikispeechSpeechDataCollector	master	+115 -106

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		kalle	T266004 Investigate need for &$byref in CRUD and PersistentVisitor
		Resolved		kalle	T267116 Implement ApiCRUD, a non secure and generic data modification API.

Event Timeline

kalle created this task.Oct 20 2020, 1:13 PM

Lokal_Profil moved this task from Unsorted to Code hygiene and deployment requirements on the Wikispeech-Speech-Data-Collector board.Oct 29 2020, 8:41 AM

kalle added a project: Technical-Debt.Oct 29 2020, 8:42 AM

kalle set the point value for this task to 4.

kalle moved this task from Incoming to Proposed for next sprint on the Wikispeech-Jobrunner board.Oct 29 2020, 8:59 AM

Lokal_Profil moved this task from Proposed for next sprint to Sprint on the Wikispeech-Jobrunner board.Oct 29 2020, 9:02 AM

Lokal_Profil edited projects, added Wikispeech-Jobrunner (Sprint); removed Wikispeech-Jobrunner.

kalle renamed this task from Investigate need for &$byref in CRUD to Investigate need for &$byref in CRUD and PersistentVisitor.Nov 11 2020, 12:50 PM

DannyS712 awarded a token.Nov 23 2020, 5:06 PM

DannyS712 subscribed.

kalle moved this task from 🥴 Backlog to 🤠 This week on the User-kalle board.Nov 24 2020, 1:30 AM

kalle added a subtask: T267116: Implement ApiCRUD, a non secure and generic data modification API..Nov 25 2020, 11:51 AM

From spending a bit of time testing:

We do need to pass arrays as byref, e.g. in CRUDs when serializing persistent instances to an array which is then sent to the database connection for creating and updating a row. If not, we'll be modifying a new clone of the array which is then thrown away.

We do not need to pass instances of Persistent as byref in order to modify the instance passed down by the caller. This would remove the bulk of all byrefs, e.g. all visitors.

This will be implemented when ApiCRUD is merged.

Change 643508 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/WikispeechSpeechDataCollector@master] Remove use of &$byref from CRUD

https://gerrit.wikimedia.org/r/643508

gerritbot added a project: Patch-For-Review.Nov 25 2020, 3:01 PM

This patch is for CRUD only. PersistentVisitor-refactor will occur in a new patch attached to this task once ApiCRUD has been merged.

kalle moved this task from 🤠 This week to 🤔 Awaits action on the User-kalle board.Nov 25 2020, 3:04 PM

Lokal_Profil moved this task from Backlog to In progress on the Wikispeech-Jobrunner (Sprint) board.Nov 26 2020, 10:06 AM

kalle changed the point value for this task from 4 to 1.Nov 26 2020, 11:07 AM

Change 643508 merged by jenkins-bot:
[mediawiki/extensions/WikispeechSpeechDataCollector@master] Remove use of &$byref from CRUD

https://gerrit.wikimedia.org/r/643508

Maintenance_bot removed a project: Patch-For-Review.Dec 1 2020, 2:10 PM

Change 646972 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/WikispeechSpeechDataCollector@master] Remove &$byref from PersistentVisitor functions

https://gerrit.wikimedia.org/r/646972

gerritbot added a project: Patch-For-Review.Dec 8 2020, 11:45 AM

Change 646972 merged by jenkins-bot:
[mediawiki/extensions/WikispeechSpeechDataCollector@master] Remove &$byref from PersistentVisitor functions

https://gerrit.wikimedia.org/r/646972

Maintenance_bot removed a project: Patch-For-Review.Dec 16 2020, 12:10 PM

Lokal_Profil moved this task from In progress to Done on the Wikispeech-Jobrunner (Sprint) board.Jan 14 2021, 11:17 AM

Lokal_Profil removed the point value for this task.

Lokal_Profil assigned this task to kalle.Jan 14 2021, 12:10 PM

Sebastian_Berlin-WMSE closed this task as Resolved.Jan 14 2021, 12:12 PM

Lokal_Profil closed subtask T267116: Implement ApiCRUD, a non secure and generic data modification API. as Resolved.Mar 11 2021, 12:07 PM