Page MenuHomePhabricator

TemplateData extension should not write objects into ExtensionData
Closed, ResolvedPublic

Description

Instances of PHP classes are not serializable into JSON, so we should not write them into ParserOutput->mExtensionData.

Event Timeline

Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 22 2020, 4:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 636072 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/TemplateData@master] Make extension data JSON-serializable #1 - forward-compat.

https://gerrit.wikimedia.org/r/636072

Change 636076 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/TemplateData@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/636076

Change 636086 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/TemplateData@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/636086

Change 636076 abandoned by Cicalese:
[mediawiki/extensions/TemplateData@master] Make extension data JSON-serializable #2 - write JSON.

Reason:
gerrit rebase confusion

https://gerrit.wikimedia.org/r/636076

Change 636072 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Make extension data JSON-serializable #1 - forward-compat.

https://gerrit.wikimedia.org/r/636072

Change 636086 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/636086

Pchelolo closed this task as Resolved.Wed, Nov 18, 8:02 PM
Pchelolo moved this task from Ready to Deploy to Done on the Platform Team Workboards (Green) board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptWed, Nov 18, 8:02 PM