Page MenuHomePhabricator
Create Task
Maniphest T266252

TemplateData extension should not write objects into ExtensionData
Closed, ResolvedPublic
Actions

Description

Instances of PHP classes are not serializable into JSON, so we should not write them into ParserOutput->mExtensionData.

Details

SubjectRepoBranchLines +/-
Make extension data JSON-serializable #2 - write JSON.mediawiki/extensions/TemplateDatamaster+2 -4
Make extension data JSON-serializable #1 - forward-compat.mediawiki/extensions/TemplateDatamaster+140 -2
Make extension data JSON-serializable #2 - write JSON.mediawiki/extensions/TemplateDatamaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

CCicalese_WMF created this task.Oct 22 2020, 4:28 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 22 2020, 4:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
CCicalese_WMF mentioned this in T264394: Ensure content of ParserOutput is safe to serialize.Oct 22 2020, 4:51 PM
• Pchelolo moved this task from Backlog to Ready on the Platform Team Workboards (Green) board.Oct 23 2020, 2:09 PM
gerritbot added a comment.Oct 23 2020, 5:51 PM

Change 636072 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/TemplateData@master] Make extension data JSON-serializable #1 - forward-compat.

https://gerrit.wikimedia.org/r/636072

gerritbot added a project: Patch-For-Review.Oct 23 2020, 5:51 PM
gerritbot added a comment.Oct 23 2020, 6:55 PM

Change 636076 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/TemplateData@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/636076

gerritbot added a comment.Oct 23 2020, 9:27 PM

Change 636086 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/TemplateData@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/636086

gerritbot added a comment.Oct 23 2020, 9:28 PM

Change 636076 abandoned by Cicalese:
[mediawiki/extensions/TemplateData@master] Make extension data JSON-serializable #2 - write JSON.

Reason:
gerrit rebase confusion

https://gerrit.wikimedia.org/r/636076

• Pchelolo assigned this task to CCicalese_WMF.Oct 23 2020, 11:37 PM
• Pchelolo moved this task from Ready to Waiting for Review on the Platform Team Workboards (Green) board.
• Pchelolo moved this task from Waiting for Review to Ready to Deploy on the Platform Team Workboards (Green) board.Oct 30 2020, 5:13 PM
gerritbot added a comment.Oct 30 2020, 5:56 PM

Change 636072 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Make extension data JSON-serializable #1 - forward-compat.

https://gerrit.wikimedia.org/r/636072

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 30 2020, 6:00 PM
gerritbot added a comment.Nov 10 2020, 1:51 AM

Change 636086 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/636086

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.18; 2020-11-17); removed MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Nov 10 2020, 2:00 AM
• Pchelolo closed this task as Resolved.Nov 18 2020, 8:02 PM
• Pchelolo moved this task from Ready to Deploy to Done on the Platform Team Workboards (Green) board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 18 2020, 8:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits