Clarify dependencies on codehale dropwizards
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	dcausse
	Oct 23 2020, 9:11 AM

Description

As a maintainer of the wdqs streaming updater I want the pipeline to work correctly with different flink metrics plugins being loaded so that I can switch implementation from the flink config file without rebuilding my application.

the streaming-updater-producer project relies on com.codahale.metrics for:

the histogram class in MeasureEventProcessingLatencyOperation
DropwizardToFlinkListener to pass the metrics collected from the rdf components in tools (WikibaseRepository) to the flink MetricRegistry

Currently it seems that the pipeline relies on the flink-metrics-graphite plugin being loaded to make the dropwizards deps available.
Running without it it seems to fail with:

Caused by: java.lang.NoClassDefFoundError: com/codahale/metrics/Reservoir
	at org.wikidata.query.rdf.updater.UpdaterPipeline$.measureLatency(UpdaterPipeline.scala:154)

AC:

the pipeline should be runable without the flink-metrics-graphite plugin being loaded

Details

	Subject	Repo	Branch	Lines +/-
	Add explicit codehale metrics dependency	wikidata/query/rdf	master	+4 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Gehel	T244590 [Epic] Rework the WDQS updater as an event driven application
		Resolved		• Zbyszko	T266318 Clarify dependencies on codehale dropwizards

Event Timeline

dcausse created this task.Oct 23 2020, 9:11 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 23 2020, 9:11 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

dcausse updated the task description. (Show Details)Oct 23 2020, 10:00 AM

dcausse added a parent task: T244590: [Epic] Rework the WDQS updater as an event driven application.

CBogen moved this task from Incoming to Current work on the Wikidata-Query-Service board.Oct 26 2020, 4:40 PM

CBogen added a project: Discovery-Search (Current work).

CBogen set the point value for this task to 3.Oct 26 2020, 6:45 PM

CBogen moved this task from Incoming to Ready for Dev -- SWE on the Discovery-Search (Current work) board.

• Zbyszko claimed this task.Oct 26 2020, 6:52 PM

• Zbyszko moved this task from Ready for Dev -- SWE to In Progress on the Discovery-Search (Current work) board.Oct 27 2020, 9:48 AM

Change 636667 had a related patch set uploaded (by ZPapierski; owner: ZPapierski):
[wikidata/query/rdf@master] Add explicit codehale metrics dependency

https://gerrit.wikimedia.org/r/636667

gerritbot added a project: Patch-For-Review.Oct 27 2020, 2:30 PM

After investigation I found that most metric plugins do not shade in codehale metrics; graphite plugin does this because it actually uses them in the code (other reporters access flink provided abstraction). Since it is the exception, I decided to shade in the dependency.

• Zbyszko moved this task from In Progress to Needs review on the Discovery-Search (Current work) board.Oct 27 2020, 2:32 PM

Change 636667 merged by jenkins-bot:
[wikidata/query/rdf@master] Add explicit codehale metrics dependency

https://gerrit.wikimedia.org/r/636667

Maintenance_bot removed a project: Patch-For-Review.Oct 27 2020, 4:10 PM

• Zbyszko moved this task from Needs review to To Be Deployed on the Discovery-Search (Current work) board.Nov 2 2020, 6:04 PM

Mstyles moved this task from To Be Deployed to Needs Reporting on the Discovery-Search (Current work) board.Nov 5 2020, 12:45 AM

Gehel closed this task as Resolved.Nov 9 2020, 12:55 PM