Page MenuHomePhabricator

Drop default of protected_titles.pt_expiry
Closed, ResolvedPublic

Description

Part of T42626: Standardise type of timestamp database fields (MySQL) and T230428: Migrate tables.sql to abstract schema

  1. ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/636557/5/maintenance/archives/patch-protected_titles-pt_expiry-drop-default.sql
  2. Where to run those changes: all.dblist
  3. When to run those changes: At any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: Tested in beta cluster. Queried the whole content and nothing has the default value.
  6. if the data should be made available on the labs replicas and/or dumps: Yes, data in this table is public.

Progress

  • s10
    • eqiad
    • codfw
  • labtestwiki (clouddb2001-dev)

Event Timeline

Marostegui moved this task from Triage to Ready on the DBA board.

It can be done ONLINE, so no master failover is required

MariaDB [test]> ALTER TABLE /*_*/protected_titles ALTER pt_expiry DROP DEFAULT, ALGORITHM=INPLACE, LOCK=NONE;
Query OK, 0 rows affected (0.00 sec)
Records: 0  Duplicates: 0  Warnings: 0
Marostegui moved this task from Ready to In progress on the DBA board.
Marostegui updated the task description. (Show Details)

@Ladsgroup do you have the gerrit URL for this patch? The above gives 404.

@Ladsgroup do you have the gerrit URL for this patch? The above gives 404.

Updated to gerrit link.

s6 progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1005
  • db2141
  • db2129
  • db2124
  • db2117
  • db2114
  • db2097
  • db2095
  • db2089
  • db2087
  • db2076
  • db1140
  • db1139
  • db1131
  • db1125
  • db1113
  • db1098
  • db1096
  • db1093
  • db1088
  • db1085

I have deployed this change to db2089:3316 and I will leave it a couple of days to make sure nothing breaks, replication-wise.

# for i in `cat /home/marostegui/git/mediawiki-config/dblists/s6.dblist | grep -v "#"`; do echo $i; mysql.py -hdb2087:3316 $i -e "show create table protected_titles\G" | grep pt_expiry ;done
frwiki
  `pt_expiry` varbinary(14) NOT NULL DEFAULT '',
jawiki
  `pt_expiry` varbinary(14) NOT NULL DEFAULT '',
ruwiki
  `pt_expiry` varbinary(14) NOT NULL DEFAULT '',

Deployed on db1098:3316 - will leave it for a day to make sure nothing reads-related are affected by this change

s5 progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1003
  • db1150
  • db1145
  • db1144
  • db1130
  • db1124
  • db1113
  • db1110
  • db1100
  • db1096
  • db1082

s2 progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1004
  • db1146
  • db1129
  • db1125
  • db1122
  • db1105
  • db1095
  • db1090
  • db1076
  • db1074

s4 progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1004
  • db1150
  • db1149
  • db1148
  • db1147
  • db1146
  • db1145
  • db1144
  • db1143
  • db1142
  • db1141
  • db1138
  • db1125
  • db1121
  • db1081

Mentioned in SAL (#wikimedia-operations) [2020-11-23T12:53:45Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1141 for schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13367 and previous config saved to /var/cache/conftool/dbconfig/20201123-125345-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-23T12:54:17Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repool db1141 after schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13368 and previous config saved to /var/cache/conftool/dbconfig/20201123-125417-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-23T12:57:59Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1143 for schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13369 and previous config saved to /var/cache/conftool/dbconfig/20201123-125759-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-23T12:58:16Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repool db1143 after schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13370 and previous config saved to /var/cache/conftool/dbconfig/20201123-125815-marostegui.json

s7 progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1003
  • db1136
  • db1127
  • db1125
  • db1116
  • db1101
  • db1098
  • db1094
  • db1090
  • db1086
  • db1079

s8 progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1005
  • db1126
  • db1124
  • db1116
  • db1114
  • db1111
  • db1109
  • db1104
  • db1101
  • db1099
  • db1092
  • db1087

s1 eqiad progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1003
  • db1140
  • db1139
  • db1135
  • db1134
  • db1124
  • db1119
  • db1118
  • db1106
  • db1105
  • db1099
  • db1089
  • db1084
  • db1083
  • clouddb1017
  • clouddb1013

s3 eqiad progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1004
  • db1124
  • db1123
  • db1112
  • db1095
  • db1078
  • db1075
  • clouddb1017
  • clouddb1013

Mentioned in SAL (#wikimedia-operations) [2020-11-24T07:22:50Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1075 for schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13373 and previous config saved to /var/cache/conftool/dbconfig/20201124-072249-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-24T07:27:15Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repool db1075 after schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13374 and previous config saved to /var/cache/conftool/dbconfig/20201124-072715-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-24T07:27:55Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1078 for schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13375 and previous config saved to /var/cache/conftool/dbconfig/20201124-072755-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-24T07:31:26Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repool db1078 after schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13376 and previous config saved to /var/cache/conftool/dbconfig/20201124-073125-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-24T07:32:02Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1112 for schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13377 and previous config saved to /var/cache/conftool/dbconfig/20201124-073202-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-24T07:43:43Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repool db1112 after schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13378 and previous config saved to /var/cache/conftool/dbconfig/20201124-074342-marostegui.json

Marostegui updated the task description. (Show Details)

This is all done