Related Objects
- Mentioned In
- T267561: Beta needs to be upgraded to Varnish 6
T264991: Upgrade the MediaWiki servers to ICU 63
T267578: Puppet disabled in beta cluster varnish deployment-cache-text06
T215217: deployment-prep (beta cluster): Code stewardship request
T267435: Beta cluster seems to be extremely slow for logged in user during page navigation - Mentioned Here
- rOPUPc871b021a441: confd: pass srv_dns directly instead of loading confd::srv_dns
Event Timeline
Noticed that puppet stopped running on beta's deployment-cache-text06 due to c871b021a44108bed44cd044f5177b075ecb322c
After attempting a fix (live hack on deployment-puppetmaster04 changing:
- Stdlib::Fqdn $srv_dns = $facts['domain'], + String $srv_dns = $::domain,
I kept seeing Abandoned VSM file (Varnish not running?) /var/lib/varnish/frontend/_.vsm
Decided to try to restart the varnish-frontend service following a puppet run, but it looks like the vcc compiler is failing:
Incompatible VMOD netmapper
File name: /usr/lib/x86_64-linux-gnu/varnish/vmods/libvmod_netmapper.so
VMOD version 7.1
varnishd version 6.0
('/etc/varnish/wikimedia_misc-frontend.vcl' Line 13 Pos 8)
import netmapper;
-------#########-
Running VCC-compiler failed, exited with 2
VCL compilation failedUnbreaking puppet seems to have unleashed some interesting behavior: varnish-modules was removed, and libvmod_netmapper was upgraded to an incompatible version.
apt-get install libvmod-netmapper=1.7-3 apt-get install varnish-modules
Was enough to get back to just slightly broken.
I'm curious if this change made any difference? as i dont think it should (but there could be something with horizons backed which im not familiar with)
I notice that in horizon you set the value of srv_dns to an empty string. However when with the change above i updated things to pass the value directly from profile::conftool::state unless im miss remembering (or puppet changed things) values passed directly like this will always have precedence over anything set hiera (and horizon in this case) as such i wouldn;t expect the above change to have had any impact.
All that aside what is the desired outcome, ultimatly the only place this variable gets used is in the ExecStart on the init script
Environment="CONFD_DISCOVERY=-srv-domain <%= @srv_dns %> -scheme <%= @scheme %>
so an empty value will render as -srv-domain -schema $https which looks like an invalid configuration but im not familiar enough with confd to know what affect this has. Either way if you let me know what you ultimately want to end up in the initi script i can update puppet to comply