Page MenuHomePhabricator
Create Task
Maniphest T268060

Unable to view and navigate images on certain pages in MultimediaViewer: TypeError: Cannot read property 'protocol' of undefined
Closed, DuplicatePublic
Actions

Description

VM204:212 Uncaught TypeError: Cannot read property 'protocol' of undefined
    at new Uri (<anonymous>:212:538)
    at ViewLogger.VL.recordViewDuration (VM208 load.php:3)
    at VM208 load.php:4
    at dispatch (VM199 load.php:69)
    at elemData.handle (VM199 load.php:66)
  • Click on map in top right corner
  • Press "right" arrow
Uncaught TypeError: Cannot read property 'protocol' of undefined
    at new Uri (<anonymous>:212:538)
    at ViewLogger.VL.recordViewDuration (load.php?lang=en&modules=mmv&skin=vector&version=1e2u5:3)
    at MultimediaViewer.MMVP.loadIndex (load.php?lang=en&modules=mmv&skin=vector&version=1e2u5:106)
    at MultimediaViewer.MMVP.nextImage (load.php?lang=en&modules=mmv&skin=vector&version=1e2u5:106)
    at LightboxInterface.OO.EventEmitter.emit (<anonymous>:250:483)
    at CanvasButtons.OO.EventEmitter.emit (<anonymous>:250:483)
    at HTMLButtonElement.<anonymous> (load.php?lang=en&modules=mmv&skin=vector&version=1e2u5:57)
    at HTMLButtonElement.dispatch (load.php?lang=en&modules=jquery&skin=vector&version=tqh7e:69)
    at HTMLButtonElement.elemData.handle (load.php?lang=en&modules=jquery&skin=vector&version=tqh7e:66)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Catch malformed URIsmediawiki/extensions/MultimediaViewermaster+8 -3
url-encode page uri before starting the view duration timermediawiki/extensions/MultimediaViewermaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Nov 17 2020, 7:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2020, 7:08 PM
Jdlrobson mentioned this in T106244: URL encoded values using fallback 8-bit encoding (invalid UTF-8) cause mediawiki.Uri to crash.Nov 17 2020, 7:56 PM
Krinkle subscribed.Nov 24 2020, 1:44 AM

Usually these are due to manual writing of bad URLs or due to broken user scripts creating bad URLs. But, in this case it is not.

I can confirm that when reading this article normally (no fragment), and then clicking on the second image, it fails the same way.

This means MediaViewer itself is creating these URLs in an invalid way, not escaping them correctly. That probably causes other issues as well, but none as obvious/easy to find as this one.

Krinkle added a project: Structured Data Engineering.Nov 24 2020, 1:46 AM
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptNov 24 2020, 1:46 AM
Krinkle moved this task from Untriaged to Nov 2020 on the Wikimedia-production-error board.Nov 24 2020, 1:46 AM
Aklapper renamed this task from Unable to view and navigate images on certain pages in MultimediaViewer without error to Unable to view and navigate images on certain pages in MultimediaViewer: TypeError: Cannot read property 'protocol' of undefined.Nov 24 2020, 7:23 AM
CBogen moved this task from Triage to Multimedia on the Structured-Data-Backlog board.Nov 24 2020, 2:38 PM
Jdlrobson triaged this task as High priority.Dec 3 2020, 11:20 PM

URI encoding errors originating from multimedia viewer account from one our top ten errors (URIError: malformed URI sequence + Uncaught URIError: URI malformed) so marking this as high.
There is a danger these errors will increase as we roll out error logging to more of our sites.

MarkTraceur subscribed.Dec 7 2020, 5:33 PM

Managed to find that, at least on simple.wikipedia.org, the URL in question is "/beacon/media", which is being passed into the mw.Uri constructor unmolested. Not terribly ideal, so I suppose we should de-relativize it before passing it into mw.Uri. Might be a nice-to-have if mw.Uri handled relative URLs in the future but I think hardly a necessity.

Indeed, it seems this value is the default, and no overrides are set in the wmf-config files, so rolling out logging will likely flood us with errors.

I'll shop this around a little bit and see what we can do on the not-multimedia team, though our time seems to be at more and more of a premium lately.

MarkTraceur added a comment.Dec 7 2020, 6:08 PM

Ignore the above, it was typed when I had but dreamt of having my morning coffee.

The malformed URI error occurs when parsing location.href to get the default URI for handling relative URLs, which mw.Uri does just fine as long as we aren't passing it a default URI that has an unescaped percent sign ('%') in it, I imagine.

So yeah, as Krinkle says, we have some escaping to do in MMV, sorry about pointing the finger at the wrong code there.

gerritbot added a comment.Dec 10 2020, 12:23 PM

Change 647676 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/MultimediaViewer@master] url-encode page uri before starting the view duration timer

https://gerrit.wikimedia.org/r/647676

gerritbot added a project: Patch-For-Review.Dec 10 2020, 12:23 PM
gerritbot added a comment.Dec 10 2020, 2:52 PM

Change 647676 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] url-encode page uri before starting the view duration timer

https://gerrit.wikimedia.org/r/647676

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 10 2020, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 10 2020, 3:10 PM
Jdlrobson added a comment.Dec 10 2020, 9:59 PM

Thanks for looking into this one!

Krinkle mentioned this in T269948: CentralNotice throws exception on malformed URIs.Dec 15 2020, 7:24 PM
Jdlrobson added projects: JavaScript, patch-welcome.Feb 8 2021, 7:42 PM
matmarex mentioned this in T275799: mw.Uri cannot be called on subpages (TypeError: Cannot read property 'protocol' of undefined).Feb 25 2021, 5:53 PM
matmarex closed this task as a duplicate of T207365: URL with % in fragment breaks scripts that use mw.Uri.
gerritbot added a comment.Mar 4 2021, 5:12 PM

Change 668495 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MultimediaViewer@master] Catch malformed URIs

https://gerrit.wikimedia.org/r/668495

gerritbot added a project: Patch-For-Review.Mar 4 2021, 5:12 PM
gerritbot added a comment.Mar 4 2021, 6:22 PM

Change 668495 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Catch malformed URIs

https://gerrit.wikimedia.org/r/668495

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.34; 2021-03-09); removed MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Mar 4 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 4 2021, 7:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits