Fetch mwdebug backend server list from noc.wikimedia.org
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Nov 18 2020, 7:46 PM

Description

@bd808 wrote 22 Nov 2016:

Read https://noc.wikimedia.org/conf/debug.json to get the list of backend servers that can be selected.

Imported from https://github.com/wikimedia/WikimediaDebug/issues/7

Details

Subject	Repo	Branch	Lines +/-
background: Only fetch backends when opening popup	performance/WikimediaDebug	master	+34 -11
Fetch debug server list from noc.wikimedia.org	performance/WikimediaDebug	master	+8 -17
Allow CORS requests to noc.wikimedia.org	operations/puppet	production	+5 -0
Add mwdebug1003 to list of debug servers	operations/mediawiki-config	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T274026: Add 3 new canaries to WikimediaDebug
Mentioned Here: T274023: Convert mwdebug VMs to debian buster
T274026: Add 3 new canaries to WikimediaDebug
T245552: noc.wikimedia.org with X-Wikimedia-Debug routes to mwdebug but host is not served there

Event Timeline

Krinkle created this task.Nov 18 2020, 7:46 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptNov 18 2020, 7:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Krinkle wrote 28 Nov 2019:
We'll need to allow this file to be publicly fetched across origins:
fetch('https://noc.wikimedia.org/conf/debug.json').then(r=>r.json()).then(console.log)
Access to fetch at 'https://noc.wikimedia.org/conf/debug.json' from origin 'https://en.wikipedia.org' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

Krinkle added a project: serviceops.Nov 18 2020, 7:49 PM

Krinkle added subscribers: • wkandek, Dzahn.

• Gilles claimed this task.Nov 24 2020, 8:04 PM

• Gilles triaged this task as Low priority.

• Gilles moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Nov 30 2020, 9:27 AM

Change 644229 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/mediawiki-config@master] Add mwdebug1003 to list of debug servers

https://gerrit.wikimedia.org/r/644229

gerritbot added a project: Patch-For-Review.Nov 30 2020, 1:09 PM

Change 644229 merged by jenkins-bot:
[operations/mediawiki-config@master] Add mwdebug1003 to list of debug servers

https://gerrit.wikimedia.org/r/644229

Mentioned in SAL (#wikimedia-operations) [2020-11-30T13:16:10Z] <gilles@deploy1001> Synchronized debug.json: T268167 Add mwdebug1003 to list of debug servers (duration: 00m 56s)

Change 644230 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/puppet@production] Allow CORS requests to noc.wikimedia.org

https://gerrit.wikimedia.org/r/644230

Change 644233 had a related patch set uploaded (by Gilles; owner: Gilles):
[performance/WikimediaDebug@master] Fetch debug server list from noc.wikimedia.org

https://gerrit.wikimedia.org/r/644233

• Gilles moved this task from Backlog: Maintenance, non-prioritized to Doing (old) on the Performance-Team board.Nov 30 2020, 1:49 PM

Change 644230 merged by CDanis:
[operations/puppet@production] Allow CORS requests to noc.wikimedia.org

https://gerrit.wikimedia.org/r/644230

Change 644233 merged by jenkins-bot:
[performance/WikimediaDebug@master] Fetch debug server list from noc.wikimedia.org

https://gerrit.wikimedia.org/r/644233

Maintenance_bot removed a project: Patch-For-Review.Dec 1 2020, 11:10 PM

Krinkle closed this task as Resolved.Dec 2 2020, 12:23 AM

Didn't test this enough, it's actually blocked by T245552: noc.wikimedia.org with X-Wikimedia-Debug routes to mwdebug but host is not served there. As soon as you pick a debug server from the extension and reload the page, opening the extension again will fail, as the attempt to fetch the server list from noc.wikimedia.org errors.

I am tempted to close this as invalid, as with the upcoming move to kubernetes we will have to rethink the debug extension deeply, and a list of servers will not have much meaning.

The code is already there. We are still getting requests to update that list in the current reality: T274026: Add 3 new canaries to WikimediaDebug

In T268167#6817859, @Gilles wrote:

The code is already there. We are still getting requests to update that list in the current reality: T274026: Add 3 new canaries to WikimediaDebug

No you didn't, or better - it's not needed, see https://phabricator.wikimedia.org/T274023#6809729 for instance.

But, I thought the code was still to be deployed/tested, and I was saying it would probably be a waste of your time doing so.

If the issue is with X-Wikimedia-Debug routing at the edge, though, (if I understood correctly what is missing) I'd suggest reaching out to the traffic team.

The new version of the WikimediaDebug extension is good to do, we just have to tag and push a new version which takes a few minutes. It's just T245552 that needs to be fixed before we do. For which I've just filed a patch: https://gerrit.wikimedia.org/r/c/operations/puppet/+/663156/

Krinkle closed this task as Resolved.Feb 16 2021, 8:01 PM

Krinkle mentioned this in T274026: Add 3 new canaries to WikimediaDebug.

Change 719143 had a related patch set uploaded (by Krinkle; author: Krinkle):

[performance/WikimediaDebug@master] background: Only fetch backends when opening popup

https://gerrit.wikimedia.org/r/719143

gerritbot added a project: Patch-For-Review.Sep 7 2021, 5:47 PM

Change 719143 merged by jenkins-bot: