Page MenuHomePhabricator

Parsoid incorrectly "recovered trimmed whitespace" on intermediate text nodes of an edited list item
Closed, ResolvedPublicBUG REPORT

Description

Original report: https://cs.wikipedia.org/w/index.php?title=Wikipedie:Pod_l%C3%ADpou_(technika)&oldid=19196135#Oprava_spojovn%C3%ADk%C5%AF_na_poml%C4%8Dky

Steps to Reproduce:

  1. Edit the following sample wikitext with visual editor (the separators are hyphens):
* [[1911]]-[[2088]]
* [[1947]]-[[2044]]
* [[1949]]-[[2054]]
* [[1920]]-[[2015]]
* [[1999]]-[[2010]]
  1. Replace some hyphens (e.g., the first three) with en-dash (–) using find and replace.
  2. Remove other hyphens and insert en-dash manually.
  3. Switch to wikitext editor and check the diff.

Actual Results:

  • Before each en-dash, an additional space was inserted.
    • Happens in the old wikitext editor as well as 2017 wikitext editor.

Expected Results:

  • No superfluous spaces are inserted.

Video demonstrating the problem (author Wikipedia user "David V."):

Event Timeline

matmarex subscribed.

May be a Parsoid issue related to recent changes about whitespace preservation in lists?

Change 643527 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Selser: Fix incorrect recovery of trimmed whitespace

https://gerrit.wikimedia.org/r/643527

ssastry renamed this task from Visual editor inserts space when replacement is done on a link boundary to Parsoid incorrectly adds "recovered trimmed whitespace" on intermediate text nodes of an edited list item.Nov 25 2020, 5:17 PM
ssastry claimed this task.
ssastry triaged this task as Medium priority.
ssastry subscribed.

Change 643527 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Selser: Fix incorrect recovery of trimmed whitespace

https://gerrit.wikimedia.org/r/643527

Change 644393 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a18

https://gerrit.wikimedia.org/r/644393

Change 644221 had a related patch set uploaded (by C. Scott Ananian; owner: Subramanya Sastry):
[mediawiki/vendor@wmf/1.36.0-wmf.20] Bump wikimedia/parsoid to 0.13.0-a18

https://gerrit.wikimedia.org/r/644221

Change 644393 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a18

https://gerrit.wikimedia.org/r/644393

Change 644221 merged by jenkins-bot:
[mediawiki/vendor@wmf/1.36.0-wmf.20] Bump wikimedia/parsoid to 0.13.0-a18

https://gerrit.wikimedia.org/r/644221

ssastry renamed this task from Parsoid incorrectly adds "recovered trimmed whitespace" on intermediate text nodes of an edited list item to Parsoid incorrectly "recovered trimmed whitespace" on intermediate text nodes of an edited list item.Dec 9 2020, 2:34 PM
ssastry closed this task as Resolved.