Check for location in IPInfo widget before appending paragraph
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	Nov 25 2020, 2:40 PM

Description

Following T268531: Check if `asn` value exists before attempting to display it in IPInfo, the HTML inside the IPInfo popup is something like this, when there is no ASN:

<p class="ext-ipinfo-widget-location">Saint Paul, Minnesota</p>
<p class="ext-ipinfo-widget-source">Source: GeoIp2</p>

However, when there are no locations there is an empty paragraph instead:

<p class="ext-ipinfo-widget-location"></p>
<p class="ext-ipinfo-widget-asn">UMN-SYSTEM</p>
<p class="ext-ipinfo-widget-source">Source: GeoIp2</p>

We shouldn't append the .ext-ipinfo-widget-location paragraph if there are no locations.

Details

	Subject	Repo	Branch	Lines +/-
	Don't append empty paragraph in widget if location is unavailable	mediawiki/extensions/IPInfo	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T268531: Check if `asn` value exists before attempting to display it in IPInfo

Event Timeline

Tchanders created this task.Nov 25 2020, 2:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2020, 2:40 PM

Tchanders claimed this task.Nov 25 2020, 2:40 PM

Change 643507 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/IPInfo@master] Don't append empty paragraph in widget if location is unavailable

https://gerrit.wikimedia.org/r/643507

gerritbot added a project: Patch-For-Review.Nov 25 2020, 2:48 PM

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Nov 25 2020, 2:49 PM

STran moved this task from Code Review 🔍 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.Nov 30 2020, 8:04 AM

Change 643507 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Don't append empty paragraph in widget if location is unavailable

https://gerrit.wikimedia.org/r/643507

Maintenance_bot removed a project: Patch-For-Review.Nov 30 2020, 8:10 AM

@Prtksxna Just drawing your attention to this. Similar to T268531: Check if `asn` value exists before attempting to display it in IPInfo, the location isn't always there.

Tchanders closed this task as Resolved.Dec 3 2020, 1:21 PM

Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:59 PM

Check for location in IPInfo widget before appending paragraphClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Check for location in IPInfo widget before appending paragraph
Closed, ResolvedPublic
Actions