Image in table cell previewed at wrong aspect ratio after being swapped out
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Esanders
	Nov 30 2020, 8:05 PM

Description

Swapping out an image, then viewing the visual diff, resulted in the new image being previewed at the dimensions of the old image:

(The image dimensions render correctly in historical mode: https://en.wikipedia.org/w/index.php?title=Christmas_pudding&type=revision&diff=991578454&oldid=991324008&diffmode=visual)

Testing

Edit this page in VE: https://en.wikipedia.beta.wmflabs.org/wiki/User:ESanders_(WMF)/sandbox/image?veaction=edit
Open the image edit dialog for the image (double click on the table cell, then double click on the image
Click "Change image" at the bottom
Search for "christmas pudding heston" and c

hoose the first result (a tall/portrait photo of a christmas pudding), click "Use this image" and "Apply changes"

Click "Publish changes..." then "Review your changes" in the save dialog to view the visual diff

Observed

The image is shown stretched to fit the dimensions of the old image (see screenshot above)

Expected

The image is shown in the correct aspect ratio:

Details

	Subject	Repo	Branch	Lines +/-
	Image model: Clear originalWidth/originalHeight attributes when changing source	mediawiki/extensions/VisualEditor	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned Here: T158445: VisualDiff: Handle table diffs separately

Event Timeline

• Esanders created this task.Nov 30 2020, 8:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2020, 8:05 PM

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Dec 1 2020, 4:21 PM

• Esanders updated the task description. (Show Details)Dec 2 2020, 6:50 PM

• Esanders updated the task description. (Show Details)Dec 2 2020, 6:52 PM

• Esanders updated the task description. (Show Details)Jan 17 2022, 3:01 PM

• Esanders updated the task description. (Show Details)Jan 17 2022, 3:39 PM

Change 754530 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Image model: Clear originalWidth/originalHeight attributes when changing source

https://gerrit.wikimedia.org/r/754530

gerritbot added a project: Patch-For-Review.Jan 17 2022, 3:40 PM

There is a separate issue of the old image not being shown (we should show the old image in red, and the new image in green) - but that will be resolved by our changes to table diffs: T158445

• Esanders moved this task from Backlog to In progress on the VisualEditor-VisualDiffs board.Jan 19 2022, 1:40 AM

Change 754530 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Image model: Clear originalWidth/originalHeight attributes when changing source

https://gerrit.wikimedia.org/r/754530

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 21 2022, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 21 2022, 1:10 AM

matmarex added a project: Editing-team (Kanban Board).Jan 21 2022, 1:12 AM

matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.

matmarex added a project: Editing QA.

matmarex moved this task from Inbox to Low Priority on the Editing QA board.

Image is shown in the correct ratio as expected in the save dialog

The diff page as well

Screenshot 2022-01-28 at 03.02.39.png (706×1 px, 85 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Jan 28 2022, 2:06 AM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

ppelberg closed this task as Resolved.Jan 29 2022, 1:22 AM

ppelberg claimed this task.

	F34933635: Screenshot 2022-01-28 at 03.03.45.png
	Jan 28 2022, 2:06 AM

	F34933633: Screenshot 2022-01-28 at 03.02.39.png
	Jan 28 2022, 2:06 AM

	F33932362: image.png
	Dec 2 2020, 6:50 PM

Image in table cell previewed at wrong aspect ratio after being swapped outClosed, ResolvedPublicActions