Page MenuHomePhabricator

Add ISP info to IPInfo API response
Closed, ResolvedPublic3 Estimated Story PointsDec 15 2020

Description

Goal

This task is to add the ISP information to the API response

image.png (648ร—1 px, 129 KB)

It will be displayed in the information box in T269766: Display the new pieces of information in the Special:Contributions infobox.

Details

Event Timeline

Niharika triaged this task as Medium priority.Dec 2 2020, 5:45 PM
Niharika created this task.
Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptDec 2 2020, 5:45 PM
ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".

Change 647057 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/IPInfo@master] Add ISP to the returned data for an IP address

https://gerrit.wikimedia.org/r/647057

Change 647057 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Add ISP to the returned data for an IP address

https://gerrit.wikimedia.org/r/647057

Niharika renamed this task from Add ISP/Domain info to IP Information box to Add ISPinfo to IP Information box.Dec 9 2020, 3:52 PM
Niharika updated the task description. (Show Details)

Note that I've split out the Domain information to be added in this task instead: T269767: Add Domain info to the IP Information box

Tchanders renamed this task from Add ISPinfo to IP Information box to Add ISP info to IPInfo API response.Dec 9 2020, 5:22 PM
Tchanders updated the task description. (Show Details)
dom_walden added a subscriber: dom_walden.

The API now returns an entry for "ISP". However, the GeoLite2 database we are testing with does not contain any ISP information, so it will always just return isp: null.

There isn't much I can do to test this at the moment.