Add ISP info to IPInfo API response
Closed, ResolvedPublic3 Estimated Story PointsDec 15 2020
Actions

Assigned To

Authored By

	• Niharika
	Dec 2 2020, 5:45 PM

Description

Goal

This task is to add the ISP information to the API response

It will be displayed in the information box in T269766: Display the new pieces of information in the Special:Contributions infobox.

Details

Due Date: Dec 15 2020, 5:00 AM

	Subject	Repo	Branch	Lines +/-
	Add ISP to the returned data for an IP address	mediawiki/extensions/IPInfo	master	+63 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T285977 IP Info
Open		None	T287647 IP Information accordion on Special:Contribs
Resolved	Dec 15 2020	Tchanders	T269267 Add ISP info to IPInfo API response

Event Timeline

• Niharika triaged this task as Medium priority.Dec 2 2020, 5:45 PM

• Niharika created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2020, 5:45 PM

• Niharika set the point value for this task to 3.Dec 2 2020, 5:56 PM

• Niharika moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

• Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Dec 2 2020, 6:00 PM

• Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

ARamirez_WMF set Due Date to Dec 15 2020, 5:00 AM.Dec 2 2020, 6:05 PM

ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".

Tchanders claimed this task.Dec 7 2020, 4:29 PM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 647057 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/IPInfo@master] Add ISP to the returned data for an IP address

https://gerrit.wikimedia.org/r/647057

gerritbot added a project: Patch-For-Review.Dec 8 2020, 8:45 PM

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Dec 8 2020, 9:10 PM

Change 647057 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Add ISP to the returned data for an IP address

https://gerrit.wikimedia.org/r/647057

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 9 2020, 6:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2020, 6:10 AM

Tchanders mentioned this in T269766: Display the new pieces of information in the Special:Contributions infobox.Dec 9 2020, 3:49 PM

Note that I've split out the Domain information to be added in this task instead: T269767: Add Domain info to the IP Information box

Tchanders renamed this task from Add ISPinfo to IP Information box to Add ISP info to IPInfo API response.Dec 9 2020, 5:22 PM

Tchanders updated the task description. (Show Details)

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Dec 9 2020, 8:57 PM

The API now returns an entry for "ISP". However, the GeoLite2 database we are testing with does not contain any ISP information, so it will always just return isp: null.

There isn't much I can do to test this at the moment.

• Niharika closed this task as Resolved.Dec 14 2020, 5:15 PM

• Niharika mentioned this in T287647: IP Information accordion on Special:Contribs.Jul 28 2021, 11:10 PM

• Niharika added a parent task: T287647: IP Information accordion on Special:Contribs.Jul 28 2021, 11:13 PM

• Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:59 PM