Page MenuHomePhabricator
Create Task
Maniphest T270263

Implement localisation and internationalisation in the tool
Closed, ResolvedPublic
Actions

Description

VideoCutTool is a tool to trim, crop, rotate on-the-fly videos in Wikimedia Commons and can be found at https://videocuttool.wmflabs.org/

Task:

  • Learn about VideoCutTool from Commons: VideoCutTool
  • Using react antd's ConfigProvider module implement the localization and internationalization to all the required items in the tool.

Code repos:

If you need any help, please feel free to comment here, happy to help you!

Details

SubjectRepoBranchLines +/-
Implement Internationalisationlabs/tools/VideoCutToolmaster+439 -186
Customize query in gerrit

Related Objects
Search...

Event Timeline

Gopavasanth created this task.Dec 16 2020, 11:03 AM
Aklapper renamed this task from Implement localisation and internalisation in the tool to Implement localisation and internationalisation in the tool.Dec 17 2020, 10:09 AM
Aklapper updated the task description. (Show Details)
dbarratt removed a project: React-i18n.Dec 17 2020, 1:57 PM
dbarratt subscribed.

This task doesn't seem related to React-i18n, but I would highly recommend using it in your project. :)

dbarratt unsubscribed.Dec 17 2020, 1:57 PM
Tobi_406 subscribed.Dec 19 2020, 4:06 PM

Should React-i18n or antd's ConfingProvider be used now?

From a first look, React-i18n seems to be easier to implement and less code messy, while antd's ConfigProvider needs to be implemented directly in the code, but allows for some more functions (ltr/rtl specifically).
Might also just be not knowing much about how that works in antd.

Gopavasanth added a comment.Dec 19 2020, 4:16 PM

@Tobi_406 Yes, You are right I had a look at React-i18n earlier today and it's super fine, also easy to implement. I'm happy to go with either method(react-i18n or antd's ConfigProvider) in VideoCutTool, So feel free to claim the ticket and patch it ;-)

Gopavasanth awarded a token.Dec 19 2020, 4:16 PM
gerritbot added a comment.Dec 19 2020, 6:43 PM

Change 650806 had a related patch set uploaded (by Tobi 406; owner: Tobi 406):
[labs/tools/VideoCutTool@master] Implement internationalisation

https://gerrit.wikimedia.org/r/650806

gerritbot added a project: Patch-For-Review.Dec 19 2020, 6:43 PM
Tobi_406 claimed this task.Dec 19 2020, 6:45 PM
Tobi_406 updated the task description. (Show Details)
Gopavasanth added a parent task: T270581: Add VideoCutTool to translatewiki.net.Dec 21 2020, 4:30 AM
gerritbot added a comment.Jan 4 2021, 1:51 PM

Change 650806 merged by jenkins-bot:
[labs/tools/VideoCutTool@master] Implement Internationalisation

https://gerrit.wikimedia.org/r/650806

Gopavasanth mentioned this in rLTVT63eb78497c64: Implement Internationalisation.Jan 4 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 4 2021, 2:10 PM
Gopavasanth added a comment.Jan 11 2021, 9:05 AM

Hey @Tobi_406 ! Your patch is merged now, If you are still interested, Can you please add more languages in the dropdown? Thanks a lot!

Gopavasanth mentioned this in T272240: Dynamically import languages list for VideoCutTool dropdown.Jan 17 2021, 1:30 PM
Gopavasanth closed this task as Resolved.Feb 19 2021, 6:07 PM

Thanks for your work @Tobi_406 !!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL