When using AbuseFilter on MediaWiki 1.35 on PHP 7.4 I get the below error. I’m using AbuseFilter on REL1_35
Steps to Reproduce:
Install AbuseFilter on MediaWiki 1.35 with PHP7.4
Actual Results:
PHP Notice: Trying to access array offset on value of type null in /var/www/html/extensions/AbuseFilter/includes/Views/AbuseFilterViewDiff.php on line 212
Expected Results:
No PHP Warning
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Check for non-existing version in ViewDiff | mediawiki/extensions/AbuseFilter | master | +5 -1 |
Install AbuseFilter on MediaWiki 1.35 with PHP7.4
This isn't a replication criteria. I doubt just installing it results in an error in AbuseFilterViewDiff.
What do you mean by "using AbuseFilter"? Visiting Special:AbuseFilter? Triggering a filter? Somthing else?
Actually, looking at my access logs, I can see that at the times that the error comes up somebody tried to access invalid diffs.
Yeah, I think this is possible. The code doesn't check for null. The notice should be avoided nonetheless.
Change 654225 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Check for non-existing version in ViewDiff
Change 654225 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Check for non-existing version in ViewDiff