Page MenuHomePhabricator
Create Task
Maniphest T271438

Citoid breaks URLs for www.transfermarkt.de - domain replaced by underscore in URL
Open, Needs TriagePublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. Open a wikipage in Visual Editor (e.g. https://de.wikipedia.org/w/index.php?title=Wikipedia:Spielwiese&veaction=edit )
  2. Select "Cite" and "Automatic"
  3. Paste the URL https://www.transfermarkt.de/wechsel-im-winter-brentford-verpflichtet-dervi%C5%9Fo%C4%9Flu-watkins-verlangert-langfristig/view/news/342949 into the box and click on "Create"
  4. Move the cursor over the created link to see the URL

Actual Results:

The host is missing in the URL: https://_/wechsel-im-winter-brentford-verpflichtet-dervi%C5%9Fo%C4%9Flu-watkins-verlangert-langfristig/view/news/342949

Expected Results:

The link should point to the correct URL as put into the dialog box

Related Objects

Event Timeline

Wickie37 created this task.Jan 7 2021, 4:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2021, 4:54 PM
Aklapper renamed this task from Citoid breaks URLs for www.transfermarkt.de to Citoid breaks URLs for www.transfermarkt.de - domain replaced by underscore in URL.Jan 7 2021, 4:56 PM
Aklapper updated the task description. (Show Details)

Hi @Wickie37, thanks for taking the time to report this! Confirming.

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Jan 12 2021, 4:23 PM
ppelberg added a subscriber: Mvolz.
matmarex subscribed.Jan 12 2021, 7:02 PM

The site itself defines the incorrect URL. From the HTML source of https://www.transfermarkt.de/wechsel-im-winter-brentford-verpflichtet-dervişoğlu-watkins-verlangert-langfristig/view/news/342949:

<meta property="og:url" content="https://_/wechsel-im-winter-brentford-verpflichtet-dervi%C5%9Fo%C4%9Flu-watkins-verlangert-langfristig/view/news/342949" />
Mvolz added a comment.EditedJan 14 2021, 7:19 PM
In T271438#6740988, @matmarex wrote:

The site itself defines the incorrect URL. From the HTML source of https://www.transfermarkt.de/wechsel-im-winter-brentford-verpflichtet-dervişoğlu-watkins-verlangert-langfristig/view/news/342949:

<meta property="og:url" content="https://_/wechsel-im-winter-brentford-verpflichtet-dervi%C5%9Fo%C4%9Flu-watkins-verlangert-langfristig/view/news/342949" />

Yeah we can probably file this one under T242089 ( Consider keeping user entered URL and removing tracking parameters) or close it as a duplicate; it's an inevitable consequence of using the URL as defined by the resource, as opposed to the user entered one.

Wickie37 added a comment.Jan 15 2021, 10:35 AM

Thanks for your comments. Now I had a look at the source code myself. It does define the correct URL:

<link rel="canonical" href="https://www.transfermarkt.de/wechsel-im-winter-brentford-verpflichtet-dervi%C5%9Fo%C4%9Flu-watkins-verlangert-langfristig/view/news/342949" />

Open Graph has a different purpose and - in my opinion - shouldn't be used here. Or at least shouldn't be preferred over '<link rel="canonical"'.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits