Page MenuHomePhabricator
Create Task
Maniphest T272124

AbuseFilterBlockTest::testRevert fails for GrowthExperiments builds
Closed, ResolvedPublic
Actions

Description

First noticed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/656370, see build https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/57505/console

There were 3 errors:
09:32:31 
09:32:31 1) AbuseFilterBlockTest::testRevert with data set "not blocked by AF user" (class@anonymous/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterBlockTest.php0x7fbea9a83f66 Object (...), null, false)
09:32:31 Wikimedia\Assert\ParameterTypeException: Bad value for parameter $localDomainId: must be a string
09:32:31 
09:32:31 /workspace/src/vendor/wikimedia/assert/src/Assert.php:105
09:32:31 /workspace/src/includes/externalstore/ExternalStoreFactory.php:37
09:32:31 /workspace/src/includes/ServiceWiring.php:421
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:750
09:32:31 /workspace/src/includes/ServiceWiring.php:408
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:742
09:32:31 /workspace/src/includes/ServiceWiring.php:179
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:533
09:32:31 /workspace/src/includes/ServiceWiring.php:1190
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:1228
09:32:31 /workspace/src/includes/ServiceWiring.php:1174
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:1220
09:32:31 /workspace/src/includes/ServiceWiring.php:1160
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:1204
09:32:31 /workspace/src/extensions/GrowthExperiments/ServiceWiring.php:67
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:424
09:32:31 /workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory.php:209
09:32:31 /workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory.php:150
09:32:31 /workspace/src/includes/HookContainer/HookContainer.php:468
09:32:31 /workspace/src/includes/HookContainer/HookContainer.php:159
09:32:31 /workspace/src/includes/HookContainer/HookRunner.php:2601
09:32:31 /workspace/src/includes/cache/MessageCache.php:929
09:32:31 /workspace/src/includes/language/Message.php:1294
09:32:31 /workspace/src/includes/language/Message.php:851
09:32:31 /workspace/src/includes/language/Message.php:943
09:32:31 /workspace/src/includes/title/MalformedTitleException.php:51
09:32:31 /workspace/src/includes/title/MediaWikiTitleCodec.php:346
09:32:31 /workspace/src/includes/title/MediaWikiTitleCodec.php:174
09:32:31 /workspace/src/includes/user/UserNameUtils.php:279
09:32:31 /workspace/src/includes/user/UserFactory.php:88
09:32:31 /workspace/src/includes/block/BlockUtils.php:121
09:32:31 /workspace/src/includes/block/AbstractBlock.php:343
09:32:31 /workspace/src/includes/block/AbstractBlock.php:423
09:32:31 /workspace/src/includes/block/AbstractBlock.php:117
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:102
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:469
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:300
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:881
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:850
09:32:31 /workspace/src/extensions/AbuseFilter/includes/Consequences/Consequence/Block.php:70
09:32:31 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterBlockTest.php:179
09:32:31 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:446
09:32:31 /workspace/src/maintenance/doMaintenance.php:106
09:32:31 === Logs generated by test case
09:32:31 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
09:32:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:32:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:32:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:32:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:32:31 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
09:32:31 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
09:32:31 ===
09:32:31 
09:32:31 2) AbuseFilterBlockTest::testRevert with data set "cannot delete block" (class@anonymous/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterBlockTest.php0x7fbea9a83f66 Object (...), Mock_DatabaseBlockStore_6f606b33 Object (...), false)
09:32:31 Wikimedia\Assert\ParameterTypeException: Bad value for parameter $localDomainId: must be a string
09:32:31 
09:32:31 /workspace/src/vendor/wikimedia/assert/src/Assert.php:105
09:32:31 /workspace/src/includes/externalstore/ExternalStoreFactory.php:37
09:32:31 /workspace/src/includes/ServiceWiring.php:421
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:750
09:32:31 /workspace/src/includes/ServiceWiring.php:408
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:742
09:32:31 /workspace/src/includes/ServiceWiring.php:179
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:533
09:32:31 /workspace/src/includes/ServiceWiring.php:1190
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:1228
09:32:31 /workspace/src/includes/ServiceWiring.php:1174
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:1220
09:32:31 /workspace/src/includes/ServiceWiring.php:1160
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:1204
09:32:31 /workspace/src/extensions/GrowthExperiments/ServiceWiring.php:67
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:424
09:32:31 /workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory.php:209
09:32:31 /workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory.php:150
09:32:31 /workspace/src/includes/HookContainer/HookContainer.php:468
09:32:31 /workspace/src/includes/HookContainer/HookContainer.php:159
09:32:31 /workspace/src/includes/HookContainer/HookRunner.php:2601
09:32:31 /workspace/src/includes/cache/MessageCache.php:929
09:32:31 /workspace/src/includes/language/Message.php:1294
09:32:31 /workspace/src/includes/language/Message.php:851
09:32:31 /workspace/src/includes/language/Message.php:943
09:32:31 /workspace/src/includes/title/MalformedTitleException.php:51
09:32:31 /workspace/src/includes/title/MediaWikiTitleCodec.php:346
09:32:31 /workspace/src/includes/title/MediaWikiTitleCodec.php:174
09:32:31 /workspace/src/includes/user/UserNameUtils.php:279
09:32:31 /workspace/src/includes/user/UserFactory.php:88
09:32:31 /workspace/src/includes/block/BlockUtils.php:121
09:32:31 /workspace/src/includes/block/AbstractBlock.php:343
09:32:31 /workspace/src/includes/block/AbstractBlock.php:423
09:32:31 /workspace/src/includes/block/AbstractBlock.php:117
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:102
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:469
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:300
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:881
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:850
09:32:31 /workspace/src/extensions/AbuseFilter/includes/Consequences/Consequence/Block.php:70
09:32:31 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterBlockTest.php:179
09:32:31 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:446
09:32:31 /workspace/src/maintenance/doMaintenance.php:106
09:32:31 === Logs generated by test case
09:32:31 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
09:32:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:32:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:32:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:32:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:32:31 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
09:32:31 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
09:32:31 ===
09:32:31 
09:32:31 3) AbuseFilterBlockTest::testRevert with data set "succeed" (class@anonymous/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterBlockTest.php0x7fbea9a83f66 Object (...), Mock_DatabaseBlockStore_6f606b33 Object (...), true)
09:32:31 Wikimedia\Assert\ParameterTypeException: Bad value for parameter $localDomainId: must be a string
09:32:31 
09:32:31 /workspace/src/vendor/wikimedia/assert/src/Assert.php:105
09:32:31 /workspace/src/includes/externalstore/ExternalStoreFactory.php:37
09:32:31 /workspace/src/includes/ServiceWiring.php:421
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:750
09:32:31 /workspace/src/includes/ServiceWiring.php:408
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:742
09:32:31 /workspace/src/includes/ServiceWiring.php:179
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:533
09:32:31 /workspace/src/includes/ServiceWiring.php:1190
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:1228
09:32:31 /workspace/src/includes/ServiceWiring.php:1174
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:1220
09:32:31 /workspace/src/includes/ServiceWiring.php:1160
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/includes/MediaWikiServices.php:1204
09:32:31 /workspace/src/extensions/GrowthExperiments/ServiceWiring.php:67
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
09:32:31 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:424
09:32:31 /workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory.php:209
09:32:31 /workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory.php:150
09:32:31 /workspace/src/includes/HookContainer/HookContainer.php:468
09:32:31 /workspace/src/includes/HookContainer/HookContainer.php:159
09:32:31 /workspace/src/includes/HookContainer/HookRunner.php:2601
09:32:31 /workspace/src/includes/cache/MessageCache.php:929
09:32:31 /workspace/src/includes/language/Message.php:1294
09:32:31 /workspace/src/includes/language/Message.php:851
09:32:31 /workspace/src/includes/language/Message.php:943
09:32:31 /workspace/src/includes/title/MalformedTitleException.php:51
09:32:31 /workspace/src/includes/title/MediaWikiTitleCodec.php:346
09:32:31 /workspace/src/includes/title/MediaWikiTitleCodec.php:174
09:32:31 /workspace/src/includes/user/UserNameUtils.php:279
09:32:31 /workspace/src/includes/user/UserFactory.php:88
09:32:31 /workspace/src/includes/block/BlockUtils.php:121
09:32:31 /workspace/src/includes/block/AbstractBlock.php:343
09:32:31 /workspace/src/includes/block/AbstractBlock.php:423
09:32:31 /workspace/src/includes/block/AbstractBlock.php:117
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:102
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:469
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:300
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:881
09:32:31 /workspace/src/includes/block/DatabaseBlock.php:850
09:32:31 /workspace/src/extensions/AbuseFilter/includes/Consequences/Consequence/Block.php:70
09:32:31 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterBlockTest.php:179
09:32:31 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:446
09:32:31 /workspace/src/maintenance/doMaintenance.php:106
09:32:31 === Logs generated by test case
09:32:31 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
09:32:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:32:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:32:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:32:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:32:31 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
09:32:31 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
09:32:31 ===
09:32:31 
09:32:31 ERRORS!
09:32:31 Tests: 8922, Assertions: 28487, Errors: 3, Skipped: 62.

Details

SubjectRepoBranchLines +/-
Re-enable AbuseFilterBlockTest::testRevertmediawiki/extensions/AbuseFiltermaster+2 -1
tests: Mark testRevert as skipped due to unrelated failuremediawiki/extensions/AbuseFiltermaster+1 -0
tests: Mark testRevert as skipped due to unrelated failuremediawiki/extensions/AbuseFilterwmf/1.36.0-wmf.26+185 -0
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Jan 15 2021, 8:44 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 15 2021, 8:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as High priority.Jan 15 2021, 8:46 AM
Tgr subscribed.Jan 15 2021, 8:53 AM

Caused by rEABFab2ad164ff97: Improve coverage around consequences presumably.

gerritbot added a comment.Jan 15 2021, 8:53 AM

Change 656374 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/AbuseFilter@master] tests: Mark testRevert as skipped due to unrelated failure

https://gerrit.wikimedia.org/r/656374

gerritbot added a project: Patch-For-Review.Jan 15 2021, 8:53 AM
Tgr added a comment.Jan 15 2021, 8:55 AM

Or rather, by the interference between that patch and the PageSaveCompleteHook in GrowthExperiments.

Tgr added a comment.Jan 15 2021, 9:01 AM

The error is caused by $services->getDBLoadBalancer()->getLocalDomainID() returning null, since AbuseFilterBlockTest::testRevert() mocks it. Which is not an unreasonable thing to do; not sure how this kind of thing should be handled...

gerritbot added a comment.Jan 15 2021, 9:24 AM

Change 656302 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/AbuseFilter@wmf/1.36.0-wmf.26] tests: Mark testRevert as skipped due to unrelated failure

https://gerrit.wikimedia.org/r/656302

gerritbot added a comment.Jan 15 2021, 9:25 AM

Change 656302 abandoned by Kosta Harlan:
[mediawiki/extensions/AbuseFilter@wmf/1.36.0-wmf.26] tests: Mark testRevert as skipped due to unrelated failure

Reason:
not needed in wmf.26

https://gerrit.wikimedia.org/r/656302

gerritbot added a comment.Jan 15 2021, 9:48 AM

Change 656374 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] tests: Mark testRevert as skipped due to unrelated failure

https://gerrit.wikimedia.org/r/656374

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 15 2021, 10:00 AM
Daimona subscribed.Jan 15 2021, 12:00 PM

Heh, this test is crappy TBH. Unless DatabaseBlock::newFromTarget is made non-static and moved to a proper service, there's no real way to mock dependencies. So I'm just going to kill any hook handler during the test; I had already tried it locally because I was getting failures from MobileFrontend, although I eventually managed to fix it in another way.

gerritbot added a comment.Jan 15 2021, 12:01 PM

Change 656390 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Re-enable AbuseFilterBlockTest::testRevert

https://gerrit.wikimedia.org/r/656390

gerritbot added a comment.Jan 15 2021, 4:22 PM

Change 656390 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Re-enable AbuseFilterBlockTest::testRevert

https://gerrit.wikimedia.org/r/656390

Daimona closed this task as Resolved.Jan 15 2021, 5:25 PM
Daimona claimed this task.
Daimona removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL