Page MenuHomePhabricator
Create Task
Maniphest T272389

Starting a new discussion while the tool is already open will launch the old editor
Closed, ResolvedPublic
Actions

Description

  1. Click "New section"
  2. Scroll up and click "New section" again

Expected
You are scrolled to the new tool which is already open.

Actual
The old new-section tool is opened

Details

SubjectRepoBranchLines +/-
CommentController: Better handle clicking links while already commentingmediawiki/extensions/DiscussionToolsmaster+26 -6
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jan 19 2021, 3:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2021, 3:38 PM
matmarex claimed this task.Jan 19 2021, 7:21 PM
matmarex added a project: Editing-team (Kanban Board).
gerritbot added a comment.Jan 19 2021, 8:22 PM

Change 657179 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] CommentController: Better handle clicking links while already commenting

https://gerrit.wikimedia.org/r/657179

gerritbot added a project: Patch-For-Review.Jan 19 2021, 8:22 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Jan 19 2021, 8:30 PM
Esanders moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Jan 20 2021, 12:24 AM
Esanders added a project: Skipped QA.
gerritbot added a comment.Jan 20 2021, 12:28 AM

Change 657179 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] CommentController: Better handle clicking links while already commenting

https://gerrit.wikimedia.org/r/657179

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 20 2021, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 20 2021, 1:10 AM
ppelberg closed this task as Resolved.Jan 20 2021, 5:41 AM
matmarex mentioned this in T272545: New Discussion Tool does not open if you have Reply Tool open from before. .Jan 20 2021, 11:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits