Page MenuHomePhabricator

New Discussion Tool does not open if you have Reply Tool open from before.
Closed, ResolvedPublic

Description

Steps to replicate:

  1. Click on the Reply link button next to a comment to open up the Reply Tool.
  2. Now open the New Discussion Tool clicking on the Edit Source link on top.

Observe that, it does not open the New Discussion Tool but rather it opens up the source editor for the entire page.

Event Timeline

Actually.. now it does nothing, just keeps the Reply tool open. Is that expected?

Observe that, it does not open the New Discussion Tool but rather it opens up the source editor for the entire page.

Actually.. now it does nothing, just keeps the Reply tool open. Is that expected?

This changed in T272389 today(-ish).

A proper solution to this would probably require T257305 first.

Observe that, it does not open the New Discussion Tool but rather it opens up the source editor for the entire page.

Actually.. now it does nothing, just keeps the Reply tool open. Is that expected?

This changed in T272389 today(-ish).

A proper solution to this would probably require T257305 first.

@matmarex, in the interim, could we make it so in the scenario @Ryasmeen is describing, the New Discussion Tool open and the Reply Tool is closed (see "Potential behavior" below)? cc @iamjessklein

Potential behavior

  1. Visit a page on a wiki where both the Reply Tool and New Discussion Tool available (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Ppelberg-test)
  2. Click on the [ reply] link button next to a comment to open up the Reply Tool.
  3. Click on the New Sectiontab/link at the top of the talk page
  4. If the Reply Tool does NOT contain any content at the time "Step 2." is taken, close the Reply Tool and open the New Discussion Tool.
  5. If the Reply Tool does contain content at the time "Step 2." is taken, show people a warning alerting them that to proceed with adding a new topic they'll need to either publish or discard the comment they started drafting after "Step 1."

Change 658451 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] CommentController: Even better handle clicking links while already commenting

https://gerrit.wikimedia.org/r/658451

I implemented that to see how it works, but I'm not sure if I like it. I feel like we're making up too many special cases to understand how it's supposed to work.

I implemented that to see how it works, but I'm not sure if I like it.

It seems better to me than disabling the "Add topic" tap without providing people any feedback as to why this is so.

With the above said, I don't have a strong sense for what the ideal experience looks like.

As such, I'm copying @iamjessklein here to express an opinion. Note: Jess, I've tried to create a "TLDR" of the current conversation in the table below.[i]

I feel like we're making up too many special cases to understand how it's supposed to work.

@matmarex, can you please expand on this thought?


i. IssueResulting questionCurrent implementationProposed alternative
The Reply Tool and New Discussion Tool cannot, currently, be open on the same page simultaneouslyWhat should happen when someone attempts to open the New Discussion Tool when they already have the Reply Tool open?When someone attempts to open the New Discussion Tool while they have a Reply Tool open, nothing happens...the Reply Tool they had open remains open. Read: clicking "Add topic" has no effect.When someone attempts to open the New Discussion Tool while they have a Reply Tool open, close the Reply Tool and open the New Discussion Tool. See prototype.

In general, one of our design principles around this work is doing one thing at a time to allow a contributor to stay focused. I think that this prototype accomplishes that. That said, I am having some trouble with the prototype. I get this error @matmarex

Change 658451 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] CommentController: Even better handle clicking links while already commenting

https://gerrit.wikimedia.org/r/658451

In general, one of our design principles around this work is doing one thing at a time to allow a contributor to stay focused. I think that this prototype accomplishes that. That said, I am having some trouble with the prototype. I get this error @matmarex

Unrelated bug: T272922: Logged out users get an error instead of a CAPTCHA in DiscussionTools – please log in to avoid the CAPTCHA causing this issue.

(We merged the patch implementing the behavior proposed in T272545#6767850 – we should probably open another task for further work, or maybe just do it on T257305: Allow multiple replies to be drafted at the same time.)

I was just chatting with @Pginer-WMF about this issue and what we came to is that there are two design principles that are at tension here. On one hand you have this idea that you want to do one thing at a time so a contributor doesn't lose focus on their edit, however, on the other hand we want to provide contributors with as much feedback and input about the state of their edits so that they don't lose their bearings within the page. If we were to pursue work on this, I think that we should focus on the problem of multitasking within this space. The solution here might be to leave everything open, but when an input goes out of the contributor's viewport, provide them with a "back to draft" button for quick access to this type of content.

(We merged the patch implementing the behavior proposed in T272545#6767850.

Noted.

– we should probably open another task for further work, or maybe just do it on T257305: Allow multiple replies to be drafted at the same time.)

See: T273255.

Note: @iamjessklein I copied the comment you posted in T272545#6780667 to the newly-created T273255 where we will define the over-arching approach that will inform how various discussion tools behave in relation to each other and the pages on which they exist.

ppelberg claimed this task.