Page MenuHomePhabricator

Define how the Reply and New Topic Tools relate to each other and the page they can be used on
Open, Needs TriagePublic

Description

This task is about deciding on a conceptual approach for how the Reply Tool(s) and New Topic Tool relate to each other and the pages they can be used on.

This task was promoted by @matmarex observing [i] that we are at/near the point where there are enough cases where the Reply Tool and New Topic Tool behave differently that this behavior is difficult to keep track of. We understand this as a signal that the confusion we are experiencing is confusion volunteers are also likely to feel as well.

Background

ItemCurrent behaviorReason
#1A single Reply Tool can be open on a page at any given time.Technical constraints which may be no longer. See: T257305
#2The Reply Tool and the New Topic Tool cannot be open at the same timeA short-term fix to avoid people potentially becoming confused why they can't click the Add topic button while they have a Reply Tool open. See: T272545#6767850.
#3It may not be immediately clear to people what comment the Reply Tool they have open is related to.1. There is currently no visual element that explicitly relates the Reply Tool to the comment someone opened the tool to respond to [ii]. 2. The Reply Tool opens on the page at the position where the comment people are drafting with it will be posted. Thus, in conversations with many comments, the Reply Tool will appear relatively "far away" from the comment someone opened the tool to respond to.
#4Related to "#1" the Reply Tool behaves kind of like a modal in so far as it changes the state of some parts of the page ([reply] links), but not all.See #"Reason" for #1 above.

Scenarios

  1. Someone tries to open another Reply Tool while they already have one open.
  2. Someone tries to open the New Topic Tool while they already have a Reply Tool open.
  3. Someone tries to open a Reply Tool while they already have a New Topic Tool open.

Requirements

  • People should easily know what – if any – "discussion tool" (New Topic Tool or Reply Tool) is open the page, regardless of "where" they are on that page.
  • People should instinctively know how to open the New Topic Tool or Reply Tool, regardless of whether any other tool(s) is already open on the page.
  • People should be confident they know what will happen when they post content to the page using a discussion tool.
    • Said in other ways:
      • People should not be led to question what happens when they post a comment using a particular Reply Tool. This case assumes people are able to open multiple Reply Tools at once as T257305 describes.
      • People should not be led to question what a particular discussion tool is for.

Approaches

  1. Disable all links when a Discussion Tool is open
    • TODO: clarify what "all links" means in this context. E.g. all discussion tool links? Every single link on the page? Something else?
  2. Enable as many Discussion Tools to be open at any given time
  3. TBD

Open questions

  • What other ===Secanrios will the to-be-decided upon approach need to accommodate for?
  • What are possible ===Approaches that satisfy the ===Requirements in each of the ===Scenarios described above?

Done

  • An approach is decided upon that satisfies the requirements in each scenario described above.

i. T272545#6775562
ii. The Reply Tool is indented which gives some indication of its relationship to the comment being replied to, but I would say this creates more of an "implicit" relationship.

Event Timeline

ppelberg added subscribers: iamjessklein, Pginer-WMF.

I was just chatting with @Pginer-WMF about this issue and what we came to is that there are two design principles that are at tension here. On one hand you have this idea that you want to do one thing at a time so a contributor doesn't lose focus on their edit, however, on the other hand we want to provide contributors with as much feedback and input about the state of their edits so that they don't lose their bearings within the page. If we were to pursue work on this, I think that we should focus on the problem of multitasking within this space. The solution here might be to leave everything open, but when an input goes out of the contributor's viewport, provide them with a "back to draft" button for quick access to this type of content.

I'm imagining something like this:

  • It's possible to open any number of reply tools and the new-topic tool on the page, all at once (but probably just one reply per comment).
  • When you're drafting one comment, and you scroll away from it, a panel with some buttons appears at the bottom of the screen:
You are drafting a comment on this page. Go to draft Discard
  • When drafting multiple, the panel is always always visible to allow navigating between the comments:
You are drafting 3 comments on this page. Go to next draft Discard all Submit all

Do we have a working definition somewhere of what the Discussion tool is? I'm asking because I find this conversation a bit confusing to engage with as I see the reply tool as a part of the Discussion Tools.

It's about the tool for adding new topics. I'll change the description to make it clearer.

matmarex renamed this task from Define how the Reply and New Discussion Tools relate to each other and the page they can be used on to Define how the Reply and New Topic Tools relate to each other and the page they can be used on.Sep 10 2021, 6:38 PM
matmarex updated the task description. (Show Details)

And in this context, "discussion tool" means "either the new topic tool or the reply tool", in case that was the confusing part. We don't really use that term elsewhere though.