Allow defining the order of change tags defined by the software
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Jan 25 2021, 6:36 PM

Description

Currently, when change tags are displayed on history pages, recent changes, and so on, it is impossible to control their order.

Apparently they are ordered according to the ctd_id field, but this seems to be an unintentional effect of how the SQL queries are written.

The ctd_id field is generated automatically whenever the tag is used for the first time, which means that the order of tags can be different on different wikis. It also means we can't choose a particular order we would like (T272768).

I'd like the tags to appear in some defined order, e.g. the same as the result of the ListDefinedTags hook.

Desired behavior

Visit a page where people have made edits with the New Discussion Tool.
- e.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Cats&action=history
Locate an edit made with the New Discussion Tool.
- e.g. Ppelberg-test talk contribs‎ 33,200 bytes +173‎ →‎Testing change tag: new section undo Tags: Visual New topic
✅Notice the New topic tag appears BEFORE the mode (e.g. Source or Visual) used to publish said edit.

Done

===Desired behavior is implemented

Details

	Subject	Repo	Branch	Lines +/-
	Consistently order change tags	mediawiki/core	master	+5 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ppelberg	T272929 Revise New Discussion Tool change tag order
		Resolved		matmarex	T272900 Allow defining the order of change tags defined by the software

Event Timeline

matmarex created this task.Jan 25 2021, 6:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2021, 6:36 PM

matmarex added a parent task: T272768: Revise New Discussion Tool change tags.Jan 25 2021, 6:36 PM

matmarex mentioned this in T272768: Revise New Discussion Tool change tags.

Change 658354 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Consistently order change tags

https://gerrit.wikimedia.org/r/658354

gerritbot added a project: Patch-For-Review.Jan 25 2021, 6:37 PM

I'm trying to figure out what effect this change would have on enwiki. I'm not sure how to present it, but here's the raw data:

Current order of tags: https://quarry.wmflabs.org/query/51855
Order with my proposed patch: https://phabricator.wikimedia.org/P13947

Alright, I devised this terrible query. It looks at all en.wp edits over the last 2 weeks (it's impractically slow to query more), and then counts those where the order of tags would change. https://quarry.wmflabs.org/query/51859

Quick observations:

It's a huge mess of abuse filter tags
It seems that the most common effect is that the "mw-reverted" tag moves from the end to the beginning
Second most common is apparently the "mw-undo" tag moving the opposite way, from the beginning to the end
Another common change is "visualeditor" moving before "mobile edit,mobile web edit"
The expected change to DiscussionTools tags appears as well (with 20 occurrences)

Overall, it probably does not matter, but I wanted to see.

ppelberg subscribed.Jan 25 2021, 10:18 PM

ppelberg mentioned this in T272929: Revise New Discussion Tool change tag order.Jan 26 2021, 12:39 AM

ppelberg updated the task description. (Show Details)

ppelberg updated the task description. (Show Details)Jan 26 2021, 12:41 AM

matmarex edited parent tasks, added: T272929: Revise New Discussion Tool change tag order; removed: T272768: Revise New Discussion Tool change tags.Jan 26 2021, 1:04 AM

Change 658354 merged by jenkins-bot:

[mediawiki/core@master] Consistently order change tags

https://gerrit.wikimedia.org/r/658354

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 24 2021, 2:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 24 2021, 2:10 AM

matmarex closed this task as Resolved.Dec 28 2021, 2:21 PM